Revert TCP connect and send delay fix (#6213) #6440
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PR#6213 makes the pubsubclient library to hung (device unresponsive) for 5 seconds if the MQTT broker is down and it is trying to reconnect. Reverting just this commit makes the STAGE core to be fast again as core 2.5.2 while using MQTT.
This was referenced Aug 23, 2019
|
If any test or anything extra is needed, please just let me know. Thanks |
|
This patch is useful for ethernet. |
|
I forgot to mention that our tests for this issue under Tasmota are without encryption. Just plain unsecured mqtt. That is why is easy to test and find this 5 seconds lag |
|
Can you try with #6454 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR #6213 makes the pubsubclient library to hung (device unresponsive) for 5 seconds if the MQTT broker is down and it is trying to reconnect.
Reverting just this commit makes the STAGE core to be fast again as core 2.5.2 while using MQTT.