Skip to content

Fix optimistic_yield to not yield on each call after x µs #6804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Feb 20, 2020
Merged

Fix optimistic_yield to not yield on each call after x µs #6804

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d6e603f
Fix optimistic_yield to not yield on every call after a loop runs for…
dok-net Nov 18, 2019
598361f
Substitute micros() by CPU cycles - faster, but large values for inte…
dok-net Nov 19, 2019
3d7423b
Move yield start time set to esp_yield_within_cont
dok-net Nov 19, 2019
3767791
Allow constexpr evalution to occur. optimistic_yield is always called…
dok-net Dec 2, 2019
5544357
Due to 3rd party use of symbol optimistic_yield without #include <Ard…
dok-net Dec 2, 2019
8d2eca5
Remove long-since disused define.
dok-net Dec 18, 2019
50fab51
No need for preprocessor undefinition of optimistic_yield, after all.
dok-net Dec 24, 2019
afe4021
Corrections after review remarks; thanks @earlephilhower
dok-net Feb 20, 2020
5100bee
Merge branch 'master' into optimistic_yield_recurrency
earlephilhower Feb 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cores/esp8266/Arduino.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,7 @@ void setup(void);
void loop(void);

void yield(void);

void optimistic_yield(uint32_t interval_us);

#define _PORT_GPIO16 1
Expand Down
19 changes: 12 additions & 7 deletions cores/esp8266/core_esp8266_main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ extern "C" {

#define LOOP_TASK_PRIORITY 1
#define LOOP_QUEUE_SIZE 1
#define OPTIMISTIC_YIELD_TIME_US 16000

extern "C" void call_user_start();
extern void loop();
Expand All @@ -58,7 +57,7 @@ cont_t* g_pcont __attribute__((section(".noinit")));
static os_event_t s_loop_queue[LOOP_QUEUE_SIZE];

/* Used to implement optimistic_yield */
static uint32_t s_micros_at_task_start;
static uint32_t s_cycles_at_yield_start;

/* For ets_intr_lock_nest / ets_intr_unlock_nest
* Max nesting seen by SDK so far is 2.
Expand Down Expand Up @@ -97,6 +96,7 @@ extern "C" bool can_yield() {
static inline void esp_yield_within_cont() __attribute__((always_inline));
static void esp_yield_within_cont() {
cont_yield(g_pcont);
s_cycles_at_yield_start = ESP.getCycleCount();
run_scheduled_recurrent_functions();
}

Expand Down Expand Up @@ -125,14 +125,19 @@ extern "C" void __yield() {
extern "C" void yield(void) __attribute__ ((weak, alias("__yield")));

extern "C" void optimistic_yield(uint32_t interval_us) {
if (can_yield() &&
(system_get_time() - s_micros_at_task_start) > interval_us)
const uint32_t intvl_cycles = interval_us *
#if defined(F_CPU)
clockCyclesPerMicrosecond();
#else
ESP.getCpuFreqMHz();
#endif
if ((ESP.getCycleCount() - s_cycles_at_yield_start) > intvl_cycles &&
can_yield())
{
yield();
}
}


// Replace ets_intr_(un)lock with nestable versions
extern "C" void IRAM_ATTR ets_intr_lock() {
if (ets_intr_lock_stack_ptr < ETS_INTR_LOCK_NEST_MAX)
Expand Down Expand Up @@ -183,7 +188,7 @@ static void loop_wrapper() {

static void loop_task(os_event_t *events) {
(void) events;
s_micros_at_task_start = system_get_time();
s_cycles_at_yield_start = ESP.getCycleCount();
cont_run(g_pcont, &loop_wrapper);
if (cont_check(g_pcont) != 0) {
panic();
Expand Down Expand Up @@ -211,7 +216,7 @@ extern void __unhandled_exception(const char *str);
static void __unhandled_exception_cpp()
{
#ifndef __EXCEPTIONS
abort();
abort();
#else
static bool terminating;
if (terminating)
Expand Down