Skip to content

Fixes occasional UMM_POISON failure #8953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 18, 2023

Conversation

mhightower83
Copy link
Contributor

Bug introduced with PR fix #8914.
When a reallocated pointer could not grow in place, a replacement allocation was created. Then UMM_POISON was written to the wrong block.

This should resolve:

Bug introduced with PR fix esp8266#8914.
When a reallocated pointer could not grow in place, a replacement
allocation was created. Then UMM_POISON was written to the wrong block.
@mhightower83 mhightower83 marked this pull request as ready for review July 12, 2023 21:42
@d-a-v d-a-v added the alpha included in alpha release label Jul 18, 2023
Copy link
Collaborator

@d-a-v d-a-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I encountered this issue too, thanks for the fix !

@hmueller01
Copy link
Contributor

As written in #8952, this fixes my problems. Pls merge soon. Tx.

@d-a-v d-a-v merged commit dcceee8 into esp8266:master Jul 18, 2023
@mhightower83 mhightower83 deleted the pr-fix-realloc-poison2 branch February 6, 2024 00:10
hasenradball pushed a commit to hasenradball/Arduino that referenced this pull request Nov 18, 2024
* Fixes occasional UMM_POISON failure

Bug introduced with PR fix esp8266#8914.
When a reallocated pointer could not grow in place, a replacement
allocation was created. Then UMM_POISON was written to the wrong block.

* Fix umm_poison data corruption on realloc when memory move is used.

Bug introduced with PR fix esp8266#8914

* refactored to resolve unused error in some build contexts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alpha included in alpha release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants