-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Update gen_esp32part.py #11391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Update gen_esp32part.py #11391
Conversation
👋 Hello lucasssvaz, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Jason2866 Also LGTM. Just please fix the issue shown by the CI:
Don't have write rights in this PR. My suggestion is to change line 288 to |
Re-submission of #11379 with proper permissions.
from https://github.com/espressif/esp-idf/blob/release/v5.5/components/partition_table/gen_esp32part.py to support changes maybe done in upcoming partitions tables when using IDF 5.5 as base for Arduino