Skip to content

Fix compilation against recent IDF (DDR for SD_MMC) #1836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

muojp
Copy link

@muojp muojp commented Sep 5, 2018

Hi. Compiling current Arduino-ESP32 (a0f0bd9) against current ESP-IDF (espressif/esp-idf@e54f3d9) fails due to the newly added SD_MMC DDR support on ESP-IDF: espressif/esp-idf@78fab8a0f .

Error:

C:/msys32/home/muo/esp/blink/components/arduino/libraries/SD_MMC/src/SD_MMC.cpp: In member function 'bool fs::SDMMCFS::begin(const char*, bool)':
C:/msys32/home/muo/esp/blink/components/arduino/libraries/SD_MMC/src/SD_MMC.cpp:59:5: sorry, unimplemented: non-trivial designated initializers not supported
     };
     ^
<snip>
C:/msys32/home/muo/esp/blink/components/arduino/libraries/SD_MMC/src/SD_MMC.cpp:59:5: warning: missing initializer for member 'sdmmc_host_t::command_timeout_ms' [-Wmissing-field-initializers]

This pull-req is a simple fix for this issue which syncs initializers with current code.

@me-no-dev
Copy link
Member

there are far more issues than this now :) check this branch out: https://github.com/espressif/arduino-esp32/tree/idf-update

@me-no-dev
Copy link
Member

Changes are merged :)

@me-no-dev me-no-dev closed this Sep 21, 2018
@muojp
Copy link
Author

muojp commented Sep 21, 2018

Great to hear that. Will test the branch later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants