Skip to content

[2.0.0] BtClassic Discovery with info without connect #4811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 15, 2021

Conversation

ArcticSnowSky
Copy link
Contributor

@ArcticSnowSky ArcticSnowSky commented Feb 15, 2021

Hey guys,
so I wanted to do a BtClassic Discovery without the need to call connect
and to list all found devices on a display and continue work with that list.

I wasn't capable to test the example code with my file structure, but I did use the discovery already in some different situations.

However when I noted that the Bluedroid stack won't let me enforce an RfComm SPP connection to a GPS Device (Skytraxx 2 plus, I guess its interface is built so simple that it doesn't advertise its SPP over SDP), I will probably have to switch to BtStack (BlueKitchen) and stop on this side meanwhile

@me-no-dev me-no-dev changed the title BtClassic Discovery with info without connect [2.0.0] BtClassic Discovery with info without connect Feb 15, 2021
@VojtechBartoska VojtechBartoska added this to the 2.0.0 milestone Mar 2, 2021
synchronized branch with upstream master
@ArcticSnowSky
Copy link
Contributor Author

Hi, today I moved my changes into a separated branch and merged master into.
Do I have to create a new Pull request in this scenario?

@me-no-dev
Copy link
Member

no worries :) we can still use this one

@me-no-dev
Copy link
Member

Just please make sure that you fix the merge conflict with libraries/BluetoothSerial/src/BluetoothSerial.cpp

@patfelst
Copy link

I'm interested in using this, it will be very useful for my project - thanks @ArcticSnowSky. How do I use this code before it is merged into master, or will that happen soon?

@ArcticSnowSky
Copy link
Contributor Author

will be very useful for my project - thanks @ArcticSnowSky. How do I use this code before it is merged into master, or will that happe

Hi, I for my part - at the beginning - copied the BluetoothSerial folder into my project folder and used those as direct include (Simple approach).
Later on I used this forked and modified repo in my .platformio with a @3.6 (as the newest platform-framework is used by platformio in my case), this approach is probably more complicated, but might be cleaner from the perspective of your project.

@patfelst
Copy link

patfelst commented Mar 14, 2021

Thanks I've worked out how to clone the repository (I think!) and will replace the "BluetoothSerial" Platfromio folder with your work.

@me-no-dev me-no-dev merged commit 41c372c into espressif:master Apr 15, 2021
talltechdude pushed a commit to talltechdude/arduino-esp32 that referenced this pull request Apr 23, 2021
Hey guys,
so I wanted to do a BtClassic Discovery without the need to call connect
and to list all found devices on a display and continue work with that list.

I wasn't capable to test the example code with my file structure, but I did use the discovery already in some different situations.

However when I noted that the Bluedroid stack won't let me enforce an RfComm SPP connection to a GPS Device (Skytraxx 2 plus, I guess its interface is built so simple that it doesn't advertise its SPP over SDP), I will probably have to switch to BtStack (BlueKitchen) and stop on this side meanwhile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants