pinMatrixInDetach() has wrong parameter #5385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
|
This was referenced Jul 14, 2021
TD-er
added a commit
to TD-er/ESPEasySerial
that referenced
this pull request
Oct 13, 2021
ESP32 does have some issue where it is not properly detaching the RX/TX pins when calling `end()` This happens especially when the RX pin receives data when calling `end()`. Problem is that the serial port will no longer work after calling `end()` followed by `begin()` until it reboots. This very messy work-around is to cache the used pins and not calling `begin()` on the port if using the same pins for a specific port. Should be fixed with: espressif/arduino-esp32#5385 But that core version cannot yet be used due to other issues, like a bug with web authentication and issues with WiFi and ESP-NOW.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves issue #5112
Call to pinMatrixInDetach() was changed from version 1.0.6 in version 2.0.0 injecting a bug as seen in cores/esp32/esp32-hal-uart.c
80418fa