Skip to content

Introduce SSLClient library based on WiFiClientSecure and rework WiFiClientSecure to use it #6054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

sgalabov
Copy link

Summary

This PR reworks WiFiClientSecure into SSLClient so that it can be used with any Client-derived class.
Then it goes on to modify WiFiClientSecure to work with SSLClient in conjunction with a normal WiFiClient.
The PR was tested with ESP32 WiFi as well as with a GSM module supported by TinyGSM.

Impact

Any Client-derived class can get SSL applied to it, e.g. WiFiClient, but also TinyGsmClient and any other clients.
Protocol Clients can then be put on top of SSL, e.g. PubSubClient or ArduinoHttpClient.
This may also allow for DTLS to be supported as well in the same style in the future, e.g. CoAP over both WiFi and GSM, etc.

…rived class. Tested with ESP32 WiFiClient and TinyGsmClient.
@CLAassistant
Copy link

CLAassistant commented Dec 22, 2021

CLA assistant check
All committers have signed the CLA.

@me-no-dev
Copy link
Member

Amazing work! Please allow some time to review and test :)

@me-no-dev
Copy link
Member

You will need to edit CMakeLists.txt to fix the build error: https://github.com/espressif/arduino-esp32/runs/4608114525?check_suite_focus=true#step:4:41

@sgalabov
Copy link
Author

You will need to edit CMakeLists.txt to fix the build error: https://github.com/espressif/arduino-esp32/runs/4608114525?check_suite_focus=true#step:4:41

I think it's done now, sorry.

@sgalabov
Copy link
Author

I will close and reopen a new PR with just the inclusion of SSLClient lib for now, I will see if I can deal with the rest of the errors later...

@sgalabov sgalabov closed this Dec 22, 2021
@sgalabov
Copy link
Author

Opened #6055 instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants