ADC esp32s2 attenuation fix for DAC pins #6282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Working with S3 too? |
S3 does not support DAC. |
|
Ahh, yes! This https://github.com/espressif/arduino-esp32/blob/esp32-s3-support/cores/esp32/esp32-hal-adc.c#L38-L41 is probably a copy&paste thing |
|
The S3 has 20 ADC channels working, but no DAC channel ;) |
me-no-dev
reviewed
Feb 16, 2022
cores/esp32/esp32-hal-adc.c
Outdated
| @@ -142,9 +144,9 @@ bool __adcAttachPin(uint8_t pin){ | |||
| #endif | |||
| } | |||
| #if CONFIG_IDF_TARGET_ESP32 || CONFIG_IDF_TARGET_ESP32S2 | |||
There was a problem hiding this comment.
while here, let's use the SOC defines te test wether DAC is supported and maybe how many channels
There was a problem hiding this comment.
SOC define used now.
According to how many channels there are always 2 channels when supported.
There was a problem hiding this comment.
It's not given that this will be true in the future. Why not have more?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changed fixed DAC pins which are different for ESP32S2 to predefined DAC pins from SOC.
Impact
None.
Related links