log_printf may cause memory leak and unexpected behaviour #6360
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to retrieve length. If length is greater or equal than the available buffer, a memory leak will happen because va_end() is missing.
|
Thanks @BlueAndi :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Traversing a variable argument list twice may cause unexpected behaviour. Therefore the variable argument list 'arg' is copied to 'copy'. Unfortunately in line 484 'copy' is not used to retrieve the length, but 'arg'.
Additional if the retrieved length is greater or equal than the available buffer, the clean-up of the variable argument list 'arg' is missing.
Impact
This may cause unexpected and compiler dependend behaviour, because 'arg' is used in line some lines below again.
The missing clean-up of the variable argument list may lead to a memory leak, but depends on the compiler.