Skip to content

Fix linking failure for space in path in PlatformIO builder scripts #6464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 28, 2022
Merged

Fix linking failure for space in path in PlatformIO builder scripts #6464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a147e44
Hotfix linking failure for paths containing spaces
maxgerhardt Mar 22, 2022
ef9997a
Hotfix linking failure for paths containing spaces (esp32c3)
maxgerhardt Mar 22, 2022
06084b4
Hotfix linking failure for paths containing spaces (ESP32S2)
maxgerhardt Mar 22, 2022
77bfefd
Use alternative path and escaping method
maxgerhardt Mar 23, 2022
e57febe
Use alternative path and escaping method
maxgerhardt Mar 23, 2022
f585452
Use alternative path and escaping method
maxgerhardt Mar 23, 2022
68e84ea
Merge branch 'master' into patch-1
me-no-dev Mar 28, 2022
bad1c4e
Update platformio-build-esp32c3.py
me-no-dev Mar 28, 2022
c686b66
add esp32s3 changes
me-no-dev Mar 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tools/platformio-build-esp32.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@
"-u", "newlib_include_pthread_impl",
"-u", "newlib_include_assert_impl",
"-u", "__cxa_guard_dummy",
'-Wl,-Map="%s"' % join("$BUILD_DIR", basename(env.subst("${PROJECT_DIR}.map")))
'-Wl,-Map="%s"' % join("${BUILD_DIR}", "${PROGNAME}.map")
],

CPPPATH=[
Expand Down
2 changes: 1 addition & 1 deletion tools/platformio-build-esp32c3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@
"-u", "newlib_include_pthread_impl",
"-u", "newlib_include_assert_impl",
"-u", "__cxa_guard_dummy",
'-Wl,-Map="%s"' % join("$BUILD_DIR", basename(env.subst("${PROJECT_DIR}.map")))
'-Wl,-Map="%s"' % join("${BUILD_DIR}", "${PROGNAME}.map")
],

CPPPATH=[
Expand Down
2 changes: 1 addition & 1 deletion tools/platformio-build-esp32s2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@
"-u", "newlib_include_pthread_impl",
"-u", "newlib_include_assert_impl",
"-u", "__cxa_guard_dummy",
'-Wl,-Map="%s"' % join("$BUILD_DIR", basename(env.subst("${PROJECT_DIR}.map")))
'-Wl,-Map="%s"' % join("${BUILD_DIR}", "${PROGNAME}.map")
],

CPPPATH=[
Expand Down
2 changes: 1 addition & 1 deletion tools/platformio-build-esp32s3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@
"-u", "newlib_include_pthread_impl",
"-u", "newlib_include_assert_impl",
"-u", "__cxa_guard_dummy",
'-Wl,-Map="%s"' % join("$BUILD_DIR", basename(env.subst("${PROJECT_DIR}.map")))
'-Wl,-Map="%s"' % join("${BUILD_DIR}", "${PROGNAME}.map")
],

CPPPATH=[
Expand Down