fixes BLE HID Battery Level Indicator #6864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
me-no-dev
reviewed
Jun 14, 2022
libraries/BLE/src/BLEHIDDevice.cpp
Outdated
| @@ -42,7 +42,10 @@ BLEHIDDevice::BLEHIDDevice(BLEServer* server) { | |||
|
|
|||
| m_batteryLevelCharacteristic = m_batteryService->createCharacteristic((uint16_t) 0x2a19, BLECharacteristic::PROPERTY_READ | BLECharacteristic::PROPERTY_NOTIFY); | |||
| m_batteryLevelCharacteristic->addDescriptor(batteryLevelDescriptor); | |||
| m_batteryLevelCharacteristic->addDescriptor(new BLE2902()); | |||
| BLE2902 *batLevelIndicator = new BLE2902(); | |||
There was a problem hiding this comment.
indentation seems wrong here :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
BLE HID uses GATT Service to send Battery Level Indication.
It works fine on first time pairing and bonding, but on reconnect it doesn't update the Battery Level characteristic anymore.
It is fixed by setting the Notification to be ON, by default at the Service Creation.
Tests scenarios
Tested with ESP32 using Bluedroid and NimBLE.
Related links
Fixes #6708