Changed Neopixel related static constants to #defines #7080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To be consistent with other Adafruit ESP32 variants having Neopixels, changed the Neopixel related static constants to #defines.
|
|
|
look good, thanks for the PR to update adafruit defines |
|
@ChuckVanzant - please sign the CLA in order to move forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be consistent with other Adafruit ESP32 variants having Neopixels, changed the Neopixel related static constants to #defines in pins_arduino.h for the adafruit_qtpy_esp32 variant. This also resolves build issues where Neopixel related defines are used to include specific related code for the Qt Py ESP32 variant.