Skip to content

Fixes Cookie Case Sensitivity #7112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 16, 2022
Merged

Fixes Cookie Case Sensitivity #7112

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6c84b79
Fixes Cookie Case Sensitivity
SuGlider Aug 10, 2022
01ebe4b
Merge branch 'master' into SuGlider-patch-3
SuGlider Aug 11, 2022
b525869
Merge branch 'master' into SuGlider-patch-3
SuGlider Aug 11, 2022
562ff4d
Merge branch 'master' into SuGlider-patch-3
P-R-O-C-H-Y Aug 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions libraries/HTTPClient/src/HTTPClient.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1551,8 +1551,6 @@ void HTTPClient::setCookie(String date, String headerValue)
String value;
int pos1, pos2;

headerValue.toLowerCase();

struct tm tm;
strptime(date.c_str(), HTTP_TIME_PATTERN, &tm);
cookie.date = mktime(&tm);
Expand All @@ -1567,6 +1565,9 @@ void HTTPClient::setCookie(String date, String headerValue)
return; // invalid cookie header
}

// only Cookie Attributes are case insensitive from this point on
headerValue.toLowerCase();

// expires
if (headerValue.indexOf("expires=") >= 0){
pos1 = headerValue.indexOf("expires=") + strlen("expires=");
Expand Down