Skip to content

Add ICACHE_RAM_ATTR compatibility macro with esp8266 #760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add ICACHE_RAM_ATTR compatibility macro with esp8266 #760

wants to merge 1 commit into from

Conversation

copercini
Copy link
Contributor

This help the ESP8266 libraries to run on ESP32

This help the ESP8266 libraries to run on ESP32
@copercini
Copy link
Contributor Author

@me-no-dev
Copy link
Member

let's add a file called "esp8266-compat.h" and put that and ICACHE_FLASH_ATTR and maybe more in near future :) include that header into Arduino.h

@copercini
Copy link
Contributor Author

copercini commented Oct 22, 2017

Nice idea!

The strangest thing is that there are some ICACHE_FLASH_ATTR calls in the actual ESP32 core:
https://github.com/espressif/arduino-esp32/search?q=ICACHE_FLASH_ATTR

@me-no-dev
Copy link
Member

it evaluates to nothing and prolly not called anywhere to get the undefined error :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants