Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

withdrawals root in block header FMA: add link for completed action item #257

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

withdrawals root in block header FMA: add link for completed action item #257

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions security/fma-withdrawals-root-in-block-header.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,13 @@

<!-- END doctoc generated TOC please keep comment here to allow auto update -->

| | |
| ------------------ | ------------ |
| Author | George Knee |
| Created at | 2025-03-20 |
| Initial Reviewers | Mark Tyneway |
| Need Approval From | Tom Assas, Michael Amadi (Shadowing) |
| Status | Implementing Actions 🛫 |
| | |
| ------------------ | ------------------------------------ |
| Author | George Knee |
| Created at | 2025-03-20 |
| Initial Reviewers | Mark Tyneway |
| Need Approval From | Tom Assas, Michael Amadi (Shadowing) |
| Status | Implementing Actions 🛫 |

## Introduction

Expand Down Expand Up @@ -99,7 +99,7 @@ See the [generic FMA](./fma-generic-hardfork.md):
## Specific Action Items

- [x] (BLOCKING) e2e tests must check for consistency between output roots returned from op-node and those constructed manually in the old way https://github.com/ethereum-optimism/optimism/blob/6a436fe9ac9acb215b0f4b9f87ccd3832f4d6b72/op-e2e/actions/upgrades/isthmus_fork_test.go#L286-L301
- [ ] (non-BLOCKING) op-node could be furnished with an override to make it serve output roots in the legacy fashion; this would also aid in testing (see above item). It would even allow us to run the two systems side by side for a time before fully switching over.
- [x] (non-BLOCKING) op-node could be furnished with an override to make it serve output roots in the legacy fashion; this would also aid in testing (see above item). It would even allow us to run the two systems side by side for a time before fully switching over. https://github.com/ethereum-optimism/optimism/pull/15150
- [ ] (non-BLOCKING) op-geth could be made to log a critical error triggering an alert if ever the `withdrawals` list in the block body is non empty (post Isthmus)

## Generic Action Items
Expand All @@ -109,7 +109,6 @@ See the [generic FMA](./fma-generic-hardfork.md):
- [x] (BLOCKING) We should ensure that our usual suite of alerts applies to devnets and are routed to protocol engineers signing off on the devnet completion.
- [x] (BLOCKING): Run fuzzing on the v4 gossip p2p more than 10s (assignee: @Ethnical @geoknee) https://github.com/ethereum-optimism/optimism/pull/15068
- [x] (BLOCKING): We tested the activation on our [devnets](https://devnets.optimism.io/interop-rc-alpha.html).
- [ ] (non-BLOCKING): Making sure, that component that now fetch the withdrawalHash by this have also a fallback mechanism to previous Merkle Tree method in case there is a bug (assignee: @XXXXX for now).
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted this as it is a duplicate of the above.

- [ ] (non-BLOCKING): Creating a monitoring that differential testing from the merkle tree inclusion computation and the block.header request `withdrawalRoot` (assignee: @Ethnical). Tracking -> [Monitoring Security-Issue](https://github.com/ethereum-optimism/security-pod/issues/252)
- [ ] (non-BLOCKING): We have implemented fuzz testing in a kurtosis multi-client devnet to reduce the chance of bugs

Expand Down