Skip to content

fix: updated broken links in custom-bridge.mdx #1006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

intls
Copy link
Contributor

@intls intls commented Oct 19, 2024

Description

I have updated the custom-bridge.mdx file to fix an issue where the “Standard Bridge” link was styled as a hyperlink but had no valid destination. I replaced the broken link with the correct relative path to the standard-bridge.mdx file, ensuring users can now navigate properly within the documentation.

Tests

No additional tests were added, as this change affects documentation formatting. The updated link has been manually tested to confirm it correctly navigates to the standard-bridge.mdx file.

Additional context

The issue was identified during a review of internal documentation links. This change improves the usability and accuracy of the documentation by ensuring that links between relevant sections are functional.
Metadata

Fixes #1005

@intls intls requested a review from a team as a code owner October 19, 2024 07:50
Copy link

netlify bot commented Oct 19, 2024

Deploy Preview for docs-optimism ready!

Name Link
🔨 Latest commit 1c30fe6
🔍 Latest deploy log https://app.netlify.com/sites/docs-optimism/deploys/671364b9e8c88600083b950c
😎 Deploy Preview https://deploy-preview-1006--docs-optimism.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

coderabbitai bot commented Oct 19, 2024

Walkthrough

The changes in this pull request involve updating the links in the "Custom Bridges" documentation to correctly reference the "Standard Bridge" guide by including the .mdx file extension. This ensures that the hyperlinks point to the appropriate file format, enhancing navigation within the documentation. The overall content and structure of the document remain unchanged, focusing on the considerations for building custom token bridges.

Changes

File Path Change Summary
pages/builders/app-developers/bridging/custom-bridge.mdx Updated links to the "Standard Bridge" from ./standard-bridge to ./standard-bridge.mdx.

Possibly related issues

  • [DOCS] broken links in custom-bridge.mdx: This issue requests an update to the link in the custom-bridge.mdx file to ensure it points to the correct standard-bridge.mdx, which is addressed by the changes in this PR.

Possibly related PRs

  • superchain-bridges #695: This PR updates hyperlinks in the custom-bridge.mdx file, similar to the main PR's focus on updating links to the "Standard Bridge" guide.
  • fix broken links #814: This PR addresses broken links, which is related to the main PR's updates to ensure correct linking in documentation.
  • Two broken links #874: This PR also focuses on fixing broken links, aligning with the main PR's objective of ensuring accurate references in documentation.

Suggested reviewers

  • zainbacchus
  • cpengilly

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (2)
pages/builders/app-developers/bridging/custom-bridge.mdx (2)

11-11: Approve link update with a minor suggestion.

The update to include the .mdx file extension in the link to the Standard Bridge guide is correct and improves the documentation's accuracy. Well done!

For consistency, consider updating the link in the Callout section below (around line 18) to also include the .mdx extension.


Line range hint 1-54: Overall adherence to coding guidelines with a minor suggestion.

The document adheres well to the provided coding guidelines. It uses proper nouns appropriately, maintains gender-neutral language, and follows the correct capitalization rules for headers and proper nouns. The spelling and grammar are correct throughout.

To further improve consistency:

  1. Update the link in the Callout section (around line 18) to include the .mdx extension:

    -[Standard Bridge](./standard-bridge)
    +[Standard Bridge](./standard-bridge.mdx)
  2. Consider updating the links in the "Next Steps" section to use relative paths with .mdx extensions if they refer to local documentation files.

These changes will ensure uniform link formatting throughout the document.

🧰 Tools
🪛 LanguageTool

[style] ~13-~13: To make your writing concise, consider an alternative.
Context: ...ovides important information you should be aware of when building a custom bridge. <Callou...

(AWARE_OF)

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between e576fdd and 1c30fe6.

📒 Files selected for processing (1)
  • pages/builders/app-developers/bridging/custom-bridge.mdx (2 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
pages/builders/app-developers/bridging/custom-bridge.mdx (1)

Pattern **/*.mdx: "ALWAYS review Markdown content THOROUGHLY with the following criteria:

  • Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
  • Avoid gender-specific language and use the imperative form.
  • Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
  • Ensure proper nouns are capitalized in sentences.
  • Apply the Oxford comma.
  • Use proper title case for headers, buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
  • Use correct spelling and grammar at all times (IMPORTANT).
  • Use sentence case for H1, H2, and H3 headers, capitalizing only the first word and any proper nouns.
  • For all headers (H1, H2, H3), do not change the capitalization of proper nouns; keep them as they are.
    "
🔇 Additional comments (1)
pages/builders/app-developers/bridging/custom-bridge.mdx (1)

30-30: Approve link update.

The update to include the .mdx file extension in the link to the "Using the Standard Bridge" guide is correct and improves the documentation's accuracy. Good job on maintaining consistency with the previous link update!

@krofax krofax closed this Oct 21, 2024
@krofax krofax reopened this Oct 21, 2024
Copy link
Collaborator

@krofax krofax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works well, i'm not sure we need to add .mdx to the files

@krofax
Copy link
Collaborator

krofax commented Oct 21, 2024

Closing this PR

@krofax krofax closed this Oct 21, 2024
@intls intls deleted the Broken-links branch October 22, 2024 03:08
@intls
Copy link
Contributor Author

intls commented Oct 22, 2024

Closing this PR

Hi @krofax This 2 links really does not work! It shows 404 - page not found

Снимок экрана 2024-10-22 в 10 20 43
Снимок экрана 2024-10-22 в 10 20 53
Снимок экрана 2024-10-22 в 10 21 40
Снимок экрана 2024-10-22 в 10 21 54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOCS] broken links in custom-bridge.mdx
2 participants