Skip to content

removing fp and granite notices #1040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2024
Merged

removing fp and granite notices #1040

merged 1 commit into from
Oct 28, 2024

Conversation

sbvegan
Copy link
Collaborator

@sbvegan sbvegan commented Oct 28, 2024

Description

  • remove the old notice pages
  • add redirects to the permalink github pages of the notices
  • update the overview page

Metadata

@sbvegan sbvegan requested a review from a team as a code owner October 28, 2024 22:01
Copy link

netlify bot commented Oct 28, 2024

Deploy Preview for docs-optimism ready!

Name Link
🔨 Latest commit f42998c
🔍 Latest deploy log https://app.netlify.com/sites/docs-optimism/deploys/672009c751396d000a5e6fa8
😎 Deploy Preview https://deploy-preview-1040--docs-optimism.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

coderabbitai bot commented Oct 28, 2024

Walkthrough

The pull request includes several changes across multiple files, primarily focusing on updating documentation related to the OP Stack. Key modifications include the deletion of specific notices about Fault Proofs and Granite changes, updates to redirect paths for improved resource accessibility, and a revision of a TypeScript configuration reference in the next-env.d.ts file. The changes aim to streamline the documentation and ensure that users receive accurate and relevant information.

Changes

File Change Summary
next-env.d.ts Updated URL reference for TypeScript configuration documentation.
pages/builders/notices.mdx Revised main body text for conciseness; removed <Card> components related to fault proofs and granite changes.
pages/builders/notices/_meta.json Removed key-value pairs for "granite-changes" and "fp-changes".
pages/builders/notices/fp-changes.mdx Deleted file providing details on Fault Proofs upgrade.
pages/builders/notices/granite-changes.mdx Deleted file detailing guidance for Granite network upgrade.
public/_redirects Updated multiple redirect paths and added new entries for notices about granite and fault proofs.

Assessment against linked issues

Objective Addressed Explanation
Delete fp-changes.mdx and redirect to a GitHub permalink (#1038)
Delete granite-changes.mdx and redirect to a GitHub permalink (#1039)

Possibly related issues

  • Issue Update Fault Proofs Notice Page #687: The changes in this PR regarding the deletion of the fp-changes.mdx file and the update of related redirects could address the need for an updated Fault Proofs notice page.

Possibly related PRs

Suggested labels

flag:merge-pending-release

Suggested reviewers

  • cpengilly
  • bradleycamacho

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Outside diff range and nitpick comments (2)
pages/builders/notices.mdx (2)

Line range hint 1-5: Update the description to reflect current content.

The description still references "fault proofs breaking changes" and "granite breaking changes" which have been removed from the content. This creates inconsistency between the description and actual content.

Apply this diff to align the description with the current content:

---
title: Notices
-description: This section provides information on preparing for fault proofs breaking changes, preparing for granite breaking changes and deprecation of the...
+description: This section provides essential information about the latest changes in the OP Stack, including SDK deprecation notices.
lang: en-US
---

13-15: Consider adding a brief description to the Card component.

While the Card component is functional, adding a brief description would improve user understanding of what to expect when clicking through.

Consider updating the Card component like this:

<Cards>
-  <Card title="Deprecation of the optimism sdk" href="/builders/notices/sdk-deprecation" />
+  <Card 
+    title="Deprecation of the optimism sdk"
+    href="/builders/notices/sdk-deprecation"
+    children="Learn about the deprecation timeline and migration steps for the Optimism SDK."
+  />
</Cards>
📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 5fdf0c2 and f42998c.

📒 Files selected for processing (6)
  • next-env.d.ts (1 hunks)
  • pages/builders/notices.mdx (1 hunks)
  • pages/builders/notices/_meta.json (0 hunks)
  • pages/builders/notices/fp-changes.mdx (0 hunks)
  • pages/builders/notices/granite-changes.mdx (0 hunks)
  • public/_redirects (1 hunks)
💤 Files with no reviewable changes (3)
  • pages/builders/notices/_meta.json
  • pages/builders/notices/fp-changes.mdx
  • pages/builders/notices/granite-changes.mdx
✅ Files skipped from review due to trivial changes (1)
  • next-env.d.ts
🧰 Additional context used
📓 Path-based instructions (1)
pages/builders/notices.mdx (1)

Pattern **/*.mdx: "ALWAYS review Markdown content THOROUGHLY with the following criteria:

  • Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
  • Avoid gender-specific language and use the imperative form.
  • Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
  • Ensure proper nouns are capitalized in sentences.
  • Apply the Oxford comma.
  • Use proper title case for headers, buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
  • Use correct spelling and grammar at all times (IMPORTANT).
  • Use sentence case for H1, H2, and H3 headers, capitalizing only the first word and any proper nouns.
  • For all headers (H1, H2, H3), do not change the capitalization of proper nouns; keep them as they are.
    "
🔇 Additional comments (2)
pages/builders/notices.mdx (1)

11-11: LGTM! Clear and concise overview.

The new content effectively communicates the purpose of the section while maintaining a professional tone. It follows the coding guidelines by:

  • Using proper sentence case
  • Avoiding personal pronouns
  • Being concise and clear
public/_redirects (1)

103-104: LGTM! Consistent path reorganization for operator tools.

The redirects properly reorganize operator-specific tools under the /builders/chain-operators/tools/ path, maintaining consistency with other builder-focused documentation.

@sbvegan sbvegan merged commit 5adb056 into main Oct 28, 2024
7 of 8 checks passed
@sbvegan sbvegan deleted the sb-remove-old-notices branch October 28, 2024 22:15
This was referenced Nov 7, 2024
@coderabbitai coderabbitai bot mentioned this pull request Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[2024 Q4 Audit] builders/notices/granite-changes.mdx [2024 Q4 Audit] builders/notices/fp-changes.mdx
2 participants