Skip to content

Move USDC Section to OP Mainnet-Specific #1160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 5, 2024
Merged

Move USDC Section to OP Mainnet-Specific #1160

merged 3 commits into from
Dec 5, 2024

Conversation

krofax
Copy link
Collaborator

@krofax krofax commented Dec 4, 2024

Description

This PR reorganizes the standard bridge section to improve clarity around USDC usage on OP Mainnet. The existing section on USDC in the Standard Bridge documentation has been moved to a dedicated "USDC on OP Mainnet" subsection to reduce confusion for chain operators.

Tests

Additional context

Metadata

@krofax krofax requested a review from a team as a code owner December 4, 2024 16:25
Copy link

netlify bot commented Dec 4, 2024

Deploy Preview for docs-optimism ready!

Name Link
🔨 Latest commit 51c55e0
🔍 Latest deploy log https://app.netlify.com/sites/docs-optimism/deploys/67508f4d3a831200085b91e4
😎 Deploy Preview https://deploy-preview-1160--docs-optimism.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

coderabbitai bot commented Dec 4, 2024

Warning

Rate limit exceeded

@krofax has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 5 minutes and 45 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between aca8b18 and 51c55e0.

📝 Walkthrough
📝 Walkthrough
📝 Walkthrough

Walkthrough

The pull request introduces significant modifications to the documentation regarding the Standard Bridge, particularly focusing on the handling of USDC tokens. It emphasizes the deprecation of the legacy bridged version (USDC.e) on OP Mainnet, urging users to transition to the native USDC token issued by Circle. The previous description of the bridging process for USDC has been replaced with a warning callout to highlight the importance of using the native version.

Additionally, the document's structure has been refined, incorporating callouts that inform users about the limitations of the Standard Bridge, especially regarding fee-on-transfer and rebasing tokens. While the overall flow remains consistent, the updates streamline the information relevant to USDC, ensuring users are aware of current best practices. The bridging mechanisms for both native and non-native tokens continue to be detailed, and minor formatting adjustments along with added links for further reading have been included to enhance user experience.

Possibly related PRs

  • Bridged USDC Standard for the OP Stack #836: This PR introduces a comprehensive guide on the Bridged USDC Standard, detailing the transition from Bridged USDC to Native USDC, which aligns with the main PR's emphasis on the deprecation of the legacy bridged version of USDC.
  • Update bridged-usdc-standard.mdx #841: This PR makes minor textual modifications in the bridged-usdc-standard.mdx, enhancing clarity about the types of USDC, which relates directly to the main PR's focus on the USDC transition.
  • Update bridged-usdc-standard.mdx #847: This PR updates terminology in the bridged-usdc-standard.mdx, ensuring consistency in references to Native and Bridged USDC, which is relevant to the main PR's updates on USDC documentation.
  • Add linked to SuperchainERC20 #1010: This PR adds a link to the SuperchainERC20 documentation, which is relevant as it relates to the interoperability and bridging aspects of USDC discussed in the main PR.
  • Clean up explainer #1107: This PR enhances the interoperability explainer, including details about the SuperchainERC20, which ties into the main PR's focus on the bridging process and standards for USDC.
  • Provide an interop value-prop in more plain terms #1112: This PR clarifies the interoperability features, including the transfer of tokens, which is relevant to the main PR's updates on bridging processes for USDC.

Suggested labels

documentation

Suggested reviewers

  • zainbacchus
  • cpengilly

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
pages/builders/app-developers/bridging/standard-bridge.mdx (1)

244-247: Consider enhancing the warning message with migration guidance

While the warning effectively communicates the deprecation of USDC.e, it could be more helpful to include:

  1. A timeline for the deprecation (if available)
  2. Steps or a link to documentation about how to migrate from USDC.e to native USDC

The current implementation:

<Callout type="warning">
The legacy bridged version of USDC (USDC.e) at address `0x7f5c764cbc14f9669b88837ca1490cca17c31607` is being deprecated on OP Mainnet. 
Users and developers should migrate to using the native USDC token issued directly by [Circle](https://www.circle.com/en/), the issuer of [USDC](https://www.circle.com/en/usdc?gad_source=1).
</Callout>

Suggested enhancement:

<Callout type="warning">
The legacy bridged version of USDC (USDC.e) at address `0x7f5c764cbc14f9669b88837ca1490cca17c31607` is being deprecated on OP Mainnet. 
Users and developers should migrate to using the native USDC token issued directly by [Circle](https://www.circle.com/en/), the issuer of [USDC](https://www.circle.com/en/usdc?gad_source=1).
+ For guidance on migrating from USDC.e to native USDC, please refer to our [migration guide](/path-to-migration-guide).
</Callout>
📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 9c7e43c and 94d28a7.

📒 Files selected for processing (1)
  • pages/builders/app-developers/bridging/standard-bridge.mdx (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
pages/builders/app-developers/bridging/standard-bridge.mdx (1)

Pattern **/*.mdx: "ALWAYS review Markdown content THOROUGHLY with the following criteria:

  • Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
  • Avoid gender-specific language and use the imperative form.
  • Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
  • Ensure proper nouns are capitalized in sentences.
  • Apply the Oxford comma.
  • Use proper title case for buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
  • Use correct spelling and grammar at all times (IMPORTANT).
  • For H1, H2, and H3 headers:
    1. Use sentence case, capitalizing only the first word.
    2. Preserve the capitalization of proper nouns, technical terms, and acronyms as defined in the 'nouns.txt' file located in the root directory of the project.
    3. Do not automatically lowercase words that appear in the 'nouns.txt' file, regardless of their position in the header.
  • Flag any headers that seem to inconsistently apply these rules for manual review.
  • When reviewing capitalization, always refer to the 'nouns.txt' file for the correct capitalization of proper nouns and technical terms specific to the project.
    "
🔇 Additional comments (1)
pages/builders/app-developers/bridging/standard-bridge.mdx (1)

242-242: LGTM!

The section header follows the correct sentence case format while properly capitalizing the proper nouns (USDC, OP Mainnet).

Copy link
Contributor

@zainbacchus zainbacchus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thank you!

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
pages/chain/tokenlist.mdx (1)

23-26: Enhance warning message clarity

Consider these minor refinements to improve clarity and maintain consistency:

-The legacy bridged version of USDC (USDC.e) at address `0x7f5c764cbc14f9669b88837ca1490cca17c31607` is being deprecated on OP Mainnet. 
-Users and developers should migrate to using the native USDC token issued directly by [Circle](https://www.circle.com/en/), the issuer of [USDC](https://www.circle.com/en/usdc?gad_source=1).
+The legacy bridged version of USDC (USDC.e) at address `0x7f5c764cbc14f9669b88837ca1490cca17c31607` is being deprecated on OP Mainnet.
+Users and developers should migrate to the native USDC token issued directly by [Circle](https://www.circle.com/en/), the official issuer of [USDC](https://www.circle.com/en/usdc?gad_source=1).
📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 94d28a7 and aca8b18.

📒 Files selected for processing (2)
  • pages/builders/app-developers/bridging/standard-bridge.mdx (1 hunks)
  • pages/chain/tokenlist.mdx (1 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
pages/chain/tokenlist.mdx (1)

Pattern **/*.mdx: "ALWAYS review Markdown content THOROUGHLY with the following criteria:

  • Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
  • Avoid gender-specific language and use the imperative form.
  • Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
  • Ensure proper nouns are capitalized in sentences.
  • Apply the Oxford comma.
  • Use proper title case for buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
  • Use correct spelling and grammar at all times (IMPORTANT).
  • For H1, H2, and H3 headers:
    1. Use sentence case, capitalizing only the first word.
    2. Preserve the capitalization of proper nouns, technical terms, and acronyms as defined in the 'nouns.txt' file located in the root directory of the project.
    3. Do not automatically lowercase words that appear in the 'nouns.txt' file, regardless of their position in the header.
  • Flag any headers that seem to inconsistently apply these rules for manual review.
  • When reviewing capitalization, always refer to the 'nouns.txt' file for the correct capitalization of proper nouns and technical terms specific to the project.
    "
pages/builders/app-developers/bridging/standard-bridge.mdx (1)

Pattern **/*.mdx: "ALWAYS review Markdown content THOROUGHLY with the following criteria:

  • Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
  • Avoid gender-specific language and use the imperative form.
  • Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
  • Ensure proper nouns are capitalized in sentences.
  • Apply the Oxford comma.
  • Use proper title case for buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
  • Use correct spelling and grammar at all times (IMPORTANT).
  • For H1, H2, and H3 headers:
    1. Use sentence case, capitalizing only the first word.
    2. Preserve the capitalization of proper nouns, technical terms, and acronyms as defined in the 'nouns.txt' file located in the root directory of the project.
    3. Do not automatically lowercase words that appear in the 'nouns.txt' file, regardless of their position in the header.
  • Flag any headers that seem to inconsistently apply these rules for manual review.
  • When reviewing capitalization, always refer to the 'nouns.txt' file for the correct capitalization of proper nouns and technical terms specific to the project.
    "
🔇 Additional comments (3)
pages/chain/tokenlist.mdx (2)

21-22: LGTM! Clear and well-structured section header

The header follows the correct sentence case guidelines while preserving the capitalization of proper nouns (USDC, OP Mainnet).


30-33: LGTM! Well-structured token information table

The table provides clear descriptions and properly formatted Etherscan links for both token versions.

pages/builders/app-developers/bridging/standard-bridge.mdx (1)

238-238: LGTM! Proper component closure

The added closing tag properly terminates the Steps component.

@krofax krofax merged commit 84ec35a into main Dec 5, 2024
8 of 9 checks passed
@krofax krofax deleted the callout-usdc branch December 5, 2024 01:13
@coderabbitai coderabbitai bot mentioned this pull request Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants