Skip to content

Fix identity redirect links #1254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Fix identity redirect links #1254

merged 1 commit into from
Jan 16, 2025

Conversation

krofax
Copy link
Collaborator

@krofax krofax commented Jan 16, 2025

Description

Fixed redirects that didn't work in #1237

Tests

Additional context

Metadata

@krofax krofax requested a review from a team as a code owner January 16, 2025 19:20
Copy link

netlify bot commented Jan 16, 2025

Deploy Preview for docs-optimism ready!

Name Link
🔨 Latest commit 46689dd
🔍 Latest deploy log https://app.netlify.com/sites/docs-optimism/deploys/67895c1cdc14eb00082bf406
😎 Deploy Preview https://deploy-preview-1254--docs-optimism.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

coderabbitai bot commented Jan 16, 2025

📝 Walkthrough

Walkthrough

The pull request introduces a comprehensive update to the public/_redirects file, focusing on restructuring and enhancing the routing for identity-related resources. The changes primarily involve adding new redirect paths under the /chain/identity/ section, which now point to various resources on the Optimism community website. These redirects cover a wide range of identity-related topics, including contracts, applications, schemas, individuals, organizations, and an overview of the identity ecosystem. The modifications aim to improve navigation and provide direct access to specific identity-related documentation and resources.

Sequence Diagram

sequenceDiagram
    participant User
    participant Redirects
    participant Community Site
    
    User->>Redirects: Request `/chain/identity/contracts-eas`
    Redirects->>Community Site: Redirect to `https://community.optimism.io/identity/contracts-eas`
    Community Site-->>User: Serve identity contracts page
Loading

Possibly related PRs

Suggested reviewers

  • cpengilly
  • sbvegan

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cacf142 and 46689dd.

📒 Files selected for processing (1)
  • public/_redirects (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (4)
  • GitHub Check: Redirect rules - docs-optimism
  • GitHub Check: Header rules - docs-optimism
  • GitHub Check: Pages changed - docs-optimism
  • GitHub Check: pr-workflow
🔇 Additional comments (1)
public/_redirects (1)

124-131: Verify that all target URLs exist and are accessible

All redirects point to the identity section of community.optimism.io. Let's verify that these URLs are valid and accessible.

✅ Verification successful

All redirect target URLs are valid and accessible

All 8 URLs in the identity section of community.optimism.io return successful responses (HTTP 200), confirming that the redirects are pointing to valid destinations.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check if the target URLs exist and return valid responses

echo "Checking target URLs..."
urls=(
  "https://community.optimism.io/identity/about-attestations"
  "https://community.optimism.io/identity/applications"
  "https://community.optimism.io/identity/contracts-eas"
  "https://community.optimism.io/identity/individuals"
  "https://community.optimism.io/identity/organizations"
  "https://community.optimism.io/identity/overview"
  "https://community.optimism.io/identity/projects"
  "https://community.optimism.io/identity/schemas"
)

for url in "${urls[@]}"; do
  response=$(curl -sL -w "%{http_code}" "$url" -o /dev/null)
  echo "URL: $url - Status: $response"
done

Length of output: 2769

@krofax krofax merged commit 91d44af into main Jan 16, 2025
4 of 8 checks passed
@krofax krofax deleted the fix-redirects branch January 16, 2025 19:26
This was referenced Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants