Skip to content

fix(cleanup): replace dangling plasma refs with altda #1258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 17, 2025

Conversation

bitwiseguy
Copy link
Contributor

The plasma feature was renamed to altda several months ago. This pr cleans up some of the old references to plasma scattered throughout the docs and replaces them with the new altda name

@bitwiseguy bitwiseguy requested a review from a team as a code owner January 17, 2025 02:08
Copy link

netlify bot commented Jan 17, 2025

Deploy Preview for docs-optimism ready!

Name Link
🔨 Latest commit 1f06a6f
🔍 Latest deploy log https://app.netlify.com/sites/docs-optimism/deploys/678a6f53c435e60008294998
😎 Deploy Preview https://deploy-preview-1258--docs-optimism.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

coderabbitai bot commented Jan 17, 2025

📝 Walkthrough

Walkthrough

The pull request introduces a comprehensive documentation update across multiple files, focusing on renaming terminology from "Plasma" to "Alt-DA" (Alternative Data Availability). This change affects configuration documentation, glossary entries, and explanatory pages related to the OP Stack. The modifications include updating command-line arguments, environment variables, configuration options, and descriptive text to reflect the new terminology. The changes are consistent across different documentation pages, ensuring a unified approach to describing the data availability mechanism and its configuration.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Docs
    participant Configuration
    participant AltDASystem

    User->>Docs: Reads documentation
    Docs->>Configuration: Provides updated config instructions
    User->>Configuration: Applies new configuration
    Configuration->>AltDASystem: Configures with Alt-DA parameters
    AltDASystem-->>Configuration: Confirms configuration
Loading

Possibly related issues

Possibly related PRs

Suggested labels

flag:merge-pending-release

Suggested reviewers

  • sbvegan
  • krofax

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8870649 and 1f06a6f.

📒 Files selected for processing (1)
  • words.txt (2 hunks)
🧰 Additional context used
🪛 LanguageTool
words.txt

[duplication] ~284-~284: Möglicher Tippfehler: ein Wort wird wiederholt
Context: ... Prestate prestate prestates PREVRANDAO PRICEBUMP pricebump PRICELIMIT pricelimit productionize pro...

(GERMAN_WORD_REPEAT_RULE)

⏰ Context from checks skipped due to timeout of 90000ms (4)
  • GitHub Check: Redirect rules - docs-optimism
  • GitHub Check: Header rules - docs-optimism
  • GitHub Check: Pages changed - docs-optimism
  • GitHub Check: pr-workflow
🔇 Additional comments (2)
words.txt (2)

12-12: LGTM! Term added correctly.

The addition of "altda" is properly alphabetized and follows the file's lowercase convention for feature names.


284-284: LGTM! Correct protocol term.

The update from "PREVRENDAO" to "PREVRANDAO" fixes a typo in the protocol term name, maintaining consistent uppercase formatting for protocol-level terms.

🧰 Tools
🪛 LanguageTool

[duplication] ~284-~284: Möglicher Tippfehler: ein Wort wird wiederholt
Context: ... Prestate prestate prestates PREVRANDAO PRICEBUMP pricebump PRICELIMIT pricelimit productionize pro...

(GERMAN_WORD_REPEAT_RULE)


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
pages/superchain/superchain-explainer.mdx (1)

267-267: Fix grammar in the Alt-DA protocol introduction.

Use "an" instead of "a" before "Alt-DA protocol" as words starting with vowel sounds require "an".

-Today L1 data availability (DA) does not scale nearly enough to be able to support internet-level scale. However, it is possible to extend the amount of data availability accessible to OP Chains by using a Alt-DA protocol which enables alternative DA providers to supplement the more limited L1 DA.
+Today L1 data availability (DA) does not scale nearly enough to be able to support internet-level scale. However, it is possible to extend the amount of data availability accessible to OP Chains by using an Alt-DA protocol which enables alternative DA providers to supplement the more limited L1 DA.

Also applies to: 275-275

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1a47cf8 and 3e14102.

📒 Files selected for processing (6)
  • pages/builders/chain-operators/configuration/batcher.mdx (1 hunks)
  • pages/builders/chain-operators/configuration/rollup.mdx (4 hunks)
  • pages/connect/resources/glossary.mdx (1 hunks)
  • pages/stack/beta-features/alt-da-mode.mdx (1 hunks)
  • pages/stack/beta-features/custom-gas-token.mdx (1 hunks)
  • pages/superchain/superchain-explainer.mdx (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • pages/stack/beta-features/custom-gas-token.mdx
🧰 Additional context used
📓 Path-based instructions (5)
pages/stack/beta-features/alt-da-mode.mdx (1)

Pattern **/*.mdx: "ALWAYS review Markdown content THOROUGHLY with the following criteria:

  • Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
  • Avoid gender-specific language and use the imperative form.
  • Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
  • Ensure proper nouns are capitalized in sentences.
  • Apply the Oxford comma.
  • Use proper title case for buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
  • Use correct spelling and grammar at all times (IMPORTANT).
  • For H1, H2, and H3 headers:
    1. Use sentence case, capitalizing only the first word.
    2. Preserve the capitalization of proper nouns, technical terms, and acronyms as defined in the 'nouns.txt' file located in the root directory of the project.
    3. Do not automatically lowercase words that appear in the 'nouns.txt' file, regardless of their position in the header.
  • Flag any headers that seem to inconsistently apply these rules for manual review.
  • When reviewing capitalization, always refer to the 'nouns.txt' file for the correct capitalization of proper nouns and technical terms specific to the project.
    "
pages/connect/resources/glossary.mdx (1)

Pattern **/*.mdx: "ALWAYS review Markdown content THOROUGHLY with the following criteria:

  • Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
  • Avoid gender-specific language and use the imperative form.
  • Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
  • Ensure proper nouns are capitalized in sentences.
  • Apply the Oxford comma.
  • Use proper title case for buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
  • Use correct spelling and grammar at all times (IMPORTANT).
  • For H1, H2, and H3 headers:
    1. Use sentence case, capitalizing only the first word.
    2. Preserve the capitalization of proper nouns, technical terms, and acronyms as defined in the 'nouns.txt' file located in the root directory of the project.
    3. Do not automatically lowercase words that appear in the 'nouns.txt' file, regardless of their position in the header.
  • Flag any headers that seem to inconsistently apply these rules for manual review.
  • When reviewing capitalization, always refer to the 'nouns.txt' file for the correct capitalization of proper nouns and technical terms specific to the project.
    "
pages/builders/chain-operators/configuration/batcher.mdx (1)

Pattern **/*.mdx: "ALWAYS review Markdown content THOROUGHLY with the following criteria:

  • Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
  • Avoid gender-specific language and use the imperative form.
  • Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
  • Ensure proper nouns are capitalized in sentences.
  • Apply the Oxford comma.
  • Use proper title case for buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
  • Use correct spelling and grammar at all times (IMPORTANT).
  • For H1, H2, and H3 headers:
    1. Use sentence case, capitalizing only the first word.
    2. Preserve the capitalization of proper nouns, technical terms, and acronyms as defined in the 'nouns.txt' file located in the root directory of the project.
    3. Do not automatically lowercase words that appear in the 'nouns.txt' file, regardless of their position in the header.
  • Flag any headers that seem to inconsistently apply these rules for manual review.
  • When reviewing capitalization, always refer to the 'nouns.txt' file for the correct capitalization of proper nouns and technical terms specific to the project.
    "
pages/builders/chain-operators/configuration/rollup.mdx (1)

Pattern **/*.mdx: "ALWAYS review Markdown content THOROUGHLY with the following criteria:

  • Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
  • Avoid gender-specific language and use the imperative form.
  • Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
  • Ensure proper nouns are capitalized in sentences.
  • Apply the Oxford comma.
  • Use proper title case for buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
  • Use correct spelling and grammar at all times (IMPORTANT).
  • For H1, H2, and H3 headers:
    1. Use sentence case, capitalizing only the first word.
    2. Preserve the capitalization of proper nouns, technical terms, and acronyms as defined in the 'nouns.txt' file located in the root directory of the project.
    3. Do not automatically lowercase words that appear in the 'nouns.txt' file, regardless of their position in the header.
  • Flag any headers that seem to inconsistently apply these rules for manual review.
  • When reviewing capitalization, always refer to the 'nouns.txt' file for the correct capitalization of proper nouns and technical terms specific to the project.
    "
pages/superchain/superchain-explainer.mdx (1)

Pattern **/*.mdx: "ALWAYS review Markdown content THOROUGHLY with the following criteria:

  • Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
  • Avoid gender-specific language and use the imperative form.
  • Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
  • Ensure proper nouns are capitalized in sentences.
  • Apply the Oxford comma.
  • Use proper title case for buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
  • Use correct spelling and grammar at all times (IMPORTANT).
  • For H1, H2, and H3 headers:
    1. Use sentence case, capitalizing only the first word.
    2. Preserve the capitalization of proper nouns, technical terms, and acronyms as defined in the 'nouns.txt' file located in the root directory of the project.
    3. Do not automatically lowercase words that appear in the 'nouns.txt' file, regardless of their position in the header.
  • Flag any headers that seem to inconsistently apply these rules for manual review.
  • When reviewing capitalization, always refer to the 'nouns.txt' file for the correct capitalization of proper nouns and technical terms specific to the project.
    "
🪛 LanguageTool
pages/builders/chain-operators/configuration/batcher.mdx

[style] ~271-~271: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ... <Tabs.Tab>--altda.da-server=</Tabs.Tab> <Tabs.Tab>`OP_BATCHER_ALTDA_DA_SERVE...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~282-~282: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...bs.Tab>--altda.da-service=false</Tabs.Tab> <Tabs.Tab>`OP_BATCHER_ALTDA_DA_SERVI...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~292-~292: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...<Tabs.Tab>--altda.enabled=false</Tabs.Tab> <Tabs.Tab>`OP_BATCHER_ALTDA_ENABLED=...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~303-~303: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...Tab>--altda.verify-on-read=true</Tabs.Tab> <Tabs.Tab>`OP_BATCHER_ALTDA_VERIFY_O...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)

pages/superchain/superchain-explainer.mdx

[misspelling] ~275-~275: Use “an” instead of ‘a’ if the following word starts with a vowel sound, e.g. ‘an article’, ‘an hour’.
Context: ...bility accessible to OP Chains by using a Alt-DA protocol which enables alternati...

(EN_A_VS_AN)


[style] ~283-~283: As a shorter alternative for ‘able to’, consider using “can”.
Context: .... A generic Alt-DA protocol is able to scale beyond what is possible on L1 bec...

(BE_ABLE_TO)


[style] ~283-~283: Consider removing “of” to be more concise
Context: ...eas on L1 every Ethereum node downloads all of the transaction data on L1. This means that...

(ALL_OF_THE)


[style] ~292-~292: Consider a shorter alternative to avoid wordiness.
Context: ...ction to withdraw from the Alt-DA chain in order to switch their DA Provider. * Settlemen...

(IN_ORDER_TO_PREMIUM)

🔇 Additional comments (9)
pages/stack/beta-features/alt-da-mode.mdx (1)

34-34: LGTM! Terminology update is accurate.

The change from "Plasma Data Availability Challenges" to "Alt-DA Challenges" aligns with the broader initiative to update terminology across the documentation.

pages/builders/chain-operators/configuration/batcher.mdx (4)

265-272: LGTM! Configuration option renamed correctly.

The altda.da-server configuration and its related environment variables are properly renamed from the previous "plasma" prefix.

🧰 Tools
🪛 LanguageTool

[style] ~271-~271: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ... <Tabs.Tab>--altda.da-server=</Tabs.Tab> <Tabs.Tab>`OP_BATCHER_ALTDA_DA_SERVE...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


275-283: LGTM! Service configuration updated consistently.

The altda.da-service configuration maintains its functionality while adopting the new terminology.

🧰 Tools
🪛 LanguageTool

[style] ~282-~282: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...bs.Tab>--altda.da-service=false</Tabs.Tab> <Tabs.Tab>`OP_BATCHER_ALTDA_DA_SERVI...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


286-293: LGTM! Enable flag renamed appropriately.

The altda.enabled configuration preserves its boolean nature and default value while updating to the new naming scheme.

🧰 Tools
🪛 LanguageTool

[style] ~292-~292: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...<Tabs.Tab>--altda.enabled=false</Tabs.Tab> <Tabs.Tab>`OP_BATCHER_ALTDA_ENABLED=...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


296-304: LGTM! Verification option updated correctly.

The altda.verify-on-read configuration maintains its verification functionality while adopting the new terminology.

🧰 Tools
🪛 LanguageTool

[style] ~303-~303: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...Tab>--altda.verify-on-read=true</Tabs.Tab> <Tabs.Tab>`OP_BATCHER_ALTDA_VERIFY_O...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)

pages/connect/resources/glossary.mdx (1)

252-252: LGTM! Glossary term updated accurately.

The "Alt-DA Chain" definition maintains technical accuracy while aligning with the new terminology.

pages/builders/chain-operators/configuration/rollup.mdx (2)

Line range hint 1010-1016: LGTM! Configuration flag renamed appropriately.

The useAltDA flag replaces usePlasma while maintaining its functionality as a boolean indicator.


1043-1043: LGTM! Configuration notes updated consistently.

The notes for daChallengeWindow, daResolveWindow, and daChallengeProxy have been updated to reference "altda mode" while maintaining their technical requirements.

Also applies to: 1056-1056, 1095-1095

pages/superchain/superchain-explainer.mdx (1)

278-280: LGTM! Protocol description updated accurately.

The Alt-DA protocol description maintains technical accuracy while adopting the new terminology. The explanation of data availability challenges and security model remains clear and precise.

Also applies to: 283-295

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
words.txt (1)

293-293: Consider standardizing case conventions.

While the addition of "PREVRANDAO" is valid, the casing seems inconsistent with other similar technical terms in the list. Consider establishing clear guidelines for term casing.

🧰 Tools
🪛 LanguageTool

[duplication] ~293-~293: Möglicher Tippfehler: ein Wort wird wiederholt
Context: ... Prestate prestate prestates PREVRANDAO PRICEBUMP pricebump PRICELIMIT pricelimit productionize pro...

(GERMAN_WORD_REPEAT_RULE)

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3e14102 and 8870649.

📒 Files selected for processing (4)
  • pages/stack/differences.mdx (1 hunks)
  • pages/stack/interop/op-supervisor.mdx (1 hunks)
  • pages/stack/interop/security.mdx (1 hunks)
  • words.txt (2 hunks)
✅ Files skipped from review due to trivial changes (3)
  • pages/stack/differences.mdx
  • pages/stack/interop/op-supervisor.mdx
  • pages/stack/interop/security.mdx
🧰 Additional context used
🪛 LanguageTool
words.txt

[duplication] ~293-~293: Möglicher Tippfehler: ein Wort wird wiederholt
Context: ... Prestate prestate prestates PREVRANDAO PRICEBUMP pricebump PRICELIMIT pricelimit productionize pro...

(GERMAN_WORD_REPEAT_RULE)

⏰ Context from checks skipped due to timeout of 90000ms (4)
  • GitHub Check: Redirect rules - docs-optimism
  • GitHub Check: Header rules - docs-optimism
  • GitHub Check: Pages changed - docs-optimism
  • GitHub Check: pr-workflow
🔇 Additional comments (1)
words.txt (1)

12-12: LGTM: Term addition aligns with PR objectives.

The addition of "altda" is consistent with the PR's goal of replacing plasma references.

@krofax krofax merged commit f3c1387 into main Jan 17, 2025
8 checks passed
@krofax krofax deleted the ss/replace-dangling-plasma branch January 17, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants