-
Notifications
You must be signed in to change notification settings - Fork 261
feat: Enhance README with badges, social links, and improved formatting #1451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for docs-optimism ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 WalkthroughWalkthroughThe changes update the project's Possibly related PRs
Suggested Reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (3)
README.md (3)
8-8
: Punctuation Improvement for Introductory TextA static analysis hint noted a possible missing comma on this line. Consider revisiting the punctuation (for example, adding a comma after the license badge reference if it flows better stylistically) to improve readability.
🧰 Tools
🪛 LanguageTool
[uncategorized] ~8-~8: Possible missing comma found.
Context: ...LICENSE) This repo houses the Optimism Docs located at [docs.optimism.io](https://d...(AI_HYDRA_LEO_MISSING_COMMA)
23-26
: Contribution Section Clarity and GrammarThe contributions section is clear and provides useful direction. However, consider hyphenating “brand new” to “brand-new” to conform with grammatical best practices.
[grammar]🧰 Tools
🪛 LanguageTool
[grammar] ~25-~25: ‘brand new’ seems to be a compound adjective before a noun. Use a hyphen: “brand-new”.
Context: ... especially if you are writing entirely brand new pages to the developer docs, as opposed...(CA_BRAND_NEW)
42-42
: Tone Consistency in Call-to-ActionThe closing call-to-action is motivating; however, consider if the exclamation mark fits with your overall tone. A slightly more subdued punctuation might align better with a professional style guide.
🧰 Tools
🪛 LanguageTool
[style] ~42-~42: Using many exclamation marks might seem excessive (in this case: 5 exclamation marks for a text that’s 1682 characters long)
Context: ...te, and help us build a better ecosystem!(EN_EXCESSIVE_EXCLAMATION)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
README.md
(1 hunks)
🧰 Additional context used
🪛 LanguageTool
README.md
[uncategorized] ~8-~8: Possible missing comma found.
Context: ...LICENSE) This repo houses the Optimism Docs located at [docs.optimism.io](https://d...
(AI_HYDRA_LEO_MISSING_COMMA)
[grammar] ~25-~25: ‘brand new’ seems to be a compound adjective before a noun. Use a hyphen: “brand-new”.
Context: ... especially if you are writing entirely brand new pages to the developer docs, as opposed...
(CA_BRAND_NEW)
[style] ~42-~42: Using many exclamation marks might seem excessive (in this case: 5 exclamation marks for a text that’s 1682 characters long)
Context: ...te, and help us build a better ecosystem!
(EN_EXCESSIVE_EXCLAMATION)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - docs-optimism
- GitHub Check: Header rules - docs-optimism
- GitHub Check: Pages changed - docs-optimism
🔇 Additional comments (8)
README.md (8)
1-7
: Enhance Branding and Visibility with Logo and BadgesThe addition of the Optimism logo along with GitHub badges significantly improves visual engagement and provides quick access to key repository metrics. Ensure that the badge URLs and alt texts align with your branding guidelines for consistency.
10-10
: Clear and Engaging Local Development SectionThe “## 🚀 Local Development” header is both clear and inviting. This change effectively directs users to the setup instructions.
12-12
: Helpful Installation HintThe note with the installation link for PNPM is very useful and sets a friendly tone for new developers.
14-16
: Well-Formatted Dependency Installation CommandThe code block for installing dependencies using
pnpm i
is concise and properly annotated, aiding clarity.
18-20
: Concise Command to Start the Development ServerThe code block for starting the development server (
pnpm dev
) is well formatted and easy to follow.
27-30
: Effective Project Board SectionThe project board section succinctly informs users on how to track issues and submit requests, which is a helpful addition.
31-33
: License Section VerificationThe license section is clear and correctly linked to the project's MIT License. No changes needed.
35-41
: Effective Community Engagement with Social Media BadgesThe new “Connect with Us” section enhances community outreach by incorporating visually appealing badges for X (Twitter), Discord, GitHub, and the website. Verify that each badge’s link and label correctly reflect the intended branding.
Description
This update makes the README more engaging, accessible, and easier to navigate.
Tests
Additional context
Metadata