Skip to content

Sb/blob fee bug notice #1515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 18, 2025
Merged

Sb/blob fee bug notice #1515

merged 5 commits into from
Mar 18, 2025

Conversation

sbvegan
Copy link
Collaborator

@sbvegan sbvegan commented Mar 18, 2025

No description provided.

@sbvegan sbvegan requested a review from a team as a code owner March 18, 2025 21:46
Copy link

netlify bot commented Mar 18, 2025

Deploy Preview for docs-optimism ready!

Name Link
🔨 Latest commit c8e5a0d
🔍 Latest deploy log https://app.netlify.com/sites/docs-optimism/deploys/67d9f17e9d63190008ca897f
😎 Deploy Preview https://deploy-preview-1515--docs-optimism.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

coderabbitai bot commented Mar 18, 2025

📝 Walkthrough

Walkthrough

This pull request introduces several changes. First, a new metadata entry is added to pages/notices/_meta.json with the key "blob-fee-bug" and the description "Superchain testnets' blob fee bug". Second, a new document (pages/notices/blob-fee-bug.mdx) is created that details a bug affecting the calculation of the L1 Block's blob base fee in OP Stack testnets. The document explains the fee discrepancy, its potential impact, and provides detailed instructions for chain and node operators regarding the necessary hardfork activation to address the issue, including steps for updating to the latest op-node version and configuring a kill-switch. Additionally, two new words, “Peta” and “Twei”, are appended to words.txt. Lastly, a reference to the new document is added in pages/notices/pectra-changes.mdx to enhance the context regarding the blob fee bug.

Sequence Diagram(s)

sequenceDiagram
    participant Operator as Node Operator
    participant Node as op-node System
    participant Chain as Blockchain Network

    Operator->>Node: Upgrade to op-node v1.12.2
    Node->>Node: Validate configuration (kill-switch enabled)
    Node-->>Operator: Approved to start if configuration is valid
    Operator->>Chain: Schedule hardfork activation time
    Chain-->>Operator: Confirm hardfork activation schedule
Loading

Possibly related PRs

  • pectra notice #1324: The changes in the main PR are directly referenced in the newly added line of this PR that provides a notice about the same bug in the context of the Ethereum Pectra upgrade.
  • Sb/pectra u12a update #1490: The changes in the main PR, which add a new entry about the blob fee bug in the metadata, are directly related to the modifications in the retrieved PR that enhance the notice page with information about the same blob fee bug.
  • holocene upgrade notice page and docs updates #1108: The changes in the main PR, which add a new entry related to a blob fee bug, are directly related to the retrieved PR, as both address issues concerning the Superchain testnets and include documentation updates relevant to the same context.

Suggested labels

do-not-merge

Suggested reviewers

  • cpengilly

Tip

⚡🧪 Multi-step agentic review comment chat (experimental)
  • We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments.
    - To enable this feature, set early_access to true under in the settings.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (4)
pages/notices/blob-fee-bug.mdx (4)

1-15: Frontmatter metadata validation and typo correction.
All required frontmatter fields are present; however, the description currently reads:

description: Learn about the blob fee bug that effects OP Stack testnets on the Superchain and how to fix it.

For accuracy, "effects" should be corrected to "affects."

- description: Learn about the blob fee bug that effects OP Stack testnets on the Superchain and how to fix it.
+ description: Learn about the blob fee bug that affects OP Stack testnets on the Superchain and how to fix it.

22-22: Grammar correction in content.
In the sentence:

...because we'd be overcharge L1 fees.
please change "overcharge" to "overcharged" to correct the verb form.

- because we'd be overcharge L1 fees.
+ because we'd be overcharged L1 fees.
🧰 Tools
🪛 LanguageTool

[formatting] ~22-~22: If the ‘because’ clause is essential to the meaning, do not use a comma before the clause.
Context: ...tnet, there is a temporary liveness risk, because we'd be overcharge L1 fees. This was f...

(COMMA_BEFORE_BECAUSE)


[grammar] ~22-~22: Consider using either the past participle “overcharged” or the present participle “overcharging” here.
Context: ...emporary liveness risk, because we'd be overcharge L1 fees. This was fixed on the `develo...

(BEEN_PART_AGREEMENT)


24-24: Style suggestion: simplify phrasing.
In the sentence:

Mainnet chains will just need to update their binaries to the latest release prior to the activation of Pectra on Ethereum, so the bug isn't triggered when Pectra activates.
consider replacing "prior to" with "before" for improved clarity.

- ...update their binaries to the latest release prior to the activation of Pectra on Ethereum...
+ ...update their binaries to the latest release before the activation of Pectra on Ethereum...
🧰 Tools
🪛 LanguageTool

[style] ~24-~24: ‘prior to’ might be wordy. Consider a shorter alternative.
Context: ...te their binaries to the latest release prior to the activation of Pectra on Ethereum, s...

(EN_WORDINESS_PREMIUM_PRIOR_TO)


73-74: Duplication check in release version list.
Static analysis flagged a possible duplication near the release version list (around the bullet items for op-node and op-geth). Please review these lines to ensure that no phrasing is unintentionally repeated.

🧰 Tools
🪛 LanguageTool

[duplication] ~73-~73: Possible typo: you repeated a word.
Context: ...Schedule Fix time set. * op-node at v1.12.2 * op-geth at [v1.101503.1](https://github.com/ethe...

(ENGLISH_WORD_REPEAT_RULE)

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c2ce585 and d5b1a46.

⛔ Files ignored due to path filters (1)
  • public/img/notices/blob-fee-plot.png is excluded by !**/*.png
📒 Files selected for processing (3)
  • pages/notices/_meta.json (1 hunks)
  • pages/notices/blob-fee-bug.mdx (1 hunks)
  • words.txt (2 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`**/*.mdx`: "ALWAYS review Markdown content THOROUGHLY with the following criteria: - First, check the frontmatter section at the top of the file: 1. For regular pages, ensure AL...

**/*.mdx: "ALWAYS review Markdown content THOROUGHLY with the following criteria:

  • First, check the frontmatter section at the top of the file:
    1. For regular pages, ensure ALL these fields are present and not empty:
    ---
    title: [non-empty]
    lang: [non-empty]
    description: [non-empty]
    topic: [non-empty]
    personas: [non-empty array]
    categories: [non-empty array]
    content_type: [valid type]
    ---
    1. For landing pages (index.mdx or files with ), only these fields are required:
    ---
    title: [non-empty]
    lang: [non-empty]
    description: [non-empty]
    topic: [non-empty]
    ---
    1. If any required fields are missing or empty, comment:
      'This file appears to be missing required metadata. You can fix this by running:
    pnpm metadata-batch-cli:dry "path/to/this/file.mdx"
    Review the changes, then run without :dry to apply them.'
  • Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
  • Avoid gender-specific language and use the imperative form.
  • Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
  • Ensure proper nouns are capitalized in sentences.
  • Apply the Oxford comma.
  • Use proper title case for buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
  • Use correct spelling and grammar at all times (IMPORTANT).
  • For H1, H2, and H3 headers:
    1. Use sentence case, capitalizing only the first word.
    2. Preserve the capitalization of proper nouns, technical terms, and acronyms as defined in the 'nouns.txt' file located in the root directory of the project.
    3. Do not automatically lowercase words that appear in the 'nouns.txt' file, regardless of their position in the header.
  • Flag any headers that seem to inconsistently apply these rules for manual review.
  • When reviewing capitalization, always refer to the 'nouns.txt' file for the correct capitalization of proper nouns and technical terms specific to the project.
    "
  • pages/notices/blob-fee-bug.mdx
🪛 LanguageTool
pages/notices/blob-fee-bug.mdx

[formatting] ~22-~22: If the ‘because’ clause is essential to the meaning, do not use a comma before the clause.
Context: ...tnet, there is a temporary liveness risk, because we'd be overcharge L1 fees. This was f...

(COMMA_BEFORE_BECAUSE)


[grammar] ~22-~22: Consider using either the past participle “overcharged” or the present participle “overcharging” here.
Context: ...emporary liveness risk, because we'd be overcharge L1 fees. This was fixed on the `develo...

(BEEN_PART_AGREEMENT)


[style] ~24-~24: ‘prior to’ might be wordy. Consider a shorter alternative.
Context: ...te their binaries to the latest release prior to the activation of Pectra on Ethereum, s...

(EN_WORDINESS_PREMIUM_PRIOR_TO)


[duplication] ~73-~73: Possible typo: you repeated a word.
Context: ...Schedule Fix time set. * op-node at v1.12.2 * op-geth at [v1.101503.1](https://github.com/ethe...

(ENGLISH_WORD_REPEAT_RULE)

⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Redirect rules - docs-optimism
  • GitHub Check: Header rules - docs-optimism
  • GitHub Check: Pages changed - docs-optimism
🔇 Additional comments (3)
words.txt (2)

287-287: New word "Peta" added successfully.
The new entry "Peta" is appended correctly. If an alphabetical order is expected for this file, please verify its position accordingly.


411-411: New word "Twei" included successfully.
The word "Twei" is added correctly. Ensure it is consistent with the file’s formatting and ordering conventions.

pages/notices/_meta.json (1)

1-7: New metadata entry added successfully.
The new key "blob-fee-bug" with the value "Superchain testnets' blob fee bug" is added in valid JSON syntax. Please confirm that the description precisely communicates the intended notice.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (7)
pages/notices/blob-fee-bug.mdx (7)

1-15: Metadata Correction: Fix Typographical Error in Description
The frontmatter’s description uses "effects" instead of "affects." Please correct this typo to ensure accurate language in the metadata.

-description: Learn about the blob fee bug that effects OP Stack testnets on the Superchain and how to fix it.
+description: Learn about the blob fee bug that affects OP Stack testnets on the Superchain and how to fix it.

22-22: Grammar Improvement: Correct Verb Agreement and Punctuation
In the sentence describing the liveness risk, remove the unnecessary comma before "because" and fix the verb form.

-... there is a temporary liveness risk, because we'd be overcharge L1 fees.
+... there is a temporary liveness risk because we would overcharge L1 fees.
🧰 Tools
🪛 LanguageTool

[formatting] ~22-~22: If the ‘because’ clause is essential to the meaning, do not use a comma before the clause.
Context: ...tnet, there is a temporary liveness risk, because we'd be overcharge L1 fees. This was f...

(COMMA_BEFORE_BECAUSE)


[grammar] ~22-~22: Consider using either the past participle “overcharged” or the present participle “overcharging” here.
Context: ...emporary liveness risk, because we'd be overcharge L1 fees. This was fixed on the `develo...

(BEEN_PART_AGREEMENT)


24-24: Style Suggestion: Replace “prior to” with “before”
To enhance clarity and brevity, consider replacing "prior to" with "before" in this sentence.

-... update their binaries to the latest release prior to the activation of Pectra on Ethereum, so the bug isn't triggered when Pectra activates.
+... update their binaries to the latest release before the activation of Pectra on Ethereum, so the bug isn't triggered when Pectra activates.
🧰 Tools
🪛 LanguageTool

[style] ~24-~24: ‘prior to’ might be wordy. Consider a shorter alternative.
Context: ...te their binaries to the latest release prior to the activation of Pectra on Ethereum, s...

(EN_WORDINESS_PREMIUM_PRIOR_TO)


32-32: Redundancy Removal: Eliminate Duplicate Sentence
There is a duplicate statement regarding the L1 Block's blob base fee calculation. Removing the repeated sentence will improve clarity.

- The L1 Block's blob base fee is calculated with pre-Prague blob schedule parameters. The L1 Block's blob base fee is calculated with pre-Prague schedule parameters.
+ The L1 Block's blob base fee is calculated with pre-Prague blob schedule parameters.

67-69: Clarity and Punctuation: Refine Kill-Switch Explanation
Rephrase the sentences describing the kill-switch to improve readability and add necessary punctuation.

- The purpose of the kill-switch is to make sure that node operators don't accidentally upgrade their nodes without scheduling the fix because most Holesky and Sepolia chains were running a sequencer that ran into the Pectra Blob Schedule bug. So it's better to not start op-node in such cases at all rather than accidentally forking the chain.
+ The purpose of the kill-switch is to ensure that node operators don't accidentally upgrade their nodes without scheduling the fix, because most Holesky and Sepolia chains were running a sequencer that encountered the Pectra Blob Schedule bug. It is better not to start op-node in such cases at all, rather than risk accidentally forking the chain.
🧰 Tools
🪛 LanguageTool

[uncategorized] ~69-~69: Possible missing comma found.
Context: ...r to not start op-node in such cases at all rather than accidentally forking the ch...

(AI_HYDRA_LEO_MISSING_COMMA)


73-73: Bullet List Verification: Check for Unintended Repetition
A static analysis hint flagged a possible repetition in the bullet list item on this line. Please verify that the repeated usage (if any) of "op-node" is intentional.

🧰 Tools
🪛 LanguageTool

[duplication] ~73-~73: Possible typo: you repeated a word.
Context: ...Schedule Fix time set. * op-node at v1.12.2 * op-geth at [v1.101503.1](https://github.com/ethe...

(ENGLISH_WORD_REPEAT_RULE)


95-97: Punctuation Enhancement: Insert Missing Comma for Clarity
In the sentence explaining node divergence, add a comma after "activation time" to improve readability.

-If you upgraded your node binary to `op-node/v1.12.1` or `op-node/v1.12.0` and did not set the Pectra Blob Schedule Fix activation time your node will have forked from the rest of the network.
+If you upgraded your node binary to `op-node/v1.12.1` or `op-node/v1.12.0` and did not set the Pectra Blob Schedule Fix activation time, your node will have forked from the rest of the network.
🧰 Tools
🪛 LanguageTool

[uncategorized] ~97-~97: Possible missing comma found.
Context: ...the Pectra Blob Schedule Fix activation time your node will have forked from the res...

(AI_HYDRA_LEO_MISSING_COMMA)

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d5b1a46 and 64d63bc.

📒 Files selected for processing (2)
  • pages/notices/blob-fee-bug.mdx (1 hunks)
  • pages/notices/pectra-changes.mdx (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • pages/notices/pectra-changes.mdx
🧰 Additional context used
📓 Path-based instructions (1)
`**/*.mdx`: "ALWAYS review Markdown content THOROUGHLY with the following criteria: - First, check the frontmatter section at the top of the file: 1. For regular pages, ensure AL...

**/*.mdx: "ALWAYS review Markdown content THOROUGHLY with the following criteria:

  • First, check the frontmatter section at the top of the file:
    1. For regular pages, ensure ALL these fields are present and not empty:
    ---
    title: [non-empty]
    lang: [non-empty]
    description: [non-empty]
    topic: [non-empty]
    personas: [non-empty array]
    categories: [non-empty array]
    content_type: [valid type]
    ---
    1. For landing pages (index.mdx or files with ), only these fields are required:
    ---
    title: [non-empty]
    lang: [non-empty]
    description: [non-empty]
    topic: [non-empty]
    ---
    1. If any required fields are missing or empty, comment:
      'This file appears to be missing required metadata. You can fix this by running:
    pnpm metadata-batch-cli:dry "path/to/this/file.mdx"
    Review the changes, then run without :dry to apply them.'
  • Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
  • Avoid gender-specific language and use the imperative form.
  • Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
  • Ensure proper nouns are capitalized in sentences.
  • Apply the Oxford comma.
  • Use proper title case for buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
  • Use correct spelling and grammar at all times (IMPORTANT).
  • For H1, H2, and H3 headers:
    1. Use sentence case, capitalizing only the first word.
    2. Preserve the capitalization of proper nouns, technical terms, and acronyms as defined in the 'nouns.txt' file located in the root directory of the project.
    3. Do not automatically lowercase words that appear in the 'nouns.txt' file, regardless of their position in the header.
  • Flag any headers that seem to inconsistently apply these rules for manual review.
  • When reviewing capitalization, always refer to the 'nouns.txt' file for the correct capitalization of proper nouns and technical terms specific to the project.
    "
  • pages/notices/blob-fee-bug.mdx
🪛 LanguageTool
pages/notices/blob-fee-bug.mdx

[formatting] ~22-~22: If the ‘because’ clause is essential to the meaning, do not use a comma before the clause.
Context: ...tnet, there is a temporary liveness risk, because we'd be overcharge L1 fees. This was f...

(COMMA_BEFORE_BECAUSE)


[grammar] ~22-~22: Consider using either the past participle “overcharged” or the present participle “overcharging” here.
Context: ...emporary liveness risk, because we'd be overcharge L1 fees. This was fixed on the `develo...

(BEEN_PART_AGREEMENT)


[style] ~24-~24: ‘prior to’ might be wordy. Consider a shorter alternative.
Context: ...te their binaries to the latest release prior to the activation of Pectra on Ethereum, s...

(EN_WORDINESS_PREMIUM_PRIOR_TO)


[uncategorized] ~69-~69: Possible missing comma found.
Context: ...r to not start op-node in such cases at all rather than accidentally forking the ch...

(AI_HYDRA_LEO_MISSING_COMMA)


[duplication] ~73-~73: Possible typo: you repeated a word.
Context: ...Schedule Fix time set. * op-node at v1.12.2 * op-geth at [v1.101503.1](https://github.com/ethe...

(ENGLISH_WORD_REPEAT_RULE)


[uncategorized] ~97-~97: Possible missing comma found.
Context: ...the Pectra Blob Schedule Fix activation time your node will have forked from the res...

(AI_HYDRA_LEO_MISSING_COMMA)

⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Redirect rules - docs-optimism
  • GitHub Check: Header rules - docs-optimism
  • GitHub Check: Pages changed - docs-optimism

@sbvegan sbvegan merged commit 805f00c into main Mar 18, 2025
8 checks passed
@sbvegan sbvegan deleted the sb/blob-fee-bug-notice branch March 18, 2025 22:22
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (12)
pages/notices/blob-fee-bug.mdx (12)

2-3: Grammar Correction in Frontmatter Description.
The description uses “effects” where the correct term should be “affects.”


22-22: Correction of Fee Description Grammar.
Replace “we'd be overcharge L1 fees” with “we'd be overcharged L1 fees” or “we'd be overcharging L1 fees” to fix the grammar within this critical explanation.

🧰 Tools
🪛 LanguageTool

[formatting] ~22-~22: If the ‘because’ clause is essential to the meaning, do not use a comma before the clause.
Context: ...tnet, there is a temporary liveness risk, because we'd be overcharge L1 fees. This was f...

(COMMA_BEFORE_BECAUSE)


[grammar] ~22-~22: Consider using either the past participle “overcharged” or the present participle “overcharging” here.
Context: ...emporary liveness risk, because we'd be overcharge L1 fees. This was fixed on the `develo...

(BEEN_PART_AGREEMENT)


24-24: Phrase Refinement for Clarity.
Consider changing “prior to the activation” to “before the activation” to achieve a briefer and clearer expression.

🧰 Tools
🪛 LanguageTool

[style] ~24-~24: ‘prior to’ might be wordy. Consider a shorter alternative.
Context: ...te their binaries to the latest release prior to the activation of Pectra on Ethereum, s...

(EN_WORDINESS_PREMIUM_PRIOR_TO)


30-32: Clarify Exponential Calculation Description.
The phrase “off by an exponential of 1.5” could be rephrased—perhaps to “raised to the power of 1.5”—to improve clarity on how the fee calculation error is determined.


34-36: Mathematical Formula Representation.
The code block depicting the formula

BBF_Cancun = BBF_Prague^1.5  

is clear. Consider adding a brief note that “^” denotes exponentiation here to avoid any possible confusion with bitwise XOR in other languages.


63-65: Callout Punctuation Suggestion.
Within the warning callout, inserting a comma after “at startup” (i.e. “…automatically apply the hardfork at startup, causing…”) could improve readability.


67-69: Reduce Redundancy in Kill-Switch Description.
The sentence “The following op-node/v1.12.2 adds a kill-switch to op-node to print an error…” repeats “op-node” unnecessarily. Consider rephrasing to, for example, “The op-node/v1.12.2 release adds a kill-switch that prints an error at startup if the Pectra Blob Schedule Fix time is not set…”


70-71: Bullet List Review for Versioning.
The bullet list displaying version information for op-node (v1.12.2) and op-geth (v1.101503.1) is clear; however, verify that the labeling isn’t overly redundant.


75-77: Refine Activation Time Update Phrasing.
In the callout, the phrase “...the Pectra Blob Schedule Fix activation date is part of the op-node node…” contains a redundant “node.” Consider revising it to “...is part of the op-node release…” for clarity.


84-88: Registry Update Instruction Improvement.
Consider rephrasing “open a PR update the Superchain Registry” to “open a PR to update the Superchain Registry” to enhance clarity.


93-93: Punctuation Improvement for Diverged Nodes Explanation.
Adding a comma after “activation time” would improve readability: “...did not set the Pectra Blob Schedule Fix activation time, your node will have forked from the rest of the network.”


103-110: Query Block Example Clarity.
The code example showing the command cast block --rpc-url=http://localhost:8545 6185373 is clear. It might help to note that the block hash and timestamp provided are illustrative example values.

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 64d63bc and c8e5a0d.

📒 Files selected for processing (1)
  • pages/notices/blob-fee-bug.mdx (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`**/*.mdx`: "ALWAYS review Markdown content THOROUGHLY with the following criteria: - First, check the frontmatter section at the top of the file: 1. For regular pages, ensure AL...

**/*.mdx: "ALWAYS review Markdown content THOROUGHLY with the following criteria:

  • First, check the frontmatter section at the top of the file:
    1. For regular pages, ensure ALL these fields are present and not empty:
    ---
    title: [non-empty]
    lang: [non-empty]
    description: [non-empty]
    topic: [non-empty]
    personas: [non-empty array]
    categories: [non-empty array]
    content_type: [valid type]
    ---
    1. For landing pages (index.mdx or files with ), only these fields are required:
    ---
    title: [non-empty]
    lang: [non-empty]
    description: [non-empty]
    topic: [non-empty]
    ---
    1. If any required fields are missing or empty, comment:
      'This file appears to be missing required metadata. You can fix this by running:
    pnpm metadata-batch-cli:dry "path/to/this/file.mdx"
    Review the changes, then run without :dry to apply them.'
  • Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
  • Avoid gender-specific language and use the imperative form.
  • Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
  • Ensure proper nouns are capitalized in sentences.
  • Apply the Oxford comma.
  • Use proper title case for buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
  • Use correct spelling and grammar at all times (IMPORTANT).
  • For H1, H2, and H3 headers:
    1. Use sentence case, capitalizing only the first word.
    2. Preserve the capitalization of proper nouns, technical terms, and acronyms as defined in the 'nouns.txt' file located in the root directory of the project.
    3. Do not automatically lowercase words that appear in the 'nouns.txt' file, regardless of their position in the header.
  • Flag any headers that seem to inconsistently apply these rules for manual review.
  • When reviewing capitalization, always refer to the 'nouns.txt' file for the correct capitalization of proper nouns and technical terms specific to the project.
    "
  • pages/notices/blob-fee-bug.mdx
🪛 LanguageTool
pages/notices/blob-fee-bug.mdx

[formatting] ~22-~22: If the ‘because’ clause is essential to the meaning, do not use a comma before the clause.
Context: ...tnet, there is a temporary liveness risk, because we'd be overcharge L1 fees. This was f...

(COMMA_BEFORE_BECAUSE)


[grammar] ~22-~22: Consider using either the past participle “overcharged” or the present participle “overcharging” here.
Context: ...emporary liveness risk, because we'd be overcharge L1 fees. This was fixed on the `develo...

(BEEN_PART_AGREEMENT)


[style] ~24-~24: ‘prior to’ might be wordy. Consider a shorter alternative.
Context: ...te their binaries to the latest release prior to the activation of Pectra on Ethereum, s...

(EN_WORDINESS_PREMIUM_PRIOR_TO)


[duplication] ~73-~73: Possible typo: you repeated a word.
Context: ...Schedule Fix time set. * op-node at v1.12.2 * op-geth at [v1.101503.1](https://github.com/ethe...

(ENGLISH_WORD_REPEAT_RULE)

⏰ Context from checks skipped due to timeout of 90000ms (4)
  • GitHub Check: Redirect rules - docs-optimism
  • GitHub Check: Header rules - docs-optimism
  • GitHub Check: Pages changed - docs-optimism
  • GitHub Check: pr-workflow
🔇 Additional comments (10)
pages/notices/blob-fee-bug.mdx (10)

17-19: Valid Imports.
The import statements for { Steps, Callout } and Image are correctly included.


20-20: Header Formatting.
The H1 header “Superchain testnets' blob fee bug” is formatted correctly in sentence case and adheres to the capitalization rules for technical terms.


38-41: Table and Image Formatting.
The table and the included image (with alt text “Blob Fee Bug Graph”) are well-formatted and effectively illustrate the fee impact. Please double-check that the image path /img/notices/blob-fee-plot.png is correct.


52-52: Section Header for Chain and Node Operators.
The header “## For chain and node operators” is appropriately formatted and clear.


56-56: Activation Time Instruction Clarity.
The instructions regarding which network flags to use and the specified hardfork activation time are precise and easy to follow.


58-59: Chain Registry List Clarity.
The list of chains that are not opted into the hardfork activation inheritance behavior is clearly presented.


95-96: Diverged Node Fix Instructions Clarity.
The options provided for fixing diverged nodes—either restoring from a snapshot or using op-wheel—are clearly explained.


97-102: Stopping Node Instructions.
The steps for stopping op-node and op-geth are well-articulated; emphasizing the need for a graceful shutdown (using Ctrl+C) is appropriate.


112-116: Chain Reorganization Command.
The command using cast rpc --rpc-url=http://localhost:8545 debug_setHead 0x5E619D is clear and correctly formatted.


118-124: Forkchoice Command Clarity.
The provided command to set the forkchoice using go run ./op-wheel/cmd engine set-forkchoice ... is well-detailed and clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants