-
Notifications
You must be signed in to change notification settings - Fork 263
Sb/blob fee bug notice #1515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sb/blob fee bug notice #1515
Conversation
✅ Deploy Preview for docs-optimism ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 WalkthroughWalkthroughThis pull request introduces several changes. First, a new metadata entry is added to Sequence Diagram(s)sequenceDiagram
participant Operator as Node Operator
participant Node as op-node System
participant Chain as Blockchain Network
Operator->>Node: Upgrade to op-node v1.12.2
Node->>Node: Validate configuration (kill-switch enabled)
Node-->>Operator: Approved to start if configuration is valid
Operator->>Chain: Schedule hardfork activation time
Chain-->>Operator: Confirm hardfork activation schedule
Possibly related PRs
Suggested labels
Suggested reviewers
Tip ⚡🧪 Multi-step agentic review comment chat (experimental)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (4)
pages/notices/blob-fee-bug.mdx (4)
1-15
: Frontmatter metadata validation and typo correction.
All required frontmatter fields are present; however, the description currently reads:description: Learn about the blob fee bug that effects OP Stack testnets on the Superchain and how to fix it.For accuracy, "effects" should be corrected to "affects."
- description: Learn about the blob fee bug that effects OP Stack testnets on the Superchain and how to fix it. + description: Learn about the blob fee bug that affects OP Stack testnets on the Superchain and how to fix it.
22-22
: Grammar correction in content.
In the sentence:...because we'd be overcharge L1 fees.
please change "overcharge" to "overcharged" to correct the verb form.- because we'd be overcharge L1 fees. + because we'd be overcharged L1 fees.🧰 Tools
🪛 LanguageTool
[formatting] ~22-~22: If the ‘because’ clause is essential to the meaning, do not use a comma before the clause.
Context: ...tnet, there is a temporary liveness risk, because we'd be overcharge L1 fees. This was f...(COMMA_BEFORE_BECAUSE)
[grammar] ~22-~22: Consider using either the past participle “overcharged” or the present participle “overcharging” here.
Context: ...emporary liveness risk, because we'd be overcharge L1 fees. This was fixed on the `develo...(BEEN_PART_AGREEMENT)
24-24
: Style suggestion: simplify phrasing.
In the sentence:Mainnet chains will just need to update their binaries to the latest release prior to the activation of Pectra on Ethereum, so the bug isn't triggered when Pectra activates.
consider replacing "prior to" with "before" for improved clarity.- ...update their binaries to the latest release prior to the activation of Pectra on Ethereum... + ...update their binaries to the latest release before the activation of Pectra on Ethereum...🧰 Tools
🪛 LanguageTool
[style] ~24-~24: ‘prior to’ might be wordy. Consider a shorter alternative.
Context: ...te their binaries to the latest release prior to the activation of Pectra on Ethereum, s...(EN_WORDINESS_PREMIUM_PRIOR_TO)
73-74
: Duplication check in release version list.
Static analysis flagged a possible duplication near the release version list (around the bullet items forop-node
andop-geth
). Please review these lines to ensure that no phrasing is unintentionally repeated.🧰 Tools
🪛 LanguageTool
[duplication] ~73-~73: Possible typo: you repeated a word.
Context: ...Schedule Fix time set. *op-node
atv1.12.2
*op-geth
at [v1.101503.1
](https://github.com/ethe...(ENGLISH_WORD_REPEAT_RULE)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
public/img/notices/blob-fee-plot.png
is excluded by!**/*.png
📒 Files selected for processing (3)
pages/notices/_meta.json
(1 hunks)pages/notices/blob-fee-bug.mdx
(1 hunks)words.txt
(2 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`**/*.mdx`: "ALWAYS review Markdown content THOROUGHLY with the following criteria: - First, check the frontmatter section at the top of the file: 1. For regular pages, ensure AL...
**/*.mdx
: "ALWAYS review Markdown content THOROUGHLY with the following criteria:
- First, check the frontmatter section at the top of the file:
- For regular pages, ensure ALL these fields are present and not empty:
--- title: [non-empty] lang: [non-empty] description: [non-empty] topic: [non-empty] personas: [non-empty array] categories: [non-empty array] content_type: [valid type] ---
- For landing pages (index.mdx or files with ), only these fields are required:
--- title: [non-empty] lang: [non-empty] description: [non-empty] topic: [non-empty] ---
- If any required fields are missing or empty, comment:
'This file appears to be missing required metadata. You can fix this by running:Review the changes, then run without :dry to apply them.'pnpm metadata-batch-cli:dry "path/to/this/file.mdx"
- Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
- Avoid gender-specific language and use the imperative form.
- Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
- Ensure proper nouns are capitalized in sentences.
- Apply the Oxford comma.
- Use proper title case for buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
- Use correct spelling and grammar at all times (IMPORTANT).
- For H1, H2, and H3 headers:
- Use sentence case, capitalizing only the first word.
- Preserve the capitalization of proper nouns, technical terms, and acronyms as defined in the 'nouns.txt' file located in the root directory of the project.
- Do not automatically lowercase words that appear in the 'nouns.txt' file, regardless of their position in the header.
- Flag any headers that seem to inconsistently apply these rules for manual review.
- When reviewing capitalization, always refer to the 'nouns.txt' file for the correct capitalization of proper nouns and technical terms specific to the project.
"
pages/notices/blob-fee-bug.mdx
🪛 LanguageTool
pages/notices/blob-fee-bug.mdx
[formatting] ~22-~22: If the ‘because’ clause is essential to the meaning, do not use a comma before the clause.
Context: ...tnet, there is a temporary liveness risk, because we'd be overcharge L1 fees. This was f...
(COMMA_BEFORE_BECAUSE)
[grammar] ~22-~22: Consider using either the past participle “overcharged” or the present participle “overcharging” here.
Context: ...emporary liveness risk, because we'd be overcharge L1 fees. This was fixed on the `develo...
(BEEN_PART_AGREEMENT)
[style] ~24-~24: ‘prior to’ might be wordy. Consider a shorter alternative.
Context: ...te their binaries to the latest release prior to the activation of Pectra on Ethereum, s...
(EN_WORDINESS_PREMIUM_PRIOR_TO)
[duplication] ~73-~73: Possible typo: you repeated a word.
Context: ...Schedule Fix time set. * op-node
at v1.12.2
* op-geth
at [v1.101503.1
](https://github.com/ethe...
(ENGLISH_WORD_REPEAT_RULE)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - docs-optimism
- GitHub Check: Header rules - docs-optimism
- GitHub Check: Pages changed - docs-optimism
🔇 Additional comments (3)
words.txt (2)
287-287
: New word "Peta" added successfully.
The new entry "Peta" is appended correctly. If an alphabetical order is expected for this file, please verify its position accordingly.
411-411
: New word "Twei" included successfully.
The word "Twei" is added correctly. Ensure it is consistent with the file’s formatting and ordering conventions.pages/notices/_meta.json (1)
1-7
: New metadata entry added successfully.
The new key"blob-fee-bug"
with the value"Superchain testnets' blob fee bug"
is added in valid JSON syntax. Please confirm that the description precisely communicates the intended notice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (7)
pages/notices/blob-fee-bug.mdx (7)
1-15
: Metadata Correction: Fix Typographical Error in Description
The frontmatter’s description uses "effects" instead of "affects." Please correct this typo to ensure accurate language in the metadata.-description: Learn about the blob fee bug that effects OP Stack testnets on the Superchain and how to fix it. +description: Learn about the blob fee bug that affects OP Stack testnets on the Superchain and how to fix it.
22-22
: Grammar Improvement: Correct Verb Agreement and Punctuation
In the sentence describing the liveness risk, remove the unnecessary comma before "because" and fix the verb form.-... there is a temporary liveness risk, because we'd be overcharge L1 fees. +... there is a temporary liveness risk because we would overcharge L1 fees.🧰 Tools
🪛 LanguageTool
[formatting] ~22-~22: If the ‘because’ clause is essential to the meaning, do not use a comma before the clause.
Context: ...tnet, there is a temporary liveness risk, because we'd be overcharge L1 fees. This was f...(COMMA_BEFORE_BECAUSE)
[grammar] ~22-~22: Consider using either the past participle “overcharged” or the present participle “overcharging” here.
Context: ...emporary liveness risk, because we'd be overcharge L1 fees. This was fixed on the `develo...(BEEN_PART_AGREEMENT)
24-24
: Style Suggestion: Replace “prior to” with “before”
To enhance clarity and brevity, consider replacing "prior to" with "before" in this sentence.-... update their binaries to the latest release prior to the activation of Pectra on Ethereum, so the bug isn't triggered when Pectra activates. +... update their binaries to the latest release before the activation of Pectra on Ethereum, so the bug isn't triggered when Pectra activates.🧰 Tools
🪛 LanguageTool
[style] ~24-~24: ‘prior to’ might be wordy. Consider a shorter alternative.
Context: ...te their binaries to the latest release prior to the activation of Pectra on Ethereum, s...(EN_WORDINESS_PREMIUM_PRIOR_TO)
32-32
: Redundancy Removal: Eliminate Duplicate Sentence
There is a duplicate statement regarding the L1 Block's blob base fee calculation. Removing the repeated sentence will improve clarity.- The L1 Block's blob base fee is calculated with pre-Prague blob schedule parameters. The L1 Block's blob base fee is calculated with pre-Prague schedule parameters. + The L1 Block's blob base fee is calculated with pre-Prague blob schedule parameters.
67-69
: Clarity and Punctuation: Refine Kill-Switch Explanation
Rephrase the sentences describing the kill-switch to improve readability and add necessary punctuation.- The purpose of the kill-switch is to make sure that node operators don't accidentally upgrade their nodes without scheduling the fix because most Holesky and Sepolia chains were running a sequencer that ran into the Pectra Blob Schedule bug. So it's better to not start op-node in such cases at all rather than accidentally forking the chain. + The purpose of the kill-switch is to ensure that node operators don't accidentally upgrade their nodes without scheduling the fix, because most Holesky and Sepolia chains were running a sequencer that encountered the Pectra Blob Schedule bug. It is better not to start op-node in such cases at all, rather than risk accidentally forking the chain.🧰 Tools
🪛 LanguageTool
[uncategorized] ~69-~69: Possible missing comma found.
Context: ...r to not start op-node in such cases at all rather than accidentally forking the ch...(AI_HYDRA_LEO_MISSING_COMMA)
73-73
: Bullet List Verification: Check for Unintended Repetition
A static analysis hint flagged a possible repetition in the bullet list item on this line. Please verify that the repeated usage (if any) of "op-node" is intentional.🧰 Tools
🪛 LanguageTool
[duplication] ~73-~73: Possible typo: you repeated a word.
Context: ...Schedule Fix time set. *op-node
atv1.12.2
*op-geth
at [v1.101503.1
](https://github.com/ethe...(ENGLISH_WORD_REPEAT_RULE)
95-97
: Punctuation Enhancement: Insert Missing Comma for Clarity
In the sentence explaining node divergence, add a comma after "activation time" to improve readability.-If you upgraded your node binary to `op-node/v1.12.1` or `op-node/v1.12.0` and did not set the Pectra Blob Schedule Fix activation time your node will have forked from the rest of the network. +If you upgraded your node binary to `op-node/v1.12.1` or `op-node/v1.12.0` and did not set the Pectra Blob Schedule Fix activation time, your node will have forked from the rest of the network.🧰 Tools
🪛 LanguageTool
[uncategorized] ~97-~97: Possible missing comma found.
Context: ...the Pectra Blob Schedule Fix activation time your node will have forked from the res...(AI_HYDRA_LEO_MISSING_COMMA)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
pages/notices/blob-fee-bug.mdx
(1 hunks)pages/notices/pectra-changes.mdx
(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- pages/notices/pectra-changes.mdx
🧰 Additional context used
📓 Path-based instructions (1)
`**/*.mdx`: "ALWAYS review Markdown content THOROUGHLY with the following criteria: - First, check the frontmatter section at the top of the file: 1. For regular pages, ensure AL...
**/*.mdx
: "ALWAYS review Markdown content THOROUGHLY with the following criteria:
- First, check the frontmatter section at the top of the file:
- For regular pages, ensure ALL these fields are present and not empty:
--- title: [non-empty] lang: [non-empty] description: [non-empty] topic: [non-empty] personas: [non-empty array] categories: [non-empty array] content_type: [valid type] ---
- For landing pages (index.mdx or files with ), only these fields are required:
--- title: [non-empty] lang: [non-empty] description: [non-empty] topic: [non-empty] ---
- If any required fields are missing or empty, comment:
'This file appears to be missing required metadata. You can fix this by running:Review the changes, then run without :dry to apply them.'pnpm metadata-batch-cli:dry "path/to/this/file.mdx"
- Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
- Avoid gender-specific language and use the imperative form.
- Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
- Ensure proper nouns are capitalized in sentences.
- Apply the Oxford comma.
- Use proper title case for buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
- Use correct spelling and grammar at all times (IMPORTANT).
- For H1, H2, and H3 headers:
- Use sentence case, capitalizing only the first word.
- Preserve the capitalization of proper nouns, technical terms, and acronyms as defined in the 'nouns.txt' file located in the root directory of the project.
- Do not automatically lowercase words that appear in the 'nouns.txt' file, regardless of their position in the header.
- Flag any headers that seem to inconsistently apply these rules for manual review.
- When reviewing capitalization, always refer to the 'nouns.txt' file for the correct capitalization of proper nouns and technical terms specific to the project.
"
pages/notices/blob-fee-bug.mdx
🪛 LanguageTool
pages/notices/blob-fee-bug.mdx
[formatting] ~22-~22: If the ‘because’ clause is essential to the meaning, do not use a comma before the clause.
Context: ...tnet, there is a temporary liveness risk, because we'd be overcharge L1 fees. This was f...
(COMMA_BEFORE_BECAUSE)
[grammar] ~22-~22: Consider using either the past participle “overcharged” or the present participle “overcharging” here.
Context: ...emporary liveness risk, because we'd be overcharge L1 fees. This was fixed on the `develo...
(BEEN_PART_AGREEMENT)
[style] ~24-~24: ‘prior to’ might be wordy. Consider a shorter alternative.
Context: ...te their binaries to the latest release prior to the activation of Pectra on Ethereum, s...
(EN_WORDINESS_PREMIUM_PRIOR_TO)
[uncategorized] ~69-~69: Possible missing comma found.
Context: ...r to not start op-node in such cases at all rather than accidentally forking the ch...
(AI_HYDRA_LEO_MISSING_COMMA)
[duplication] ~73-~73: Possible typo: you repeated a word.
Context: ...Schedule Fix time set. * op-node
at v1.12.2
* op-geth
at [v1.101503.1
](https://github.com/ethe...
(ENGLISH_WORD_REPEAT_RULE)
[uncategorized] ~97-~97: Possible missing comma found.
Context: ...the Pectra Blob Schedule Fix activation time your node will have forked from the res...
(AI_HYDRA_LEO_MISSING_COMMA)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - docs-optimism
- GitHub Check: Header rules - docs-optimism
- GitHub Check: Pages changed - docs-optimism
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (12)
pages/notices/blob-fee-bug.mdx (12)
2-3
: Grammar Correction in Frontmatter Description.
The description uses “effects” where the correct term should be “affects.”
22-22
: Correction of Fee Description Grammar.
Replace “we'd be overcharge L1 fees” with “we'd be overcharged L1 fees” or “we'd be overcharging L1 fees” to fix the grammar within this critical explanation.🧰 Tools
🪛 LanguageTool
[formatting] ~22-~22: If the ‘because’ clause is essential to the meaning, do not use a comma before the clause.
Context: ...tnet, there is a temporary liveness risk, because we'd be overcharge L1 fees. This was f...(COMMA_BEFORE_BECAUSE)
[grammar] ~22-~22: Consider using either the past participle “overcharged” or the present participle “overcharging” here.
Context: ...emporary liveness risk, because we'd be overcharge L1 fees. This was fixed on the `develo...(BEEN_PART_AGREEMENT)
24-24
: Phrase Refinement for Clarity.
Consider changing “prior to the activation” to “before the activation” to achieve a briefer and clearer expression.🧰 Tools
🪛 LanguageTool
[style] ~24-~24: ‘prior to’ might be wordy. Consider a shorter alternative.
Context: ...te their binaries to the latest release prior to the activation of Pectra on Ethereum, s...(EN_WORDINESS_PREMIUM_PRIOR_TO)
30-32
: Clarify Exponential Calculation Description.
The phrase “off by an exponential of 1.5” could be rephrased—perhaps to “raised to the power of 1.5”—to improve clarity on how the fee calculation error is determined.
34-36
: Mathematical Formula Representation.
The code block depicting the formulaBBF_Cancun = BBF_Prague^1.5
is clear. Consider adding a brief note that “^” denotes exponentiation here to avoid any possible confusion with bitwise XOR in other languages.
63-65
: Callout Punctuation Suggestion.
Within the warning callout, inserting a comma after “at startup” (i.e. “…automatically apply the hardfork at startup, causing…”) could improve readability.
67-69
: Reduce Redundancy in Kill-Switch Description.
The sentence “The followingop-node/v1.12.2
adds a kill-switch to op-node to print an error…” repeats “op-node” unnecessarily. Consider rephrasing to, for example, “The op-node/v1.12.2 release adds a kill-switch that prints an error at startup if the Pectra Blob Schedule Fix time is not set…”
70-71
: Bullet List Review for Versioning.
The bullet list displaying version information forop-node
(v1.12.2) andop-geth
(v1.101503.1) is clear; however, verify that the labeling isn’t overly redundant.
75-77
: Refine Activation Time Update Phrasing.
In the callout, the phrase “...the Pectra Blob Schedule Fix activation date is part of the op-node node…” contains a redundant “node.” Consider revising it to “...is part of the op-node release…” for clarity.
84-88
: Registry Update Instruction Improvement.
Consider rephrasing “open a PR update the Superchain Registry” to “open a PR to update the Superchain Registry” to enhance clarity.
93-93
: Punctuation Improvement for Diverged Nodes Explanation.
Adding a comma after “activation time” would improve readability: “...did not set the Pectra Blob Schedule Fix activation time, your node will have forked from the rest of the network.”
103-110
: Query Block Example Clarity.
The code example showing the commandcast block --rpc-url=http://localhost:8545 6185373
is clear. It might help to note that the block hash and timestamp provided are illustrative example values.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
pages/notices/blob-fee-bug.mdx
(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`**/*.mdx`: "ALWAYS review Markdown content THOROUGHLY with the following criteria: - First, check the frontmatter section at the top of the file: 1. For regular pages, ensure AL...
**/*.mdx
: "ALWAYS review Markdown content THOROUGHLY with the following criteria:
- First, check the frontmatter section at the top of the file:
- For regular pages, ensure ALL these fields are present and not empty:
--- title: [non-empty] lang: [non-empty] description: [non-empty] topic: [non-empty] personas: [non-empty array] categories: [non-empty array] content_type: [valid type] ---
- For landing pages (index.mdx or files with ), only these fields are required:
--- title: [non-empty] lang: [non-empty] description: [non-empty] topic: [non-empty] ---
- If any required fields are missing or empty, comment:
'This file appears to be missing required metadata. You can fix this by running:Review the changes, then run without :dry to apply them.'pnpm metadata-batch-cli:dry "path/to/this/file.mdx"
- Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
- Avoid gender-specific language and use the imperative form.
- Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
- Ensure proper nouns are capitalized in sentences.
- Apply the Oxford comma.
- Use proper title case for buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
- Use correct spelling and grammar at all times (IMPORTANT).
- For H1, H2, and H3 headers:
- Use sentence case, capitalizing only the first word.
- Preserve the capitalization of proper nouns, technical terms, and acronyms as defined in the 'nouns.txt' file located in the root directory of the project.
- Do not automatically lowercase words that appear in the 'nouns.txt' file, regardless of their position in the header.
- Flag any headers that seem to inconsistently apply these rules for manual review.
- When reviewing capitalization, always refer to the 'nouns.txt' file for the correct capitalization of proper nouns and technical terms specific to the project.
"
pages/notices/blob-fee-bug.mdx
🪛 LanguageTool
pages/notices/blob-fee-bug.mdx
[formatting] ~22-~22: If the ‘because’ clause is essential to the meaning, do not use a comma before the clause.
Context: ...tnet, there is a temporary liveness risk, because we'd be overcharge L1 fees. This was f...
(COMMA_BEFORE_BECAUSE)
[grammar] ~22-~22: Consider using either the past participle “overcharged” or the present participle “overcharging” here.
Context: ...emporary liveness risk, because we'd be overcharge L1 fees. This was fixed on the `develo...
(BEEN_PART_AGREEMENT)
[style] ~24-~24: ‘prior to’ might be wordy. Consider a shorter alternative.
Context: ...te their binaries to the latest release prior to the activation of Pectra on Ethereum, s...
(EN_WORDINESS_PREMIUM_PRIOR_TO)
[duplication] ~73-~73: Possible typo: you repeated a word.
Context: ...Schedule Fix time set. * op-node
at v1.12.2
* op-geth
at [v1.101503.1
](https://github.com/ethe...
(ENGLISH_WORD_REPEAT_RULE)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: Redirect rules - docs-optimism
- GitHub Check: Header rules - docs-optimism
- GitHub Check: Pages changed - docs-optimism
- GitHub Check: pr-workflow
🔇 Additional comments (10)
pages/notices/blob-fee-bug.mdx (10)
17-19
: Valid Imports.
The import statements for{ Steps, Callout }
andImage
are correctly included.
20-20
: Header Formatting.
The H1 header “Superchain testnets' blob fee bug” is formatted correctly in sentence case and adheres to the capitalization rules for technical terms.
38-41
: Table and Image Formatting.
The table and the included image (with alt text “Blob Fee Bug Graph”) are well-formatted and effectively illustrate the fee impact. Please double-check that the image path/img/notices/blob-fee-plot.png
is correct.
52-52
: Section Header for Chain and Node Operators.
The header “## For chain and node operators” is appropriately formatted and clear.
56-56
: Activation Time Instruction Clarity.
The instructions regarding which network flags to use and the specified hardfork activation time are precise and easy to follow.
58-59
: Chain Registry List Clarity.
The list of chains that are not opted into the hardfork activation inheritance behavior is clearly presented.
95-96
: Diverged Node Fix Instructions Clarity.
The options provided for fixing diverged nodes—either restoring from a snapshot or usingop-wheel
—are clearly explained.
97-102
: Stopping Node Instructions.
The steps for stopping op-node and op-geth are well-articulated; emphasizing the need for a graceful shutdown (usingCtrl+C
) is appropriate.
112-116
: Chain Reorganization Command.
The command usingcast rpc --rpc-url=http://localhost:8545 debug_setHead 0x5E619D
is clear and correctly formatted.
118-124
: Forkchoice Command Clarity.
The provided command to set the forkchoice usinggo run ./op-wheel/cmd engine set-forkchoice ...
is well-detailed and clear.
No description provided.