-
Notifications
You must be signed in to change notification settings - Fork 259
Op deployer update #1580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Op deployer update #1580
Conversation
✅ Deploy Preview for docs-optimism ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 WalkthroughWalkthroughThe changes primarily focus on a comprehensive expansion and restructuring of the Sequence Diagram(s)sequenceDiagram
participant User
participant Documentation
User->>Documentation: Access installation instructions
Documentation-->>User: Provide binary and source build steps
User->>Documentation: Reference deployment usage
Documentation-->>User: Show command examples, flags, and intent file structure
User->>Documentation: Learn about contract artifacts
Documentation-->>User: Explain artifact locator schemes and usage
User->>Documentation: Review bootstrap procedures
Documentation-->>User: Detail commands, parameters, examples, and outputs
User->>Documentation: Consult verification and inspection commands
Documentation-->>User: Provide usage examples and explanations
Possibly related PRs
Suggested reviewers
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (3)
pages/operators/chain-operators/tools/op-deployer.mdx (3)
48-48
: Minor grammatical error in the text.There's a missing definite article in the sentence.
-After installing all of that, run following: +After installing all of that, run the following:🧰 Tools
🪛 LanguageTool
[uncategorized] ~48-~48: You might be missing the article “the” here.
Context: ...git`. After installing all of that, run following: ```bash git clone https://github.com...(AI_EN_LECTOR_MISSING_DETERMINER_THE)
216-216
: Minor grammatical error in file locator explanation.There's a missing definite article in the sentence.
-This is useful for local development, since you can point it at your local monorepo +This is useful for local development, since you can point it at the local monorepo🧰 Tools
🪛 LanguageTool
[uncategorized] ~216-~216: You might be missing the article “the” here.
Context: ...file://
- Points to a directory on local disk containing the artifacts. This...(AI_EN_LECTOR_MISSING_DETERMINER_THE)
430-430
: Remove Notion URL from documentation.There appears to be a Notion URL inadvertently included in the parameter description table for the guardian parameter.
-| [--guardian](https://www.notion.so/Updating-the-op-deployer-docs-1d0f153ee16280b69888f290426c5ce4?pvs=21) | Address authorized to pause L1 withdrawals from contracts, blacklist dispute games, and set the respected game type | Yes | 0x3456...cdef | +| --guardian | Address authorized to pause L1 withdrawals from contracts, blacklist dispute games, and set the respected game type | Yes | 0x3456...cdef |
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
pages/operators/chain-operators/tools/op-deployer.mdx
(6 hunks)words.txt
(4 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`**/*.mdx`: "ALWAYS review Markdown content THOROUGHLY with the following criteria: - First, check the frontmatter section at the top of the file: 1. For regular pages, ensure AL...
**/*.mdx
: "ALWAYS review Markdown content THOROUGHLY with the following criteria:
- First, check the frontmatter section at the top of the file:
- For regular pages, ensure ALL these fields are present and not empty:
--- title: [non-empty] lang: [non-empty] description: [non-empty] topic: [non-empty] personas: [non-empty array] categories: [non-empty array] content_type: [valid type] ---
- For landing pages (index.mdx or files with ), only these fields are required:
--- title: [non-empty] lang: [non-empty] description: [non-empty] topic: [non-empty] ---
- If any required fields are missing or empty, comment:
'This file appears to be missing required metadata. Please check keywords.config.yaml for valid options and add the required fields manually. You can validate your changes by running:pnpm validate-metadata ```'
- Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
- Avoid gender-specific language and use the imperative form.
- Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
- Ensure proper nouns are capitalized in sentences.
- Apply the Oxford comma.
- Use proper title case for buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
- Use correct spelling and grammar at all times (IMPORTANT).
- For H1, H2, and H3 headers:
- Use sentence case, capitalizing only the first word.
- Preserve the capitalization of proper nouns, technical terms, and acronyms as defined in the 'nouns.txt' file located in the root directory of the project.
- Do not automatically lowercase words that appear in the 'nouns.txt' file, regardless of their position in the header.
- Flag any headers that seem to inconsistently apply these rules for manual review.
- When reviewing capitalization, always refer to the 'nouns.txt' file for the correct capitalization of proper nouns and technical terms specific to the project.
"
pages/operators/chain-operators/tools/op-deployer.mdx
🪛 LanguageTool
words.txt
[duplication] ~26-~26: Možný preklep: zopakovali ste slovo
Context: ...elay autorelay autorelayer basefee bcde Betanet betanet Betanets betanets BGEZ BGTZ Biconomy BL...
(WORD_REPEAT_RULE)
[duplication] ~66-~66: Možný preklep: zopakovali ste slovo
Context: ...otli brotli Callouts callouts CCIP cdef Celestia Celestia's chainid Chainlink chainlist Chainstac...
(WORD_REPEAT_RULE)
pages/operators/chain-operators/tools/op-deployer.mdx
[uncategorized] ~48-~48: You might be missing the article “the” here.
Context: ...git`. After installing all of that, run following: ```bash git clone https://github.com...
(AI_EN_LECTOR_MISSING_DETERMINER_THE)
[uncategorized] ~140-~140: Loose punctuation mark.
Context: ...nfiguration:** * deploymentStrategy
: Used to deploy both to live chains and ...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~141-~141: Loose punctuation mark.
Context: ...e live
and genesis
. * configType
: Type of configuration to use ("standard...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~149-~149: Loose punctuation mark.
Context: ...perchain roles:** * proxyAdminOwner
: Address that can upgrade Superchain-wid...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~155-~155: Loose punctuation mark.
Context: ...hain-specific configuration:** * id
: Unique identifier for your chain * `b...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~163-~163: Loose punctuation mark.
Context: ...Chain roles:* * l1ProxyAdminOwner
: Address authorized to update the L1 Pro...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~165-~165: Loose punctuation mark.
Context: ...n owner address. * systemConfigOwner
: Address authorized to change values in ...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~169-~169: Loose punctuation mark.
Context: ...aultdisputegame) on L1. * challenger
: Address Account which can interact with...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~216-~216: You might be missing the article “the” here.
Context: ... file://
- Points to a directory on local disk containing the artifacts. This...
(AI_EN_LECTOR_MISSING_DETERMINER_THE)
[uncategorized] ~272-~272: Loose punctuation mark.
Context: ...ecifies where to deploy: * live
: Deploys directly to a live L1 network. ...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~273-~273: Loose punctuation mark.
Context: ...land
-private-key. *
genesis`: Generates an L1 genesis file for local ...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~274-~274: Loose punctuation mark.
Context: ...sting or development. * calldata
: Produces calldata for multisig wallets,...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~275-~275: Loose punctuation mark.
Context: ...bling offline deployment. * noop
: Performs a dry-run without actual deplo...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~279-~279: Loose punctuation mark.
Context: ...t best fits your use case. ### verify
: verify contract source code on block ex...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~294-~294: Loose punctuation mark.
Context: ... ### Common options: * -l1-rpc-url
: RPC URL for the L1 chain * `-ethersca...
(UNLIKELY_OPENING_PUNCTUATION)
[style] ~339-~339: Consider using a different adverb to strengthen your wording.
Context: ...ds are essential when you're setting up a completely new superchain environment rather than ...
(COMPLETELY_ENTIRELY)
[style] ~347-~347: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...perchain configuration contracts. 3. Deploy implementations (`bootstrap implement...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~348-~348: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...acts needed for the dispute game. 4. Deploy validator (bootstrap validator
): De...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - docs-optimism
- GitHub Check: Header rules - docs-optimism
- GitHub Check: Pages changed - docs-optimism
🔇 Additional comments (20)
words.txt (4)
26-26
: New word "bcde" added in alphabetical order.The word "bcde" has been properly added to the word list in alphabetical order, correctly positioned between "basefee" and "Betanet".
🧰 Tools
🪛 LanguageTool
[duplication] ~26-~26: Možný preklep: zopakovali ste slovo
Context: ...elay autorelay autorelayer basefee bcde Betanet betanet Betanets betanets BGEZ BGTZ Biconomy BL...(WORD_REPEAT_RULE)
66-66
: New word "cdef" added in alphabetical order.The word "cdef" has been properly added to the word list in alphabetical order, correctly positioned between "CCIP" and "Celestia".
🧰 Tools
🪛 LanguageTool
[duplication] ~66-~66: Možný preklep: zopakovali ste slovo
Context: ...otli brotli Callouts callouts CCIP cdef Celestia Celestia's chainid Chainlink chainlist Chainstac...(WORD_REPEAT_RULE)
276-276
: New word "outfile" added in alphabetical order.The word "outfile" has been properly added to the word list in alphabetical order, correctly positioned between "opstack" and "Pausability".
445-445
: New word "workdir" added in alphabetical order.The word "workdir" has been properly added to the word list in alphabetical order, correctly positioned between "vmodule" and "xlarge".
pages/operators/chain-operators/tools/op-deployer.mdx (16)
20-20
: Clear introduction to op-deployer's purpose and functionality.The introduction effectively explains the Terraform-like approach of op-deployer and its purpose for deploying standard chains using Superchain contracts.
24-59
: Well-structured installation instructions with two clearly defined options.The installation section now provides comprehensive guidance with two installation methods (pre-built binaries and building from source), including step-by-step instructions and verification steps for each approach.
🧰 Tools
🪛 LanguageTool
[uncategorized] ~48-~48: You might be missing the article “the” here.
Context: ...git`. After installing all of that, run following: ```bash git clone https://github.com...(AI_EN_LECTOR_MISSING_DETERMINER_THE)
63-65
: Helpful gas cost callout for deployers.The added callout provides important practical information about gas costs for deployment, helping chain operators prepare adequately with sufficient funds.
79-89
: Improved init command documentation with workdir explanation.The documentation now clearly explains the --workdir flag and its purpose, along with guidance on customizing the directory name.
100-105
: Comprehensive intent.toml file configuration details with proper linking to L1 contracts versions.The example intent.toml file now includes clear annotations for key configuration values, particularly for the contracts locator versions.
134-170
: Excellent structured explanation of all intent.toml configuration fields.This new section provides a comprehensive reference for all configuration options, organized into logical sections (global configuration, superchain roles, chain-specific configuration, and chain roles) with clear descriptions of each parameter's purpose.
🧰 Tools
🪛 LanguageTool
[uncategorized] ~140-~140: Loose punctuation mark.
Context: ...nfiguration:** *deploymentStrategy
: Used to deploy both to live chains and ...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~141-~141: Loose punctuation mark.
Context: ...elive
andgenesis
. *configType
: Type of configuration to use ("standard...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~149-~149: Loose punctuation mark.
Context: ...perchain roles:** *proxyAdminOwner
: Address that can upgrade Superchain-wid...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~155-~155: Loose punctuation mark.
Context: ...hain-specific configuration:** *id
: Unique identifier for your chain * `b...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~163-~163: Loose punctuation mark.
Context: ...Chain roles:* *l1ProxyAdminOwner
: Address authorized to update the L1 Pro...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~165-~165: Loose punctuation mark.
Context: ...n owner address. *systemConfigOwner
: Address authorized to change values in ...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~169-~169: Loose punctuation mark.
Context: ...aultdisputegame) on L1. *challenger
: Address Account which can interact with...(UNLIKELY_OPENING_PUNCTUATION)
171-235
: Detailed guidance on working with contract artifacts and locator schemes.The new section thoroughly explains the different methods for providing contract artifacts, including local files, tagged artifacts, and contract locator schemes (tag://, file://, http://), with examples and important warnings.
🧰 Tools
🪛 LanguageTool
[uncategorized] ~216-~216: You might be missing the article “the” here.
Context: ...file://
- Points to a directory on local disk containing the artifacts. This...(AI_EN_LECTOR_MISSING_DETERMINER_THE)
256-278
: Expanded apply command documentation with deployment targets.The documentation now clearly explains the different deployment targets (live, genesis, calldata, noop) and their required parameters, providing users with more flexibility in how they deploy.
🧰 Tools
🪛 LanguageTool
[uncategorized] ~272-~272: Loose punctuation mark.
Context: ...ecifies where to deploy: *live
: Deploys directly to a live L1 network. ...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~273-~273: Loose punctuation mark.
Context: ...land
-private-key. *
genesis`: Generates an L1 genesis file for local ...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~274-~274: Loose punctuation mark.
Context: ...sting or development. *calldata
: Produces calldata for multisig wallets,...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~275-~275: Loose punctuation mark.
Context: ...bling offline deployment. *noop
: Performs a dry-run without actual deplo...(UNLIKELY_OPENING_PUNCTUATION)
279-313
: New verify command documentation with examples and options.The addition of the verify command documentation helps users complete the deployment workflow by verifying contract code on block explorers, with clear examples and parameter explanations.
🧰 Tools
🪛 LanguageTool
[uncategorized] ~279-~279: Loose punctuation mark.
Context: ...t best fits your use case. ###verify
: verify contract source code on block ex...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~294-~294: Loose punctuation mark.
Context: ... ### Common options: *-l1-rpc-url
: RPC URL for the L1 chain * `-ethersca...(UNLIKELY_OPENING_PUNCTUATION)
323-335
: Updated inspect command examples with clearer output file redirections.The inspect command examples now show how to redirect output to files, which is important for generating chain artifacts for the Superchain Registry.
339-349
: Clear bootstrap process overview with step-by-step explanation.The new bootstrap process overview section provides a high-level understanding of the four key steps needed to initialize a new superchain, helping users understand the overall workflow before diving into specific commands.
🧰 Tools
🪛 LanguageTool
[style] ~339-~339: Consider using a different adverb to strengthen your wording.
Context: ...ds are essential when you're setting up a completely new superchain environment rather than ...(COMPLETELY_ENTIRELY)
[style] ~347-~347: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...perchain configuration contracts. 3. Deploy implementations (`bootstrap implement...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~348-~348: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...acts needed for the dispute game. 4. Deploy validator (bootstrap validator
): De...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
350-398
: Comprehensive bootstrap proxy command documentation with parameter table.The bootstrap proxy command documentation is well-structured with a clear command usage example, parameter table with descriptions, examples, and expected output format.
400-464
: Detailed bootstrap superchain command documentation with parameter table.The bootstrap superchain command section provides complete information on initializing the core superchain configuration contracts, with thorough parameter descriptions and examples.
466-553
: Comprehensive bootstrap implementations command documentation with MIPS version explanation.This section effectively documents the bootstrap implementations command, including a detailed explanation of the MIPS version parameter (MIPS32 vs MIPS64) and its implications for fault proofs, which is critical information for operators.
490-492
: Clear explanation of MIPS version options for the fault proof system.The documentation clearly explains the MIPS version parameter and its two options (1 for MIPS32, 2 for MIPS64) with their implications, which is crucial information for chain operators making deployment decisions.
504-512
: Excellent detailed explanation of MIPS version differences.The dedicated section on MIPS version options provides valuable context about the differences between MIPS32 and MIPS64, helping operators make an informed choice with a clear recommendation for new deployments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (11)
pages/operators/chain-operators/tools/op-deployer.mdx (11)
24-26
: Clarify installation phrasing and heading case.
- Instead of "a couple of ways", use "two ways" for precision.
- Update the H3 to sentence case:
### Option 1: download pre-built binary
45-49
: Fix heading sentence case and improve grammar.
- Change the H3 to sentence case:
- ### Option 2: Build from source (Recommended) + ### Option 2: build from source (recommended)- Revise the setup instruction for clarity:
- After installing all of that, run following: + After installing these prerequisites, run the following command:
63-65
: Avoid first-person pronouns & tighten spacing.
- Replace "We recommend ensuring your deployer wallet..." with an impersonal or passive construction, for example:
Ensure your deployer wallet has a buffer of at least 1.5 to 3.5 ETH, depending on gas prices and configuration.
- Remove the extra space in "1.5 to 3.5 ETH".
87-90
: Correct misplaced space before punctuation.
In the sentence:You can name this directory anything you like , `.deployer` is just an example.remove the space before the comma:
- anything you like , `.deployer` + anything you like, `.deployer`
100-105
: Add space before inline comments in TOML.
TOML style prefers a space before the#
. For example:-deploymentStrategy = "live" +deploymentStrategy = "live" # e.g. live or genesis -l1ChainID = 11155111# The chain ID of Sepolia (L1). +l1ChainID = 11155111 # The chain ID of Sepolia (L1).Apply similar spacing to
fundDevAccounts
,l1ContractsLocator
, andl2ContractsLocator
.
134-134
: Wrapintent.toml
in backticks.
Headings should format filenames and file extensions as code:- ### Understanding the intent.toml fields + ### Understanding the `intent.toml` fields
281-281
: Rephrase heading for consistency and clarity.
Use sentence-case and remove the colon duplication:- ### `verify`: verify contract source code on block explorers + ### Verify contract source code on block explorers🧰 Tools
🪛 LanguageTool
[uncategorized] ~281-~281: Loose punctuation mark.
Context: ...t best fits your use case. ###verify
: verify contract source code on block ex...(UNLIKELY_OPENING_PUNCTUATION)
303-305
: Avoid contractions.
Use the full form "do not":- You don't need to specify a --workdir—op-deployer will automatically look... + You do not need to specify `--workdir`; `op-deployer` will automatically look...
316-316
: Standardize command headings.
Align with other sections by removing backticks and using sentence-case:- ### `inspect`: generate genesis files and chain information + ### Inspect: generate genesis files and chain information🧰 Tools
🪛 LanguageTool
[uncategorized] ~316-~316: Loose punctuation mark.
Context: ...UR_ETHERSCAN_API_KEY ``` ###inspect
: generate genesis files and chain inform...(UNLIKELY_OPENING_PUNCTUATION)
341-341
: Remove redundant adverb.
The word "completely" is unnecessary. For example:- `op-deployer` provides a set of bootstrap commands specifically designed for initializing a completely new superchain... + `op-deployer` provides a set of bootstrap commands specifically designed for initializing a new superchain...🧰 Tools
🪛 LanguageTool
[style] ~341-~341: Consider using a different adverb to strengthen your wording.
Context: ...ds are essential when you're setting up a completely new superchain environment rather than ...(COMPLETELY_ENTIRELY)
432-433
: Avoid linking CLI flags directly in parameter names.
Instead of[--guardian](https://...)
, format the flag as code and move the link into the description:| --guardian | Address authorized to pause L1 withdrawals from contracts, blacklist dispute games, and set the respected game type. See [details](https://...) | Yes | 0x3456...cdef |
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
pages/operators/chain-operators/tools/op-deployer.mdx
(6 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`**/*.mdx`: "ALWAYS review Markdown content THOROUGHLY with the following criteria: - First, check the frontmatter section at the top of the file: 1. For regular pages, ensure AL...
**/*.mdx
: "ALWAYS review Markdown content THOROUGHLY with the following criteria:
- First, check the frontmatter section at the top of the file:
- For regular pages, ensure ALL these fields are present and not empty:
--- title: [non-empty] lang: [non-empty] description: [non-empty] topic: [non-empty] personas: [non-empty array] categories: [non-empty array] content_type: [valid type] ---
- For landing pages (index.mdx or files with ), only these fields are required:
--- title: [non-empty] lang: [non-empty] description: [non-empty] topic: [non-empty] ---
- If any required fields are missing or empty, comment:
'This file appears to be missing required metadata. Please check keywords.config.yaml for valid options and add the required fields manually. You can validate your changes by running:pnpm validate-metadata ```'
- Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
- Avoid gender-specific language and use the imperative form.
- Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
- Ensure proper nouns are capitalized in sentences.
- Apply the Oxford comma.
- Use proper title case for buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
- Use correct spelling and grammar at all times (IMPORTANT).
- For H1, H2, and H3 headers:
- Use sentence case, capitalizing only the first word.
- Preserve the capitalization of proper nouns, technical terms, and acronyms as defined in the 'nouns.txt' file located in the root directory of the project.
- Do not automatically lowercase words that appear in the 'nouns.txt' file, regardless of their position in the header.
- Flag any headers that seem to inconsistently apply these rules for manual review.
- When reviewing capitalization, always refer to the 'nouns.txt' file for the correct capitalization of proper nouns and technical terms specific to the project.
"
pages/operators/chain-operators/tools/op-deployer.mdx
🪛 LanguageTool
pages/operators/chain-operators/tools/op-deployer.mdx
[uncategorized] ~140-~140: Loose punctuation mark.
Context: ...nfiguration:** * deploymentStrategy
: Used to deploy both to live chains and ...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~141-~141: Loose punctuation mark.
Context: ...e live
and genesis
. * configType
: Type of configuration to use ("standard...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~149-~149: Loose punctuation mark.
Context: ...perchain roles:** * proxyAdminOwner
: Address that can upgrade Superchain-wid...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~155-~155: Loose punctuation mark.
Context: ...hain-specific configuration:** * id
: Unique identifier for your chain * `b...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~163-~163: Loose punctuation mark.
Context: ...Chain roles:* * l1ProxyAdminOwner
: Address authorized to update the L1 Pro...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~165-~165: Loose punctuation mark.
Context: ...n owner address. * systemConfigOwner
: Address authorized to change values in ...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~169-~169: Loose punctuation mark.
Context: ...aultdisputegame) on L1. * challenger
: Address Account which can interact with...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~274-~274: Loose punctuation mark.
Context: ...ecifies where to deploy: * live
: Deploys directly to a live L1 network. ...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~275-~275: Loose punctuation mark.
Context: ...land
-private-key. *
genesis`: Generates an L1 genesis file for local ...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~276-~276: Loose punctuation mark.
Context: ...sting or development. * calldata
: Produces calldata for multisig wallets,...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~277-~277: Loose punctuation mark.
Context: ...bling offline deployment. * noop
: Performs a dry-run without actual deplo...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~281-~281: Loose punctuation mark.
Context: ...t best fits your use case. ### verify
: verify contract source code on block ex...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~296-~296: Loose punctuation mark.
Context: ... ### Common options: * -l1-rpc-url
: RPC URL for the L1 chain * `-ethersca...
(UNLIKELY_OPENING_PUNCTUATION)
[style] ~341-~341: Consider using a different adverb to strengthen your wording.
Context: ...ds are essential when you're setting up a completely new superchain environment rather than ...
(COMPLETELY_ENTIRELY)
[style] ~349-~349: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...perchain configuration contracts. 3. Deploy implementations (`bootstrap implement...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~350-~350: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...acts needed for the dispute game. 4. Deploy validator (bootstrap validator
): De...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: Redirect rules - docs-optimism
- GitHub Check: Header rules - docs-optimism
- GitHub Check: Pages changed - docs-optimism
- GitHub Check: pr-workflow
🔇 Additional comments (1)
pages/operators/chain-operators/tools/op-deployer.mdx (1)
1-14
: Frontmatter metadata is complete.
All required fields (title, lang, description, content_type, topic, personas, categories) are present and non-empty. Nice work aligning with the metadata requirements.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (5)
pages/operators/chain-operators/tools/op-deployer.mdx (5)
20-20
: Hyphenate compound adjective for clarity.In the intro sentence, “Superchain wide contracts” should be hyphenated as Superchain-wide when used as a compound adjective.
Suggestion:
- In its current state, it is intended to deploy new standard chains that utilize the Superchain wide contracts. + In its current state, it is intended to deploy new standard chains that utilize the Superchain-wide contracts.
26-26
: Use sentence case in headers.H3 headings should use sentence case, capitalizing only the first word (and proper nouns). Update this header to:
- ### Option 1: Download pre-built binary + ### Option 1: download pre-built binary
38-39
: Imperative step phrasing is acceptable.Steps 4 and 5 use clear instructions. If you’d like, you could rephrase step 5 for parallelism (e.g., “Verify installation by running…”), but this is optional.
45-45
: Use sentence case in headers.Apply the same sentence-case rule here:
- ### Option 2: Build from source (Recommended) + ### Option 2: build from source (recommended)
47-48
: Add missing article for clarity.The phrase “run following:” should read “run the following:”. For example:
- After installing all of that, run following: + After installing all of that, run the following:🧰 Tools
🪛 LanguageTool
[uncategorized] ~48-~48: Possible missing article found.
Context: ...git`. After installing all of that, run following: ```bash git clone https://github.com...(AI_HYDRA_LEO_MISSING_THE)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
pages/operators/chain-operators/tools/op-deployer.mdx
(6 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`**/*.mdx`: "ALWAYS review Markdown content THOROUGHLY with the following criteria: - First, check the frontmatter section at the top of the file: 1. For regular pages, ensure AL...
**/*.mdx
: "ALWAYS review Markdown content THOROUGHLY with the following criteria:
- First, check the frontmatter section at the top of the file:
- For regular pages, ensure ALL these fields are present and not empty:
--- title: [non-empty] lang: [non-empty] description: [non-empty] topic: [non-empty] personas: [non-empty array] categories: [non-empty array] content_type: [valid type] ---
- For landing pages (index.mdx or files with ), only these fields are required:
--- title: [non-empty] lang: [non-empty] description: [non-empty] topic: [non-empty] ---
- If any required fields are missing or empty, comment:
'This file appears to be missing required metadata. Please check keywords.config.yaml for valid options and add the required fields manually. You can validate your changes by running:pnpm validate-metadata ```'
- Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
- Avoid gender-specific language and use the imperative form.
- Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
- Ensure proper nouns are capitalized in sentences.
- Apply the Oxford comma.
- Use proper title case for buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
- Use correct spelling and grammar at all times (IMPORTANT).
- For H1, H2, and H3 headers:
- Use sentence case, capitalizing only the first word.
- Preserve the capitalization of proper nouns, technical terms, and acronyms as defined in the 'nouns.txt' file located in the root directory of the project.
- Do not automatically lowercase words that appear in the 'nouns.txt' file, regardless of their position in the header.
- Flag any headers that seem to inconsistently apply these rules for manual review.
- When reviewing capitalization, always refer to the 'nouns.txt' file for the correct capitalization of proper nouns and technical terms specific to the project.
"
pages/operators/chain-operators/tools/op-deployer.mdx
🪛 LanguageTool
pages/operators/chain-operators/tools/op-deployer.mdx
[uncategorized] ~48-~48: Possible missing article found.
Context: ...git`. After installing all of that, run following: ```bash git clone https://github.com...
(AI_HYDRA_LEO_MISSING_THE)
[uncategorized] ~141-~141: Loose punctuation mark.
Context: ...nfiguration:** * deploymentStrategy
: Used to deploy both to live chains and ...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~142-~142: Loose punctuation mark.
Context: ...e live
and genesis
. * configType
: Type of configuration to use ("standard...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~150-~150: Loose punctuation mark.
Context: ...perchain roles:** * proxyAdminOwner
: Address that can upgrade Superchain-wid...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~156-~156: Loose punctuation mark.
Context: ...hain-specific configuration:** * id
: Unique identifier for your chain * `b...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~164-~164: Loose punctuation mark.
Context: ...Chain roles:* * l1ProxyAdminOwner
: Address authorized to update the L1 Pro...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~166-~166: Loose punctuation mark.
Context: ...n owner address. * systemConfigOwner
: Address authorized to change values in ...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~170-~170: Loose punctuation mark.
Context: ...aultdisputegame) on L1. * challenger
: Address Account which can interact with...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~277-~277: Loose punctuation mark.
Context: ...ecifies where to deploy: * live
: Deploys directly to a live L1 network. ...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~278-~278: Loose punctuation mark.
Context: ...land
-private-key. *
genesis`: Generates an L1 genesis file for local ...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~279-~279: Loose punctuation mark.
Context: ...sting or development. * calldata
: Produces calldata for multisig wallets,...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~280-~280: Loose punctuation mark.
Context: ...bling offline deployment. * noop
: Performs a dry-run without actual deplo...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~284-~284: Loose punctuation mark.
Context: ...t best fits your use case. ### verify
: verify contract source code on block ex...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~299-~299: Loose punctuation mark.
Context: ... Common options: * -l1-rpc-url
: RPC URL for the L1 chain * `-ethersca...
(UNLIKELY_OPENING_PUNCTUATION)
[style] ~344-~344: Consider using a different adverb to strengthen your wording.
Context: ...ds are essential when you're setting up a completely new superchain environment rather than ...
(COMPLETELY_ENTIRELY)
[uncategorized] ~344-~344: Possible missing comma found.
Context: ... setting up a completely new superchain environment rather than deploying a new chain on an...
(AI_HYDRA_LEO_MISSING_COMMA)
[style] ~352-~352: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...perchain configuration contracts. 3. Deploy implementations (`bootstrap implement...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~353-~353: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...acts needed for the dispute game. 4. Deploy validator (bootstrap validator
): De...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - docs-optimism
- GitHub Check: Header rules - docs-optimism
- GitHub Check: Pages changed - docs-optimism
🔇 Additional comments (6)
pages/operators/chain-operators/tools/op-deployer.mdx (6)
24-24
: Installation intro reads well.Clear and concise description of the installation options. No changes needed here.
28-28
: Installation step description is clear.The sentence describing how to download the binary is well written.
30-33
: Numeric steps are consistent.The “1. Go to”, “2. Find”, “3. Under … download” steps are clear and correctly formatted.
34-36
: Sub-bullets for OS binaries look good.Listing platform-specific binaries is clear and concise.
41-43
: Code snippet formatting is correct.The bash block is properly fenced and displays the version check command.
50-59
: Source-build instructions are well laid out.The sequence of commands under the bash block is clear and accurate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments, but going ahead w/ an approval since they're small. Feel free to merge after fixing them!
Co-authored-by: Bradley Camacho <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nit suggestions. Great work on this @krofax, this will really be helpful for all the questions people have around the bootstrap command
Co-authored-by: soyboy <[email protected]>
Co-authored-by: soyboy <[email protected]>
Co-authored-by: soyboy <[email protected]>
Co-authored-by: soyboy <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (10)
pages/operators/chain-operators/tools/op-deployer.mdx (10)
28-29
: Grammar: missing article
Change "run following:" to "run the following:" for correct English grammar.🧰 Tools
🪛 LanguageTool
[uncategorized] ~29-~29: Possible missing article found.
Context: ...git`. After installing all of that, run following: ```bash git clone https://github.com...(AI_HYDRA_LEO_MISSING_THE)
100-105
: TOML snippet formatting
The inline comments in the example TOML file are very long. Consider separating lengthy comments onto their own lines or ensuring a space before#
to improve readability:- l2ContractsLocator = "tag://op-contracts/v1.7.0-beta.1+l2-contracts"# L2 smart contracts versions# Delete... + l2ContractsLocator = "tag://op-contracts/v1.7.0-beta.1+l2-contracts" # L2 smart contracts versions + # Delete this table if you are using the shared Superchain...
113-115
: TOML comment case
Ensure comment text uses sentence case and ends with a period. For example:- # Your chain's ID, encoded as a 32-byte hex string + # Your chain’s ID, encoded as a 32-byte hex string.
122-122
: Sentence case in comments
The comment for the roles section should follow sentence case and punctuation conventions. e.g.:- # Various ownership roles for your chain. When you use op-deployer init, these roles are generated using the# test... junk mnemonic. You should replace these... + # Various ownership roles for your chain. When you run `op-deployer init`, these roles are generated using the test mnemonic. Replace them...
176-178
: Artifact locator description
The description ofartifacts-locator
is clear and concise; consider adding an example usage inline for quick reference.
198-198
: Local path usage instructions
The guidance on using the local path is concise; consider adding an explicit backtick around the path placeholder for consistency.
245-246
: TOML overrides formatting
Indent the override and wrap the key in backticks for consistency. For example:- [globalDeployOverrides] - l2BlockTime = 1# 1s L2blockTime ... + [globalDeployOverrides] + `l2BlockTime` = 1 # 1s L2 block time also standard; defaults to 2s
343-343
: Word choice
Consider replacing "completely" with "entirely" for stronger, more concise wording:- essential when you're setting up a completely new superchain... + essential when you're setting up an entirely new superchain...🧰 Tools
🪛 LanguageTool
[style] ~343-~343: Consider using a different adverb to strengthen your wording.
Context: ...ds are essential when you're setting up a completely new superchain target environment rathe...(COMPLETELY_ENTIRELY)
361-367
: CLI flags formatting
Wrap all CLI flags in backticks within the example for consistent styling. E.g.,--l1-rpc-url
,--private-key
,--artifacts-locator
,--proxy-owner
, and--outfile
.
372-380
: Parameter table formatting
Wrap parameter names in backticks in the table and ensure each description follows sentence case. For instance:- | --l1-rpc-url | RPC URL for the L1 chain | Yes | example | + | `--l1-rpc-url` | RPC URL for the L1 chain. | Yes | `https://...` |
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
pages/operators/chain-operators/tools/op-deployer.mdx
(6 hunks)words.txt
(3 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`**/*.mdx`: "ALWAYS review Markdown content THOROUGHLY with the following criteria: - First, check the frontmatter section at the top of the file: 1. For regular pages, ensure AL...
**/*.mdx
: "ALWAYS review Markdown content THOROUGHLY with the following criteria:
- First, check the frontmatter section at the top of the file:
- For regular pages, ensure ALL these fields are present and not empty:
--- title: [non-empty] lang: [non-empty] description: [non-empty] topic: [non-empty] personas: [non-empty array] categories: [non-empty array] content_type: [valid type] ---
- For landing pages (index.mdx or files with ), only these fields are required:
--- title: [non-empty] lang: [non-empty] description: [non-empty] topic: [non-empty] ---
- If any required fields are missing or empty, comment:
'This file appears to be missing required metadata. Please check keywords.config.yaml for valid options and add the required fields manually. You can validate your changes by running:pnpm validate-metadata ```'
- Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
- Avoid gender-specific language and use the imperative form.
- Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
- Ensure proper nouns are capitalized in sentences.
- Apply the Oxford comma.
- Use proper title case for buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
- Use correct spelling and grammar at all times (IMPORTANT).
- For H1, H2, and H3 headers:
- Use sentence case, capitalizing only the first word.
- Preserve the capitalization of proper nouns, technical terms, and acronyms as defined in the 'nouns.txt' file located in the root directory of the project.
- Do not automatically lowercase words that appear in the 'nouns.txt' file, regardless of their position in the header.
- Flag any headers that seem to inconsistently apply these rules for manual review.
- When reviewing capitalization, always refer to the 'nouns.txt' file for the correct capitalization of proper nouns and technical terms specific to the project.
"
pages/operators/chain-operators/tools/op-deployer.mdx
🪛 LanguageTool
pages/operators/chain-operators/tools/op-deployer.mdx
[uncategorized] ~29-~29: Possible missing article found.
Context: ...git`. After installing all of that, run following: ```bash git clone https://github.com...
(AI_HYDRA_LEO_MISSING_THE)
[uncategorized] ~141-~141: Loose punctuation mark.
Context: ...nfiguration:** * deploymentStrategy
: Used to deploy both to live chains and ...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~142-~142: Loose punctuation mark.
Context: ...e live
and genesis
. * configType
: Type of configuration to use ("standard...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~150-~150: Loose punctuation mark.
Context: ...perchain roles:** * proxyAdminOwner
: Address that can upgrade Superchain-wid...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~156-~156: Loose punctuation mark.
Context: ...hain-specific configuration:** * id
: Unique identifier for your chain * `b...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~164-~164: Loose punctuation mark.
Context: ...Chain roles:* * l1ProxyAdminOwner
: Address authorized to update the L1 Pro...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~166-~166: Loose punctuation mark.
Context: ...n owner address. * systemConfigOwner
: Address authorized to change values in ...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~170-~170: Loose punctuation mark.
Context: ...aultdisputegame) on L1. * challenger
: Address Account which can interact with...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~276-~276: Loose punctuation mark.
Context: ...ecifies where to deploy: * live
: Deploys directly to a live L1 network. ...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~277-~277: Loose punctuation mark.
Context: ...land
-private-key. *
genesis`: Generates an L1 genesis file for local ...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~278-~278: Loose punctuation mark.
Context: ...sting or development. * calldata
: Produces calldata for multisig wallets,...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~279-~279: Loose punctuation mark.
Context: ...bling offline deployment. * noop
: Performs a dry-run without actual deplo...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~283-~283: Loose punctuation mark.
Context: ...t best fits your use case. ### verify
: verify contract source code on block ex...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~298-~298: Loose punctuation mark.
Context: ... Common options: * -l1-rpc-url
: RPC URL for the L1 chain * `-ethersca...
(UNLIKELY_OPENING_PUNCTUATION)
[style] ~343-~343: Consider using a different adverb to strengthen your wording.
Context: ...ds are essential when you're setting up a completely new superchain target environment rathe...
(COMPLETELY_ENTIRELY)
[style] ~351-~351: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...perchain configuration contracts. 3. Deploy implementations (`bootstrap implement...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~352-~352: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...acts needed for the dispute game. 4. Deploy validator (bootstrap validator
): De...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
words.txt
[duplication] ~26-~26: Možný preklep: zopakovali ste slovo
Context: ...elay autorelay autorelayer basefee bcde Betanet betanet Betanets betanets BGEZ BGTZ Biconomy BL...
(WORD_REPEAT_RULE)
[duplication] ~66-~66: Možný preklep: zopakovali ste slovo
Context: ...otli brotli Callouts callouts CCIP cdef Celestia Celestia's chainid Chainlink chainlist Chainstac...
(WORD_REPEAT_RULE)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - docs-optimism
- GitHub Check: Header rules - docs-optimism
- GitHub Check: Pages changed - docs-optimism
🔇 Additional comments (12)
words.txt (3)
26-26
: New term "bcde" added correctly
The entry for "bcde" is in the correct alphabetical position and uses lowercase as required.🧰 Tools
🪛 LanguageTool
[duplication] ~26-~26: Možný preklep: zopakovali ste slovo
Context: ...elay autorelay autorelayer basefee bcde Betanet betanet Betanets betanets BGEZ BGTZ Biconomy BL...(WORD_REPEAT_RULE)
66-66
: New term "cdef" added correctly
The entry for "cdef" is in the correct alphabetical position and uses lowercase as required.🧰 Tools
🪛 LanguageTool
[duplication] ~66-~66: Možný preklep: zopakovali ste slovo
Context: ...otli brotli Callouts callouts CCIP cdef Celestia Celestia's chainid Chainlink chainlist Chainstac...(WORD_REPEAT_RULE)
276-276
: New term "outfile" added correctly
The entry for "outfile" is in the correct alphabetical position and uses lowercase as required.pages/operators/chain-operators/tools/op-deployer.mdx (9)
1-14
: Frontmatter validation
All required metadata fields (title
,lang
,description
,topic
,personas
,categories
,content_type
) are present and non-empty.
20-20
: Introduction paragraph clarity
The description clearly explains the purpose ofop-deployer
and uses accurate technical comparisons.
24-26
: Installation section structure
The installation options are well-structured and follow sentence case for headers.
134-134
: Section header style
The header uses sentence case and preserves proper nouns. This aligns with guidelines.
174-174
: Section header style
The "Working with artifacts" header follows sentence case and is clear.
184-187
: Code snippet clarity
The example commands for cloning and checking out a specific version are correctly formatted.
193-196
: Build instructions
The build commands are clear and follow proper formatting.
201-204
: Tagged artifacts explanation
The explanation and examples for tagged artifacts are accurate.
206-207
: Tagged artifacts code snippet
The code snippet demonstrating thetag://
usage is well-formatted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (7)
pages/operators/chain-operators/tools/op-deployer.mdx (7)
20-20
: Hyphenate "Superchain-wide" for consistency
The phrase "Superchain wide contracts" should be hyphenated as "Superchain-wide contracts" to reflect a compound adjective.
Apply this diff:- In its current state, it is intended to deploy new standard chains that utilize the Superchain wide contracts. + In its current state, it is intended to deploy new standard chains that utilize the Superchain-wide contracts.
24-27
: Use sentence case for heading and "(recommended)"
Headings should use sentence case: only the first word and proper nouns are capitalized. Also, the parenthetical "(Recommended)" should be lowercase.- There are a couple of ways to install `op-deployer`: + There are a couple of ways to install `op-deployer`: ### Option 1: Build from source (Recommended) +### Option 1: Build from source (recommended)
95-96
: Clarify and correct mnemonic reference
The text "test... junk" is unclear and has an extra space. It’s better to combine it and keep the warning on one line for clarity.- Do not use the default addresses in the intent for a production chain! They are generated from the `test... junk` - mnemonic. **Any funds they hold will be stolen on a live chain.** + Do not use the default addresses in the intent for a production chain! They are generated from the `test...junk` mnemonic. **Any funds they hold will be stolen on a live chain.**
168-171
: Fix redundant "Address Account" phrasing
The bullet forchallenger
repeats "Address Account". It should read as an authorized role.- * `challenger`: Address Account which can interact with existing permissioned dispute games + * `challenger`: Address authorized to interact with existing permissioned dispute games🧰 Tools
🪛 LanguageTool
[uncategorized] ~170-~170: Loose punctuation mark.
Context: ...ltdisputegame) on L1. *challenger
: Address Account which can interact with...(UNLIKELY_OPENING_PUNCTUATION)
282-282
: Capitalize description in verify heading
For consistency with other command headings, capitalize the description after the colon.- ### `verify`: verify contract source code on block explorers + ### `verify`: Verify contract source code on block explorers🧰 Tools
🪛 LanguageTool
[uncategorized] ~282-~282: Loose punctuation mark.
Context: ...t best fits your use case. ###verify
: verify contract source code on block ex...(UNLIKELY_OPENING_PUNCTUATION)
343-343
: Consider rephrasing to avoid "completely"
The adverb "completely" is weak. You might strengthen the sentence:When bootstrapping a new superchain target, you typically need to follow this process:
→
When bootstrapping a new superchain target, you generally follow these four steps:
This removes "completely" and tightens the prose.
🧰 Tools
🪛 LanguageTool
[style] ~343-~343: Consider using a different adverb to strengthen your wording.
Context: ...ds are essential when you're setting up a completely new superchain target environment rathe...(COMPLETELY_ENTIRELY)
375-377
: Correct "e.g" abbreviation to "e.g."
The abbreviation “e.g” should include a period and, when followed by a comma, format as “e.g.,”.- | --artifacts-locator | Location of contract artifacts | Yes | Contract artifacts location, can be found in `intent.toml`, e.g tag://op-contracts/v3.0.0-rc.2 | + | --artifacts-locator | Location of contract artifacts | Yes | Contract artifacts location, can be found in `intent.toml`, e.g., tag://op-contracts/v3.0.0-rc.2 | - | --proxy-owner | Address that will own the proxy | Yes | e.g Your `proxyAdminOwner` from your `intent.toml` | + | --proxy-owner | Address that will own the proxy | Yes | e.g., Your `proxyAdminOwner` from your `intent.toml` |🧰 Tools
🪛 LanguageTool
[uncategorized] ~376-~376: The abbreviation “e.g.” (= for example) requires two periods.
Context: ...ocation, can be found inintent.toml
, e.g tag://op-contracts/v3.0.0-rc.2 | | --pr...(E_G)
[uncategorized] ~377-~377: The abbreviation “e.g.” (= for example) requires two periods.
Context: ...hat will own the proxy | Yes | e.g YourproxyAdminOwner
from your `inten...(E_G)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
pages/operators/chain-operators/tools/op-deployer.mdx
(4 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`**/*.mdx`: "ALWAYS review Markdown content THOROUGHLY with the following criteria: - First, check the frontmatter section at the top of the file: 1. For regular pages, ensure AL...
**/*.mdx
: "ALWAYS review Markdown content THOROUGHLY with the following criteria:
- First, check the frontmatter section at the top of the file:
- For regular pages, ensure ALL these fields are present and not empty:
--- title: [non-empty] lang: [non-empty] description: [non-empty] topic: [non-empty] personas: [non-empty array] categories: [non-empty array] content_type: [valid type] ---
- For landing pages (index.mdx or files with ), only these fields are required:
--- title: [non-empty] lang: [non-empty] description: [non-empty] topic: [non-empty] ---
- If any required fields are missing or empty, comment:
'This file appears to be missing required metadata. Please check keywords.config.yaml for valid options and add the required fields manually. You can validate your changes by running:pnpm validate-metadata ```'
- Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
- Avoid gender-specific language and use the imperative form.
- Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
- Ensure proper nouns are capitalized in sentences.
- Apply the Oxford comma.
- Use proper title case for buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
- Use correct spelling and grammar at all times (IMPORTANT).
- For H1, H2, and H3 headers:
- Use sentence case, capitalizing only the first word.
- Preserve the capitalization of proper nouns, technical terms, and acronyms as defined in the 'nouns.txt' file located in the root directory of the project.
- Do not automatically lowercase words that appear in the 'nouns.txt' file, regardless of their position in the header.
- Flag any headers that seem to inconsistently apply these rules for manual review.
- When reviewing capitalization, always refer to the 'nouns.txt' file for the correct capitalization of proper nouns and technical terms specific to the project.
"
pages/operators/chain-operators/tools/op-deployer.mdx
🪛 LanguageTool
pages/operators/chain-operators/tools/op-deployer.mdx
[uncategorized] ~69-~69: Loose punctuation mark.
Context: ...roken down into three steps: ### init
: configure your chain To get started wi...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~141-~141: Loose punctuation mark.
Context: ...iguration:** * deploymentStrategy
: Used to deploy both to live chains and ...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~142-~142: Loose punctuation mark.
Context: ...live
and genesis
. * configType
: Type of configuration to use ("standard...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~150-~150: Loose punctuation mark.
Context: ...rchain roles:** * proxyAdminOwner
: Address that can upgrade Superchain-wid...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~156-~156: Loose punctuation mark.
Context: ...in-specific configuration:** * id
: Unique identifier for your chain * ...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~164-~164: Loose punctuation mark.
Context: ...hain roles:** * l1ProxyAdminOwner
: Address authorized to update the L1 Pro...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~166-~166: Loose punctuation mark.
Context: ...owner address. * systemConfigOwner
: Address authorized to change values in ...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~170-~170: Loose punctuation mark.
Context: ...ltdisputegame) on L1. * challenger
: Address Account which can interact with...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~275-~275: Loose punctuation mark.
Context: ...ecifies where to deploy: * live
: Deploys directly to a live L1 network. ...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~276-~276: Loose punctuation mark.
Context: ...land
-private-key. *
genesis`: Generates an L1 genesis file for local ...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~277-~277: Loose punctuation mark.
Context: ...sting or development. * calldata
: Produces calldata for multisig wallets,...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~278-~278: Loose punctuation mark.
Context: ...bling offline deployment. * noop
: Performs a dry-run without actual deplo...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~282-~282: Loose punctuation mark.
Context: ...t best fits your use case. ### verify
: verify contract source code on block ex...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~297-~297: Loose punctuation mark.
Context: ... Common options: * -l1-rpc-url
: RPC URL for the L1 chain * `-ethersca...
(UNLIKELY_OPENING_PUNCTUATION)
[style] ~343-~343: Consider using a different adverb to strengthen your wording.
Context: ...ds are essential when you're setting up a completely new superchain target environment rathe...
(COMPLETELY_ENTIRELY)
[style] ~351-~351: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...perchain configuration contracts. 3. Deploy implementations (`bootstrap implement...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~352-~352: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...acts needed for the dispute game. 4. Deploy validator (bootstrap validator
): De...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[uncategorized] ~376-~376: The abbreviation “e.g.” (= for example) requires two periods.
Context: ...ocation, can be found in intent.toml
, e.g tag://op-contracts/v3.0.0-rc.2 | | --pr...
(E_G)
[uncategorized] ~377-~377: The abbreviation “e.g.” (= for example) requires two periods.
Context: ...hat will own the proxy | Yes | e.g Your proxyAdminOwner
from your `inten...
(E_G)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - docs-optimism
- GitHub Check: Header rules - docs-optimism
- GitHub Check: Pages changed - docs-optimism
🔇 Additional comments (1)
pages/operators/chain-operators/tools/op-deployer.mdx (1)
134-134
: H3 heading formatting is correct
The header "Understanding the intent.toml fields" follows sentence case and preserves proper nouns (intent.toml). LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (8)
pages/operators/chain-operators/tools/op-deployer.mdx (8)
20-20
: Use imperative mood instead of second-person narrative.
The guideline recommends an imperative style for instructions. Change “Like Terraform, you define a declarative config file…” to “Like Terraform, define a declarative config file calledintent
, then run the deploy command against your chain.”
24-26
: Adopt imperative tone and sentence-case headers.
- Rephrase “There are a couple of ways to install
op-deployer
:” to “Installop-deployer
using one of the following methods:”.- Update the H3 header to sentence case: “Option 1: build from source (recommended)”.
28-29
: Fix grammar and strengthen clarity.
- Change “After installing all of that, run following:” to “After installing these prerequisites, run the following command:”.
42-42
: Use sentence case for this header.
The H3 should read “Option 2: download pre-built binary” (only the first word capitalized, except proper nouns).
102-105
: Normalize inline comment formatting in the TOML snippet.
Ensure there’s a space before each#
and improve comment readability. For example:-l1ChainID = 11155111# The chain ID of Sepolia... +l1ChainID = 11155111 # The chain ID of Sepolia... -fundDevAccounts = true# Whether or not to fund dev accounts... +fundDevAccounts = true # Whether or not to fund dev accounts... -l2ContractsLocator = "..."+# L2 smart contracts versions# Delete this table... +l2ContractsLocator = "..."+ # L2 smart contracts versions + # Delete if using shared Superchain contracts on L1 or deploying your own SuperchainConfig/ProtocolVersions
134-134
: Wrap file name in code formatting.
Use backticks aroundintent.toml
in the header:### Understanding the `intent.toml` fields
244-245
: Improve comment spacing and phrasing in TOML.
Add a space before the#
and clarify the phrasing:-l2BlockTime = 1# 1s L2blockTime is also standard, op-deployer defaults to 2s +l2BlockTime = 1 # 1s L2 block time is standard; op-deployer defaults to 2s
344-345
: Consider rephrasing to avoid redundant adverbs and improve flow.
The sentence is a bit wordy. For example:
op-deployer
provides bootstrap commands for initializing a new superchain target on an L1 network. Use these when setting up a superchain environment from scratch.This removes “completely” and tightens the instruction.
🧰 Tools
🪛 LanguageTool
[style] ~344-~344: Consider using a different adverb to strengthen your wording.
Context: ...ds are essential when you're setting up a completely new superchain target environment rathe...(COMPLETELY_ENTIRELY)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
pages/operators/chain-operators/tools/op-deployer.mdx
(4 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`**/*.mdx`: "ALWAYS review Markdown content THOROUGHLY with the following criteria: - First, check the frontmatter section at the top of the file: 1. For regular pages, ensure AL...
**/*.mdx
: "ALWAYS review Markdown content THOROUGHLY with the following criteria:
- First, check the frontmatter section at the top of the file:
- For regular pages, ensure ALL these fields are present and not empty:
--- title: [non-empty] lang: [non-empty] description: [non-empty] topic: [non-empty] personas: [non-empty array] categories: [non-empty array] content_type: [valid type] ---
- For landing pages (index.mdx or files with ), only these fields are required:
--- title: [non-empty] lang: [non-empty] description: [non-empty] topic: [non-empty] ---
- If any required fields are missing or empty, comment:
'This file appears to be missing required metadata. Please check keywords.config.yaml for valid options and add the required fields manually. You can validate your changes by running:pnpm validate-metadata ```'
- Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
- Avoid gender-specific language and use the imperative form.
- Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
- Ensure proper nouns are capitalized in sentences.
- Apply the Oxford comma.
- Use proper title case for buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
- Use correct spelling and grammar at all times (IMPORTANT).
- For H1, H2, and H3 headers:
- Use sentence case, capitalizing only the first word.
- Preserve the capitalization of proper nouns, technical terms, and acronyms as defined in the 'nouns.txt' file located in the root directory of the project.
- Do not automatically lowercase words that appear in the 'nouns.txt' file, regardless of their position in the header.
- Flag any headers that seem to inconsistently apply these rules for manual review.
- When reviewing capitalization, always refer to the 'nouns.txt' file for the correct capitalization of proper nouns and technical terms specific to the project.
"
pages/operators/chain-operators/tools/op-deployer.mdx
🪛 LanguageTool
pages/operators/chain-operators/tools/op-deployer.mdx
[uncategorized] ~69-~69: Loose punctuation mark.
Context: ...roken down into three steps: ### init
: configure your chain To get started wi...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~141-~141: Loose punctuation mark.
Context: ...iguration:** * deploymentStrategy
: Used to deploy both to live chains and ...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~142-~142: Loose punctuation mark.
Context: ...live
and genesis
. * configType
: Type of configuration to use ("standard...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~150-~150: Loose punctuation mark.
Context: ...rchain roles:** * proxyAdminOwner
: Address that can upgrade Superchain-wid...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~156-~156: Loose punctuation mark.
Context: ...in-specific configuration:** * id
: Unique identifier for your chain * ...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~164-~164: Loose punctuation mark.
Context: ...hain roles:** * l1ProxyAdminOwner
: Address authorized to update the L1 Pro...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~166-~166: Loose punctuation mark.
Context: ...owner address. * systemConfigOwner
: Address authorized to change values in ...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~170-~170: Loose punctuation mark.
Context: ...ltdisputegame) on L1. * challenger
: Address Account which can interact with...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~275-~275: Loose punctuation mark.
Context: ...ecifies where to deploy: * live
: Deploys directly to a live L1 network. ...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~276-~276: Loose punctuation mark.
Context: ...land
-private-key. *
genesis`: Generates an L1 genesis file for local ...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~277-~277: Loose punctuation mark.
Context: ...sting or development. * calldata
: Produces calldata for multisig wallets,...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~278-~278: Loose punctuation mark.
Context: ...bling offline deployment. * noop
: Performs a dry-run without actual deplo...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~282-~282: Loose punctuation mark.
Context: ...t best fits your use case. ### verify
: verify contract source code on block ex...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~297-~297: Loose punctuation mark.
Context: ... Common options: * -l1-rpc-url
: RPC URL for the L1 chain * `-ethersca...
(UNLIKELY_OPENING_PUNCTUATION)
[style] ~344-~344: Consider using a different adverb to strengthen your wording.
Context: ...ds are essential when you're setting up a completely new superchain target environment rathe...
(COMPLETELY_ENTIRELY)
[style] ~352-~352: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...perchain configuration contracts. 3. Deploy implementations (`bootstrap implement...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~353-~353: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...acts needed for the dispute game. 4. Deploy validator (bootstrap validator
): De...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[uncategorized] ~377-~377: The abbreviation “e.g.” (= for example) requires two periods.
Context: ...ocation, can be found in intent.toml
, e.g tag://op-contracts/v3.0.0-rc.2 | | --pr...
(E_G)
[uncategorized] ~378-~378: The abbreviation “e.g.” (= for example) requires two periods.
Context: ...hat will own the proxy | Yes | e.g Your proxyAdminOwner
from your `inten...
(E_G)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - docs-optimism
- GitHub Check: Header rules - docs-optimism
- GitHub Check: Pages changed - docs-optimism
Description
This PR updates the documentation for op-deployer, a tool that simplifies the process of deploying OP Stack chains. The documentation provides comprehensive guidance on installation options, deployment workflows, and bootstrap processes for new superchains.
Changes
Added detailed installation instructions for both pre-built binaries and building from source
Expanded deployment usage section with clear explanations of the three-step process:
Added detailed explanation of intent.toml fields and configuration options
Included information about working with artifacts using various locator schemes
Enhanced bootstrap usage documentation with four key commands:
Added callouts for important considerations like gas costs and hardware wallet limitations
Included comprehensive command parameter tables for all bootstrap commands
Key Improvements
Tests
Additional context
Metadata
[DOCS] Add documentation for op-deployer intent file configuration #1505