-
Notifications
You must be signed in to change notification settings - Fork 260
Update fp-changes.mdx #730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updated viem update instructions
WalkthroughThe update in the Changes
Recent review detailsConfiguration used: .coderabbit.yaml Files selected for processing (1)
Additional context usedPath-based instructions (1)
LanguageTool
Additional comments not posted (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
✅ Deploy Preview for docs-optimism ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range and nitpick comments (3)
pages/builders/notices/fp-changes.mdx (3)
Line range hint
45-45
: Consider adding an article before "Most notable change".- Most notable change for developers is that withdrawals will have to be proven against the `rootClaim` of some dispute game rather than referencing an output in the `L2OutputOracle` contract. + The most notable change for developers is that withdrawals will have to be proven against the `rootClaim` of some dispute game rather than referencing an output in the `L2OutputOracle` contract.
Line range hint
46-46
: Insert a comma after "dispute game".- ...against the `rootClaim` of some dispute game rather than referencing an output in the `L2OutputOracle` contract. + ...against the `rootClaim` of some dispute game, rather than referencing an output in the `L2OutputOracle` contract.
Line range hint
21-21
: Consider using a more concise expression.- Withdrawals prior to the Fault Proofs upgrade must wait a 7-day challenge period before finalization. + Withdrawals before the Fault Proofs upgrade must wait a 7-day challenge period before finalization.
Updated viem update instructions
Updating Viem instructions to simply be update to latest (>2.9.0) version