-
Notifications
You must be signed in to change notification settings - Fork 260
Update to Fjord Fee Param Calculator #786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe recent update involves modifying a link to a fee parameter calculator in the guide related to using blobs for a chain. This change ensures better estimation of scalar values on the chain by directing users to a more appropriate URL for the fee parameter calculator. There are no changes to the declarations of exported or public entities. Changes
Recent review detailsConfiguration used: .coderabbit.yaml Files selected for processing (1)
Additional context usedPath-based instructions (1)
Additional comments not posted (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
✅ Deploy Preview for docs-optimism ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (9)
pages/builders/chain-operators/management/blobs.mdx (9)
Line range hint
1-7
: Ensure proper title case and consistent capitalization.
- Use proper title case for headers: "Using Blobs" should be "Using Blobs".
- Ensure consistent capitalization for proper nouns like "Ecotone".
- title: Using Blobs + title: Using Blobs
Line range hint
9-9
: Use proper title case for headers.The header "Using Blobs" should be in title case.
- # Using Blobs + # Using Blobs
Line range hint
11-12
: Avoid gender-specific language.Replace "This guide walks you through how to switch to using blobs for your chain after Ecotone is activated." with "This guide explains how to switch to using blobs for your chain after Ecotone is activated."
- This guide walks you through how to switch to using blobs for your chain after Ecotone is activated. + This guide explains how to switch to using blobs for your chain after Ecotone is activated.
Line range hint
17-17
: Use imperative form.Replace "This guide is intended for chains already upgraded to Ecotone." with "This guide is for chains already upgraded to Ecotone."
- This guide is intended for chains already upgraded to Ecotone. + This guide is for chains already upgraded to Ecotone.
Line range hint
45-45
: Use the Oxford comma.Add a comma after "your chain".
- Input the average transaction per day your chain is processing, the types of transactions that occur on your chain, the [`OP_BATCHER_MAX_CHANNEL_DURATION`](/builders/chain-operators/configuration/batcher#setting-your--op_batcher_max_channel_duration) you have parameterized on your `op-batcher`, and the target margin you wish to charge users on top of your L1 costs. + Input the average transaction per day your chain is processing, the types of transactions that occur on your chain, the [`OP_BATCHER_MAX_CHANNEL_DURATION`](/builders/chain-operators/configuration/batcher#setting-your--op_batcher_max_channel_duration) you have parameterized on your `op-batcher`, and the target margin you wish to charge users on top of your L1 costs.
Line range hint
45-45
: Use proper title case for links.Ensure that the link text "OP_BATCHER_MAX_CHANNEL_DURATION" is in title case.
- the [`OP_BATCHER_MAX_CHANNEL_DURATION`](/builders/chain-operators/configuration/batcher#setting-your--op_batcher_max_channel_duration) + the [`OP_BATCHER_MAX_CHANNEL_DURATION`](/builders/chain-operators/configuration/batcher#setting-your--op_batcher_max_channel_duration)
Line range hint
116-116
: Use proper title case for links.Ensure that the link text "Transaction Fees, Ecotone section" is in title case.
- For more details on fee scalar, see [Transaction Fees, Ecotone section](/stack/transactions/fees#ecotone). + For more details on fee scalar, see [Transaction Fees, Ecotone Section](/stack/transactions/fees#ecotone).
Line range hint
121-121
: Use proper title case for links.Ensure that the link text "OP Batcher Max Channel Configuration" is in title case.
- See [OP Batcher Max Channel Configuration](/builders/chain-operators/configuration/batcher#set-your--op_batcher_max_channel_duration) for more details. + See [OP Batcher Max Channel Configuration](/builders/chain-operators/configuration/batcher#set-your--op_batcher_max_channel_duration) for more details.
Line range hint
182-182
: Use proper title case for links.Ensure that the link text "OP Mainnet Archive Node" is in title case.
- You can use [Optimism's](/builders/node-operators/management/snapshots#op-mainnet-archive-node) or [run your own](/builders/chain-operators/tools/explorer#create-an-archive-node). + You can use [Optimism's](/builders/node-operators/management/snapshots#op-mainnet-archive-node) or [Run Your Own](/builders/chain-operators/tools/explorer#create-an-archive-node).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ty!
Description
Updates the Fee Parameter Calculator to the Fjord Version https://docs.google.com/spreadsheets/d/1V3CWpeUzXv5Iopw8lBSS8tWoSzyR4PDDwV9cu2kKOrs/edit?gid=186414307#gid=186414307
In the future, maybe we should try to keep the same link / have a link shortener that points to the most recent one?