Skip to content

Update to Fjord Fee Param Calculator #786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 11, 2024
Merged

Update to Fjord Fee Param Calculator #786

merged 2 commits into from
Jul 11, 2024

Conversation

MSilb7
Copy link
Member

@MSilb7 MSilb7 commented Jul 11, 2024

Description

Updates the Fee Parameter Calculator to the Fjord Version https://docs.google.com/spreadsheets/d/1V3CWpeUzXv5Iopw8lBSS8tWoSzyR4PDDwV9cu2kKOrs/edit?gid=186414307#gid=186414307

In the future, maybe we should try to keep the same link / have a link shortener that points to the most recent one?

@MSilb7 MSilb7 requested a review from a team as a code owner July 11, 2024 14:12
@MSilb7 MSilb7 requested a review from a team July 11, 2024 14:12
Copy link
Contributor

coderabbitai bot commented Jul 11, 2024

Walkthrough

The recent update involves modifying a link to a fee parameter calculator in the guide related to using blobs for a chain. This change ensures better estimation of scalar values on the chain by directing users to a more appropriate URL for the fee parameter calculator. There are no changes to the declarations of exported or public entities.

Changes

Files Change Summary
pages/.../chain-operators/management/blobs.mdx Updated the link to a fee parameter calculator to a different URL for better estimation of scalar values on the chain.

Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between d3c2702 and f38d592.

Files selected for processing (1)
  • pages/builders/chain-operators/management/blobs.mdx (1 hunks)
Additional context used
Path-based instructions (1)
pages/builders/chain-operators/management/blobs.mdx (1)

Pattern **/*.mdx: "ALWAYS review Markdown content THOROUGHLY with the following criteria:

  • Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
  • Avoid gender-specific language and use the imperative form.
  • Monitor capitalization for emphasis. Use bold for prominence instead of all caps or italics.
  • Ensure proper nouns are capitalized in sentences.
  • Apply the Oxford comma.
  • Use proper title case for headers, buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
  • Use correct spelling and grammar at all times (IMPORTANT).
    "
Additional comments not posted (1)
pages/builders/chain-operators/management/blobs.mdx (1)

25-25: Verify the new URL is correct.

Ensure that the new URL for the fee parameter calculator is correct and accessible: fee parameter calculator.

Verification successful

Verified: The new URL is correct and accessible.

The URL for the fee parameter calculator fee parameter calculator is valid and reachable.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the new URL for the fee parameter calculator is correct and accessible.

# Test: Check if the URL is reachable.
curl -s -o /dev/null -w "%{http_code}" "https://docs.google.com/spreadsheets/d/1V3CWpeUzXv5Iopw8lBSS8tWoSzyR4PDDwV9cu2kKOrs/edit" | grep -q "200"

Length of output: 143


Script:

#!/bin/bash
# Description: Verify the new URL for the fee parameter calculator is correct and accessible.

# Test: Check if the URL is reachable and print the HTTP status code.
curl -s -o /dev/null -w "%{http_code}\n" "https://docs.google.com/spreadsheets/d/1V3CWpeUzXv5Iopw8lBSS8tWoSzyR4PDDwV9cu2kKOrs/edit"

Length of output: 135


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

netlify bot commented Jul 11, 2024

Deploy Preview for docs-optimism ready!

Name Link
🔨 Latest commit f38d592
🔍 Latest deploy log https://app.netlify.com/sites/docs-optimism/deploys/668fe8e241409b0007d7297d
😎 Deploy Preview https://deploy-preview-786--docs-optimism.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Outside diff range, codebase verification and nitpick comments (9)
pages/builders/chain-operators/management/blobs.mdx (9)

Line range hint 1-7: Ensure proper title case and consistent capitalization.

  • Use proper title case for headers: "Using Blobs" should be "Using Blobs".
  • Ensure consistent capitalization for proper nouns like "Ecotone".
- title: Using Blobs
+ title: Using Blobs

Line range hint 9-9: Use proper title case for headers.

The header "Using Blobs" should be in title case.

- # Using Blobs
+ # Using Blobs

Line range hint 11-12: Avoid gender-specific language.

Replace "This guide walks you through how to switch to using blobs for your chain after Ecotone is activated." with "This guide explains how to switch to using blobs for your chain after Ecotone is activated."

- This guide walks you through how to switch to using blobs for your chain after Ecotone is activated.
+ This guide explains how to switch to using blobs for your chain after Ecotone is activated.

Line range hint 17-17: Use imperative form.

Replace "This guide is intended for chains already upgraded to Ecotone." with "This guide is for chains already upgraded to Ecotone."

- This guide is intended for chains already upgraded to Ecotone.
+ This guide is for chains already upgraded to Ecotone.

Line range hint 45-45: Use the Oxford comma.

Add a comma after "your chain".

- Input the average transaction per day your chain is processing, the types of transactions that occur on your chain, the [`OP_BATCHER_MAX_CHANNEL_DURATION`](/builders/chain-operators/configuration/batcher#setting-your--op_batcher_max_channel_duration) you have parameterized on your `op-batcher`, and the target margin you wish to charge users on top of your L1 costs.
+ Input the average transaction per day your chain is processing, the types of transactions that occur on your chain, the [`OP_BATCHER_MAX_CHANNEL_DURATION`](/builders/chain-operators/configuration/batcher#setting-your--op_batcher_max_channel_duration) you have parameterized on your `op-batcher`, and the target margin you wish to charge users on top of your L1 costs.

Line range hint 45-45: Use proper title case for links.

Ensure that the link text "OP_BATCHER_MAX_CHANNEL_DURATION" is in title case.

- the [`OP_BATCHER_MAX_CHANNEL_DURATION`](/builders/chain-operators/configuration/batcher#setting-your--op_batcher_max_channel_duration)
+ the [`OP_BATCHER_MAX_CHANNEL_DURATION`](/builders/chain-operators/configuration/batcher#setting-your--op_batcher_max_channel_duration)

Line range hint 116-116: Use proper title case for links.

Ensure that the link text "Transaction Fees, Ecotone section" is in title case.

- For more details on fee scalar, see [Transaction Fees, Ecotone section](/stack/transactions/fees#ecotone).
+ For more details on fee scalar, see [Transaction Fees, Ecotone Section](/stack/transactions/fees#ecotone).

Line range hint 121-121: Use proper title case for links.

Ensure that the link text "OP Batcher Max Channel Configuration" is in title case.

- See [OP Batcher Max Channel Configuration](/builders/chain-operators/configuration/batcher#set-your--op_batcher_max_channel_duration) for more details.
+ See [OP Batcher Max Channel Configuration](/builders/chain-operators/configuration/batcher#set-your--op_batcher_max_channel_duration) for more details.

Line range hint 182-182: Use proper title case for links.

Ensure that the link text "OP Mainnet Archive Node" is in title case.

- You can use [Optimism's](/builders/node-operators/management/snapshots#op-mainnet-archive-node) or [run your own](/builders/chain-operators/tools/explorer#create-an-archive-node).
+ You can use [Optimism's](/builders/node-operators/management/snapshots#op-mainnet-archive-node) or [Run Your Own](/builders/chain-operators/tools/explorer#create-an-archive-node).

Copy link
Collaborator

@sbvegan sbvegan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty!

@sbvegan sbvegan merged commit 4f109ad into main Jul 11, 2024
7 of 8 checks passed
@sbvegan sbvegan deleted the MSilb7-patch-1 branch July 11, 2024 14:20
@coderabbitai coderabbitai bot mentioned this pull request Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants