Skip to content

Sentence casing all headers #946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 21, 2024
Merged

Sentence casing all headers #946

merged 6 commits into from
Oct 21, 2024

Conversation

bradleycamacho
Copy link
Member

This sentence cases all headers on the docs site to align with our new style guide

Copy link

netlify bot commented Oct 2, 2024

Deploy Preview for docs-optimism ready!

Name Link
🔨 Latest commit ef61966
🔍 Latest deploy log https://app.netlify.com/sites/docs-optimism/deploys/6716853128431a0008601a17
😎 Deploy Preview https://deploy-preview-946--docs-optimism.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bradleycamacho bradleycamacho marked this pull request as ready for review October 8, 2024 20:22
@bradleycamacho bradleycamacho requested a review from a team as a code owner October 8, 2024 20:22
@bradleycamacho bradleycamacho changed the title Sentence casing all headsers Sentence casing all headers Oct 8, 2024
sbvegan
sbvegan previously approved these changes Oct 8, 2024
@bradleycamacho bradleycamacho marked this pull request as draft October 8, 2024 20:25
@bradleycamacho
Copy link
Member Author

Sorry, accidently flipped this to ready for review when it isn't yet. Wanted to verify the coderabbit rules.

Copy link
Contributor

coderabbitai bot commented Oct 8, 2024

Walkthrough

The pull request includes several modifications across multiple documentation files, primarily focusing on changing section headers and titles from title case to sentence case for consistency. The content within the sections remains largely unchanged, with minor textual adjustments made for clarity. The changes affect documents related to bridging basics, custom bridges, messaging, and the standard bridge, ensuring a uniform style throughout the documentation.

Changes

File Path Change Summary
pages/builders/app-developers/bridging/*.mdx Titles and section headers changed from title case to sentence case; minor textual corrections.

Possibly related issues

Possibly related PRs

Suggested labels

documentation

Suggested reviewers

  • krofax

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Outside diff range and nitpick comments (1)
pages/builders/app-developers/bridging/custom-bridge.mdx (1)

Line range hint 21-30: Guidelines section updates are informative and well-structured

The changes in the "Guidelines" section provide valuable information about custom bridges, their risks, and best practices. The use of "you" is consistent, and the technical terms are appropriately formatted. The grammar and spelling are correct.

Consider adding a link to the Superchain Bridges UI for easier reference:

Bridges that extend this interface will be compatible with the [Superchain Bridges UI](https://app.optimism.io/bridge).

This change would improve the user experience by providing direct access to the mentioned UI.

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between a101eee and e85ee98.

📒 Files selected for processing (4)
  • pages/builders/app-developers/bridging/basics.mdx (1 hunks)
  • pages/builders/app-developers/bridging/custom-bridge.mdx (2 hunks)
  • pages/builders/app-developers/bridging/messaging.mdx (7 hunks)
  • pages/builders/app-developers/bridging/standard-bridge.mdx (4 hunks)
✅ Files skipped from review due to trivial changes (2)
  • pages/builders/app-developers/bridging/basics.mdx
  • pages/builders/app-developers/bridging/standard-bridge.mdx
🧰 Additional context used
📓 Path-based instructions (2)
pages/builders/app-developers/bridging/custom-bridge.mdx (1)

Pattern **/*.mdx: "ALWAYS review Markdown content THOROUGHLY with the following criteria:

  • Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
  • Avoid gender-specific language and use the imperative form.
  • Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
  • Ensure proper nouns are capitalized in sentences.
  • Apply the Oxford comma.
  • Use proper title case for headers, buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
  • Use correct spelling and grammar at all times (IMPORTANT).
  • Use sentence case for H1, H2, and H3 headers, capitalizing only the first word and any proper nouns.
  • For all headers (H1, H2, H3), do not change the capitalization of proper nouns; keep them as they are.
    "
pages/builders/app-developers/bridging/messaging.mdx (1)

Pattern **/*.mdx: "ALWAYS review Markdown content THOROUGHLY with the following criteria:

  • Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
  • Avoid gender-specific language and use the imperative form.
  • Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
  • Ensure proper nouns are capitalized in sentences.
  • Apply the Oxford comma.
  • Use proper title case for headers, buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
  • Use correct spelling and grammar at all times (IMPORTANT).
  • Use sentence case for H1, H2, and H3 headers, capitalizing only the first word and any proper nouns.
  • For all headers (H1, H2, H3), do not change the capitalization of proper nouns; keep them as they are.
    "
🪛 LanguageTool
pages/builders/app-developers/bridging/messaging.mdx

[typographical] ~131-~131: If specifying a range, consider using an en dash instead of a hyphen.
Context: ...sent from L1 to L2 take approximately 1-3 minutes to get from Ethereum to OP Ma...

(HYPHEN_TO_EN)

🔇 Additional comments (2)
pages/builders/app-developers/bridging/custom-bridge.mdx (2)

9-12: Introductory paragraph changes look good

The rephrasing in the introductory paragraph improves clarity and maintains a consistent tone. The use of "you" is appropriate as it directly addresses the reader, which is suitable for documentation. The grammar and spelling are correct.


38-38: Header change to sentence case is correct

The change from "Next Steps" to "Next steps" correctly applies the guideline for using sentence case in H2 headers. This modification improves consistency throughout the document.

@sbvegan sbvegan dismissed their stale review October 8, 2024 20:26

still in draft

@bradleycamacho bradleycamacho marked this pull request as ready for review October 18, 2024 14:29
@bradleycamacho bradleycamacho merged commit 5e4fe7c into main Oct 21, 2024
7 of 8 checks passed
@bradleycamacho bradleycamacho deleted the sentence-case-headers branch October 21, 2024 22:45
This was referenced Oct 23, 2024
@coderabbitai coderabbitai bot mentioned this pull request Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants