Add SmellToken to Superchain token list #1137
Conversation
|
Hi @ethereum-optimism/devxpod @wbnns, the validate-workflow check is failing with exit code 1, but I lack admin access to view detailed error messages in CircleCI (https://app.circleci.com/pipelines/github/ethereum-optimism/ethereum-optimism.github.io/1670/workflows/eace4635-173b-4b09-b1a9-2938353f87fd/jobs/4748). Could you share the specific error from the err.txt or std.txt logs? I’ve updated data.json and logo.svg, and they appear correct locally. Thanks! |
|
hey @samir0x you can locally run the validation script, Not sure why you've created a optimism directory within /data. I recommend looking at some of the other tokens in the data folder and following the same format |
I've created optimism directory because I am applying the project to OP atlas, I looked and tried all possible ways, am still getting error and still didn't get approve! any suggestions? thank you in advance |
wbnns
added
base
|
Hi @samir0x please rebase against the latest master branch, should fix the CI errors! |
hello @fainashalts I tried and didn't work, any hints? |
| @@ -22,7 +22,7 @@ program | |||
| 'Comma-separated list of token symbols to validate' | |||
| ) | |||
| .action(async (options) => { | |||
| const results = await validate(options.datadir, options.tokens.split(',')) | |||
| const results = await validate(options.datadir, options.tokens ? options.tokens.split(',') : undefined) | |||
There was a problem hiding this comment.
why is this change here?
There was a problem hiding this comment.
I don't know why! do i need to delete those lines from the code?
appreciate your replies
|
Hi @samir0x there seem to be some files in this PR that are not part of adding a token. Please review the readme and make sure you're only proposing code for adding your specific token! |
Adds SmellToken at 0xfE26A8562BF54Cf9Ad9DD1971f0636d9a732fEBB to the Optimism token list for the smellcheckmate project.
“This token supports community engagement on Optimism”