Skip to content

fix: remove georli & drop emoji support for now #694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 18, 2024
Merged

fix: remove georli & drop emoji support for now #694

merged 7 commits into from
Mar 18, 2024

Conversation

hamdiallam
Copy link
Contributor

Validation failures

  • Goerli Network Shutdown
  • LikeButton.eth token entry. Override the heart emoji symbol to LIKE until we can fix validation to support emojis

@hamdiallam hamdiallam requested a review from a team as a code owner March 14, 2024 19:54
@hamdiallam Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hamdiallam and the rest of your teammates on Graphite Graphite

@hamdiallam hamdiallam changed the title fix: remove georli fix: remove georli & drop emoji support for now Mar 14, 2024
rcbgr
rcbgr previously requested changes Mar 14, 2024
View reviewed changes
Copy link

@rcbgr rcbgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM. There appears to be a new token in there. Was this properly reviewed? There were also some removes that seemed opinionated.

roninjin10
roninjin10 previously requested changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@roninjin10 roninjin10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because you removed a token you will need to do a major version bump

@mergify mergify bot dismissed stale reviews from rcbgr and roninjin10 March 15, 2024 16:24

Pull request has been modified.

roninjin10
roninjin10 previously approved these changes Mar 15, 2024
View reviewed changes
Copy link
Contributor

@roninjin10 roninjin10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm run test -u should fix the test failure

@hamdiallam hamdiallam mentioned this pull request Mar 18, 2024
Merged
@mergify mergify bot merged commit a20d8ed into master Mar 18, 2024
8 checks passed
@mergify mergify bot deleted the 03-14-tokenlist.fix_remove_unicode_entry branch March 18, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roninjin10 roninjin10 roninjin10 approved these changes

@rcbgr rcbgr rcbgr left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hamdiallam @roninjin10 @rcbgr