Skip to content

op-node: add FETCH_WITHDRAWAL_ROOT_FROM_STATE config var #15150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 4, 2025

Conversation

geoknee
Copy link
Contributor

@geoknee geoknee commented Apr 1, 2025

This was an action item arising from the FMA for the "withdrawals root in block header" feature bundled into Isthmus.

Link: https://github.com/ethereum-optimism/design-docs/blob/1d1ff3a666c1ffba3b8d92e09db08d7efc7234d7/security/fma-withdrawals-root-in-block-header.md?plain=1#L102

  • wired up to the L2ClientConfig.
  • escape hatch for isthmus behaviour in L2Client.outputV0

Tests

This has been tested locally with kurtosis (set the boolean as an env var, execute cast rpc optimism_outputAtBlock 0x1 --rpc-url http://localhost:53439 | jq .withdrawalStorageRoot and watch the logs for the new log line). I also cross checked an op-node with the flag on with one with the flag off for consistency.

- wired up to the L2ClientConfig.
- escape hatch for isthmus behaviour in L2Client.outputV0
@geoknee geoknee changed the title op-node: add MESSAGE_PASSER_ROOT_FROM_STATE config var op-node: add MESSAGE_PASSER_ROOT_FROM_STATE config var Apr 1, 2025
Copy link

codecov bot commented Apr 1, 2025

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 45.22%. Comparing base (83b1ffc) to head (8049f7f).
Report is 26 commits behind head on develop.

Files with missing lines Patch % Lines
op-service/sources/l2_client.go 0.00% 10 Missing ⚠️
op-node/node/node.go 0.00% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (83b1ffc) and HEAD (8049f7f). Click for more details.

HEAD has 8 uploads less than BASE
Flag BASE (83b1ffc) HEAD (8049f7f)
cannon-go-tests-32 3 0
cannon-go-tests-64 3 0
2 1
contracts-bedrock-tests 2 1
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #15150       +/-   ##
============================================
- Coverage    75.22%   45.22%   -30.01%     
============================================
  Files          184     1149      +965     
  Lines        11481    97248    +85767     
============================================
+ Hits          8637    43980    +35343     
- Misses        2637    50083    +47446     
- Partials       207     3185     +2978     
Flag Coverage Δ
cannon-go-tests-32 ?
cannon-go-tests-64 ?
contracts-bedrock-tests 94.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
op-node/flags/flags.go 83.33% <ø> (ø)
op-node/node/config.go 0.00% <ø> (ø)
op-node/service.go 0.00% <ø> (ø)
op-node/node/node.go 0.35% <0.00%> (ø)
op-service/sources/l2_client.go 0.00% <0.00%> (ø)

... and 1088 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@geoknee geoknee marked this pull request as ready for review April 1, 2025 21:01
@geoknee geoknee requested review from a team as code owners April 1, 2025 21:01
@geoknee geoknee self-assigned this Apr 2, 2025
@geoknee geoknee added the H-isthmus Hardfork: change is planned for isthmus upgrade label Apr 2, 2025
@geoknee geoknee moved this to In Review in Protocol Team Apr 2, 2025
@geoknee geoknee changed the title op-node: add MESSAGE_PASSER_ROOT_FROM_STATE config var op-node: add FETCH_WITHDRAWAL_ROOT_FROM_STATE config var Apr 3, 2025
Copy link
Member

@sebastianst sebastianst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, lgtm, just some typo nits

@geoknee geoknee added this pull request to the merge queue Apr 4, 2025
Merged via the queue into develop with commit 322eac1 Apr 4, 2025
50 checks passed
@geoknee geoknee deleted the gk/wr-fallback branch April 4, 2025 10:29
@github-project-automation github-project-automation bot moved this from In Review to Done in Protocol Team Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
H-isthmus Hardfork: change is planned for isthmus upgrade
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants