-
Notifications
You must be signed in to change notification settings - Fork 3.6k
op-node: add FETCH_WITHDRAWAL_ROOT_FROM_STATE
config var
#15150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- wired up to the L2ClientConfig. - escape hatch for isthmus behaviour in L2Client.outputV0
MESSAGE_PASSER_ROOT_FROM_STATE
config var
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #15150 +/- ##
============================================
- Coverage 75.22% 45.22% -30.01%
============================================
Files 184 1149 +965
Lines 11481 97248 +85767
============================================
+ Hits 8637 43980 +35343
- Misses 2637 50083 +47446
- Partials 207 3185 +2978
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
MESSAGE_PASSER_ROOT_FROM_STATE
config varFETCH_WITHDRAWAL_ROOT_FROM_STATE
config var
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, lgtm, just some typo nits
Co-authored-by: Sebastian Stammler <[email protected]>
This was an action item arising from the FMA for the "withdrawals root in block header" feature bundled into Isthmus.
Link: https://github.com/ethereum-optimism/design-docs/blob/1d1ff3a666c1ffba3b8d92e09db08d7efc7234d7/security/fma-withdrawals-root-in-block-header.md?plain=1#L102
Tests
This has been tested locally with kurtosis (set the boolean as an env var, execute
cast rpc optimism_outputAtBlock 0x1 --rpc-url http://localhost:53439 | jq .withdrawalStorageRoot
and watch the logs for the new log line). I also cross checked an op-node with the flag on with one with the flag off for consistency.