Skip to content

op-e2e: Migrate tests on game mechanics to the Super DG #15247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 8, 2025

Conversation

Inphi
Copy link
Contributor

@Inphi Inphi commented Apr 4, 2025

Part 2 of the FDG test migration to support the Super game type.

This migration focuses on game mechanics that are unchanged in the Super DG, and are agnostic to the game-type. Generic test scenarios are introduced, using the gameArena object, to de-dup a lot of the test setup.
The remaining game-type specific tests will be migrated in a later PR.

part of #14974

Copy link

codecov bot commented Apr 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.50%. Comparing base (eb393e5) to head (d7b5cdc).
Report is 4 commits behind head on inphi/opcm-e2e-fp.

Additional details and impacted files
@@                  Coverage Diff                   @@
##           inphi/opcm-e2e-fp   #15247       +/-   ##
======================================================
- Coverage              60.41%   43.50%   -16.91%     
======================================================
  Files                     67     1103     +1036     
  Lines                   5399    96953    +91554     
======================================================
+ Hits                    3262    42184    +38922     
- Misses                  1957    51425    +49468     
- Partials                 180     3344     +3164     
Flag Coverage Δ
cannon-go-tests-32 62.08% <ø> (ø)
cannon-go-tests-64 57.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1044 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Inphi Inphi force-pushed the inphi/opcm-e2e-fp-2 branch from 5d75e3b to 7fd8a38 Compare April 4, 2025 22:36
@Inphi Inphi force-pushed the inphi/opcm-e2e-fp-2 branch from 7fd8a38 to a145593 Compare April 7, 2025 13:33
@Inphi Inphi marked this pull request as ready for review April 7, 2025 13:34
@Inphi Inphi requested review from a team as code owners April 7, 2025 13:34
@Inphi Inphi requested review from ajsutton and bitwiseguy and removed request for a team April 7, 2025 13:34
Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with just the one comment which I'm hoping explains the failing test.

@Inphi Inphi merged commit e716fc8 into inphi/opcm-e2e-fp Apr 8, 2025
51 checks passed
@Inphi Inphi deleted the inphi/opcm-e2e-fp-2 branch April 8, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants