Skip to content

op-e2e: Migrate the remaining Super DG tests #15315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Conversation

Inphi
Copy link
Contributor

@Inphi Inphi commented Apr 9, 2025

The remaining FDG e2e tests are migrated to the Super DG. This migration was mostly done by duplicating a lot of similar tests from the FDG tests. While it's possible to make these tests more generic to the DG type, as was done in previous PRs via the gameArena, doing so at the moment is more trouble than it's worth. So for simplicity I've directly ported the tests. In the future, we should aim to have a more common set of test implementations.

fixes #14974

Copy link

codecov bot commented Apr 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.89%. Comparing base (f083d84) to head (6a93c9d).
Report is 5 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #15315       +/-   ##
============================================
+ Coverage    46.36%   66.89%   +20.53%     
============================================
  Files         1229       59     -1170     
  Lines       103205     4716    -98489     
============================================
- Hits         47847     3155    -44692     
+ Misses       51987     1393    -50594     
+ Partials      3371      168     -3203     
Flag Coverage Δ
cannon-go-tests-32 61.99% <ø> (ø)
cannon-go-tests-64 57.04% <ø> (ø)
contracts-bedrock-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1170 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Inphi Inphi force-pushed the inphi/opcm-e2e-fp branch from 825c80a to 0f1432f Compare April 9, 2025 22:45
@Inphi Inphi marked this pull request as ready for review April 9, 2025 22:45
@Inphi Inphi requested review from a team as code owners April 9, 2025 22:45
@Inphi Inphi requested review from clabby and geoknee April 9, 2025 22:45
Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

In the future, we should aim to have a more common set of test implementations.

I think a while after interop ships we should delete the pre-interop fault dispute games, supporting code and tests. We'll need to keep it around for a while so the challenger continues to support pre-interop games and give chains time to upgrade but we don't want to have to support that code forever. So makes sense to not spend too much time avoiding duplication between the tests.

@Inphi Inphi force-pushed the inphi/opcm-e2e-fp branch from c0e782e to 6a93c9d Compare April 14, 2025 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E2E testing of the Super DG and challenger
2 participants