op-e2e: Reduce max game depth for super cannon games. #16218
+52
−56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit edf0bb9.
At startup the supervisor now sets the safe timestamp to the genesis time.
ajsutton
force-pushed
the
aj/reduce-super-game-max-depth
branch
from
a50bb63 to
e53e58d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## aj/fix-super-tests #16218 +/- ##
=======================================================
- Coverage 46.68% 15.50% -31.18%
=======================================================
Files 1347 8 -1339
Lines 107529 690 -106839
=======================================================
- Hits 50196 107 -50089
+ Misses 53765 571 -53194
+ Partials 3568 12 -3556
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
ajsutton
force-pushed
the
aj/reduce-super-game-max-depth
branch
2 times, most recently
from
df198ae to
377847a
Compare
ajsutton
force-pushed
the
aj/reduce-super-game-max-depth
branch
from
377847a to
63d45cd
Compare
|
Note that the OPCM deployment script expects standard game parameter values - |
|
Yeah but you can disable those checks by setting the Somewhat surprisingly, this doesn't actually seem to be speeding up the cannon tests though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reduce the max depth and split depth for super dispute games so that e2e tests run faster. The new depths match what is used for the pre-interop games in op-e2e.
interopgen now sets the flag to allow custom dispute game params to avoid the deployment reverting. It's only used by tests so hard coding to true simplifies things.