Skip to content

abigen doesn't support imports #2806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Arachnid opened this issue Jul 12, 2016 · 3 comments
Closed

abigen doesn't support imports #2806

Arachnid opened this issue Jul 12, 2016 · 3 comments
Assignees
@fjl
Labels
type:feature

Comments

@Arachnid
Copy link
Contributor

Because abigen invokes the solidity compiler by passing a string, the compiler has no path to work with for imports. It'd be really useful if it supported imports relative to the directory of the root contract being compiled.
@zelig
Copy link
Contributor

zelig commented Jul 12, 2016

+1

@fjl fjl self-assigned this Jul 12, 2016
@fjl
Copy link
Contributor

fjl commented Jul 12, 2016

I already have the code changes for this, will submit shortly.

@fjl fjl mentioned this issue Aug 15, 2016
Merged
fjl added a commit to fjl/go-ethereum that referenced this issue Aug 17, 2016
@fjl
common/compiler: simplify solc wrapper
1a9e669 
Support for legacy version 0.9.x is gone. The compiler version is no
longer cached. Compilation results (and the version) are read directly
from stdout using the --combined-json flag. As a workaround for
ethereum/solidity#651, source code is written to a temporary file before
compilation.

Integration of solc in package ethapi and cmd/abigen is now much simpler
because the compiler wrapper is no longer passed around as a pointer.

Fixes ethereum#2806, accidentally
@fjl
Copy link
Contributor

fjl commented Nov 15, 2016

Fix released in 1.5.0.

@fjl fjl closed this as completed Nov 15, 2016
sduchesneau pushed a commit to streamingfast/go-ethereum that referenced this issue Feb 10, 2025
@zzzckck
Merge pull request ethereum#2806 from bnb-chain/prepare_merge_7702
911c10c 
upstream: merge geth date 1213
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fjl fjl

Labels
type:feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@fjl @Arachnid @adamschmideg @zelig