-
Notifications
You must be signed in to change notification settings - Fork 20.9k
RPC error response object violates JSON-RPC 2.0 specification #289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@tgerring the standard library jsonrpc implementation handles this correctly. |
@fjl I'm not sure how we'd use the standard library to meet our needs in this case since the rpc package maps objects in the format of "Object.Method", differing from the style defined at https://github.com/ethereum/wiki/wiki/Generic-JSON-RPC If it's possible, we can switch code over. |
Damn. I thought there was a way around it. Nevermind then. |
Updates to JSON responses made in 55ed0ff |
Fixed |
update devnet genesis, include DV and slashing
Events for stablecoin
* refactor: split out single-iteration of sequencer loop * refactor: split out single-iteration of verifier loop and re-enable test * refactor: extract context update to separate function * chore: return nil instead of error in latest tx queries If we return an error, this will clutter error logs when the sequencer/verifier is booting up * fix: return error instead of skipping inside of loop Previously, we would continue if an error was returned when: 1. getting a transaction (or if there was no transaction) 2. getting an enqueued transaction (or if there was no enqueued transaction) 3. applying a transaction Instead of silently skipping, we must always return an error. There should be an explicit assumption on the DTL, that it will have no gaps and that it can reliably provide us the data between [start, end]. If not, there should be an error since we want to favor safety over liveness. * chore: test pre-state and log.Debug instead of error
Handle INVALID opcode in the flatCallTracer
* feat(consensus): update `ValidateAnchorTx` * feat(consensus): update `ValidateAnchorTx`
http://www.jsonrpc.org/specification#error_object
However the RPC currently returns an object lacking the
message
andcode
attributes:The text was updated successfully, but these errors were encountered: