core/rawdb/freezer: Report accurate freeze table size #27859
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holiman
reviewed
Aug 8, 2023
Comment on lines
+230
to
+233
| totalSize, _ := table.size() | ||
|
|
||
| // Get the number of tail-deleted elements. | ||
| tailDeletedSize := table.itemHidden.Load() |
There was a problem hiding this comment.
The size() returns size returns the total data size in the freezer table. -- that is, a count of bytes.
The itemHidden, however, is the number of items marked as deleted. -- a count of 'items'.
So unfortunately you cannot just subtract the one from the other
|
Hi @shyam-patel-kira, I will close this PR, and if you keep working on the fix, please just open a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix the issue #27483 of inconsistent size reporting in the FreezerTable data structure. The problem arises when using tail deletion, where removed items are hidden but still kept in the file. The file is only removed when all elements become hidden. However, the current implementation doesn't consider these hidden items in the size calculation, resulting in misleading size reports.
This PR addresses this inconsistency and ensures that the reported size accurately reflects the live elements in the table, even when tail deletion is used.