tests/fuzzers: move fuzzers into native packages #28411
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holiman
requested review from
karalabe,
rjl493456442,
gballet and
MariusVanDerWijden
as code owners
|
Superseded by #28467 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves our fuzzers from
tests/fuzzersinto whatever their respective 'native' package is.The historical reason why they were placed in an external location, is that when they were based on go-fuzz, they could not be "hidden" via the
_test.goprefix. So in order to shove them away from the go-ethereum "production code", they were put aside.But now we've rewritten them to be based on golang
testing, and thus can be brought back. More or less fully, there are still some workarounds required to get around AdamKorcz/go-118-fuzz-build#16 and https://github.com/AdamKorcz/go-118-fuzz-build#using-test-utils-from-other-_testgo-files .This PR also adds a fuzzer for precompiled contracts, because why not.
Still WIP, there are more fuzzers to move.