ethclient: fix the transaction in block testcase #28583
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We observe failure in TestEthClient/TxInBlockInterrupted which can be reproduced by go test -test.v -run=^TestEthClient/TxInBlockInterrupted --count=100 === RUN TestEthClient/TxInBlockInterrupted ethclient_test.go:399: transaction should be nil --- FAIL: TestEthClient (0.03s) This commit removes this part of testcase where the context is canceled before the client call and expects to get the context canceled error. It is because the client does not guarantee to prioritize context check before client call. This commit also adds some checks by use client.TransactionInBlock to query transactions in test block.
|
Oh, I didn't realize that there is a PR working on this already: #28283. So I will close this PR. |
|
Yeah, I added the changes there after the conversation on your earlier PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We observe failure in TestEthClient/TxInBlockInterrupted which can be reproduced by
This commit removes this part of testcase where the context is canceled before the client call and expects to get the context canceled error. It is because the client does not guarantee to prioritize context check before client call. This commit also adds some checks by use client.TransactionInBlock to query transactions in test block.