Skip to content

Amend Inline Assembly docs to include information about dots allowed in identifiers #16051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Amend Inline Assembly docs to include information about dots allowed in identifiers #16051

wants to merge 1 commit into from

Conversation

matheusaaguiar
Copy link
Collaborator

closes #16047.

@matheusaaguiar matheusaaguiar self-assigned this May 14, 2025
@matheusaaguiar matheusaaguiar force-pushed the amendInlineAssemblyDocs branch from cecd02d to f56a04a Compare May 14, 2025 18:38
cameel
cameel previously approved these changes May 14, 2025
View reviewed changes
Copy link
Member

@cameel cameel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, so it was documented here as well. I didn't find it because I searched for "dot". Maybe it would be a good idea to use it in the text here as well to make it more searchable.

@matheusaaguiar matheusaaguiar force-pushed the amendInlineAssemblyDocs branch from f56a04a to 17b48a1 Compare May 15, 2025 03:53
@matheusaaguiar
Copy link
Collaborator Author

Oh, so it was documented here as well. I didn't find it because I searched for "dot". Maybe it would be a good idea to use it in the text here as well to make it more searchable.

I used the word "dots" in the new added text.

@cameel cameel added the 🟡 PR review label label May 16, 2025
@cameel cameel force-pushed the amendInlineAssemblyDocs branch from 17b48a1 to 6ae63c2 Compare May 16, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cameel cameel cameel approved these changes

Assignees

@matheusaaguiar matheusaaguiar

Labels
documentation 📖 🟡 PR review label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Yul identifiers accept dots
2 participants
@matheusaaguiar @cameel