Catch newly raised geth errors when tx indexing in progress #3216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fselmo
force-pushed
the
handle-geth-indexing-waiting-for-tx
branch
from
f109627 to
7993f54
Compare
- Geth ``1.13.11`` started to return an error when transaction indexing is in progress and a ``eth_getTransactionReceipt`` call is made. Handle this in the ``wait_for_transaction_receipt`` method by catching the error in order to continue waiting.
fselmo
force-pushed
the
handle-geth-indexing-waiting-for-tx
branch
from
7993f54 to
b68cd9f
Compare
fselmo
added a commit
to fselmo/web3.py
that referenced
this pull request
Feb 1, 2024
fselmo
force-pushed
the
handle-geth-indexing-waiting-for-tx
branch
from
b757af7 to
9435474
Compare
fselmo
force-pushed
the
handle-geth-indexing-waiting-for-tx
branch
from
9435474 to
91aa57b
Compare
reedsa
approved these changes
Feb 1, 2024
| i = _tx_indexing_response_iterator() | ||
| with request_mocker( | ||
| w3, | ||
| mock_responses={"eth_getTransactionReceipt": lambda *_: next(i)}, |
There was a problem hiding this comment.
This iterator approach is really cool! 😎
There was a problem hiding this comment.
yeah, this is way cleaner than the v6 way! nice!
| the RPC response. ``mock_errors`` is a dict mapping method names to the desired | ||
| "error" object of the RPC response. If a method name is not in either dict, | ||
| the request is made as usual. | ||
| Example with async and a mocked response object: |
There was a problem hiding this comment.
💯 Thanks for expanding this with a nice example!
kclowes
approved these changes
Feb 2, 2024
| i = _tx_indexing_response_iterator() | ||
| with request_mocker( | ||
| w3, | ||
| mock_responses={"eth_getTransactionReceipt": lambda *_: next(i)}, |
There was a problem hiding this comment.
yeah, this is way cleaner than the v6 way! nice!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Related to Issue #3212
1.13.11started to return an error when transaction indexing is in progress and aeth_getTransactionReceiptcall is made.How was it fixed?
wait_for_transaction_receiptmethod by catching the error in order to continue waiting.Todo:
Cute Animal Picture