[v6] Catch newly raised geth errors when tx indexing in progress #3217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Geth ``1.13.11`` started to return an error when transaction indexing is in progress and a ``eth_getTransactionReceipt`` call is made. Handle this in the ``wait_for_transaction_receipt`` method by catching the error in order to continue waiting.
fselmo
force-pushed
the
v6-handle-geth-indexing-waiting-for-tx
branch
from
937d131 to
31c5126
Compare
reedsa
approved these changes
Feb 1, 2024
| error_middleware = construct_error_generator_middleware( | ||
| { | ||
| RPC.eth_getTransactionReceipt: lambda *_: ( | ||
| _swap_error_middleware_for_result_middleware_and_return_error( |
There was a problem hiding this comment.
Super funky but this seems like a good way to test the error/response.
| receipt = w3.eth.wait_for_transaction_receipt(f"0x{'00' * 32}") | ||
| assert receipt == {"status": 1} | ||
|
|
||
| assert "error_middleware" not in w3.middleware_onion.middlewares |
There was a problem hiding this comment.
Nit: This seems like it would always be true given the expected receipt came back. Curious if you have thoughts for this assertion?
There was a problem hiding this comment.
This is just to add an extra layer of assertion for better code readability. Sanity check that the error_middleware is getting cleaned up when we add the result_middleware which is why we don't remove it from the onion below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
1.13.11started to return an error when transaction indexing is in progress and aeth_getTransactionReceiptcall is made.Related to Issue #3212
How was it fixed?
wait_for_transaction_receiptmethod by catching the error in order to continue waiting.Todo:
Cute Animal Picture