Skip to content

Fix Closing dependency resolution #711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from
+98 −10
Closed

Fix Closing dependency resolution #711

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
5118340
Allow Closing to detect dependent resources passed as kwargs too #636
federinik Dec 21, 2022
f3d7e68
Use of update operator (|=) as per https://peps.python.org/pep-0584/
federinik Dec 22, 2022
5cdf114
Add tests for nested deps resolution
jazzthief May 8, 2023
d00afd9
Fix resolution
jazzthief May 12, 2023
43a14df
Merge remote-tracking branch 'origin-godeltech/702-nested-resource-re…
federinik May 23, 2023
3cdba79
Merge pull request #1 from federinik/master
jazzthief May 23, 2023
027ccfa
Restructure conditionals, incorporate kwargs check
jazzthief May 23, 2023
2dabfaa
Add test container with element after resource
jazzthief May 23, 2023
2ca44a0
Use parametrized fixture for containers
jazzthief May 23, 2023
6494256
Restore removed `inject` marker
jazzthief May 24, 2023
c013154
Use `Singleton` provider; clean up formatting
jazzthief May 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tests/unit/samples/wiringstringids/resourceclosing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ def test_function_dependency_kwargs(factory: FactoryService = Closing[Provide["f
return factory


@inject
def test_function_nested_dependency(
nested: NestedService = Closing[Provide["nested_service"]]
):
Expand Down