Skip to content

Improve debugability of deepcopy errors #839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 1, 2025
Merged

Conversation

ZipFile
Copy link
Contributor

@ZipFile ZipFile commented Dec 14, 2024

This PR indirectly addresses issues mentioned in #712 and #734 by adding more specialized versions of deepcopy for providers that accept args and/or kwargs (Factory, List, etc...).

This is not a solution for the issues mentioned above, but it will help users to figure out what caused the error, since deepcopy stack traces are not informative at all.

@coveralls
Copy link

coveralls commented Dec 14, 2024

Coverage Status

coverage: 94.195% (+0.08%) from 94.119%
when pulling 9950093 on better-deepcopy-errors
into aa56b70 on develop.

@ZipFile ZipFile force-pushed the better-deepcopy-errors branch from e9f705f to 9950093 Compare December 14, 2024 14:08
Copy link
Member

@rmk135 rmk135 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @ZipFile ! That's a good improvement indeed!

@ZipFile ZipFile merged commit d82d9fb into develop Jan 1, 2025
28 checks passed
@ZipFile ZipFile deleted the better-deepcopy-errors branch January 1, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants