Skip to content

🔧: Depend on typing_extensions only on Python <3.8 #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 5, 2022

Conversation

hukkin
Copy link
Contributor

@hukkin hukkin commented Oct 28, 2022

No description provided.

@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Base: 89.86% // Head: 89.83% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (fdb7eba) compared to base (28725fc).
Patch coverage: 83.33% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #642      +/-   ##
==========================================
- Coverage   89.86%   89.83%   -0.03%     
==========================================
  Files          21       21              
  Lines        2150     2154       +4     
==========================================
+ Hits         1932     1935       +3     
- Misses        218      219       +1     
Flag Coverage Δ
pytests 89.83% <83.33%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
myst_parser/_compat.py 87.50% <75.00%> (-12.50%) ⬇️
myst_parser/config/dc_validators.py 85.45% <100.00%> (ø)
myst_parser/parsers/docutils_.py 81.08% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@chrisjsewell chrisjsewell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cheers

@chrisjsewell chrisjsewell changed the title ♻️: Depend on typing_extensions only on Python <3.8 🔧: Depend on typing_extensions only on Python <3.8 Dec 5, 2022
@chrisjsewell chrisjsewell merged commit 11756a1 into executablebooks:master Dec 5, 2022
@hukkin hukkin deleted the no-typing-extensions branch December 5, 2022 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants