palindrome-products: update tests to v1.2.0 #627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cmccandless would you be so kind to resolve this so we can get it merged? |
|
@SleeplessByte resolved! |
|
Accidental close. Please ignore that. |
cmccandless
changed the title
cmccandless
changed the title
|
Merge/rebase issue has been cleaned up. Once Travis finished, this should be good for squash-merge. |
|
@SleeplessByte OK, now I'm lost. What of my changes would've affected the Travis build like that? I'm just ran |
|
@tejasbubane have you seen this weird |
|
This is an issue with Jest and latest node on travis. Fixed by using LTS in #634. Please merge or rebase this branch on master. |
|
@tejasbubane rebased, thanks for the info! |
tejasbubane
reviewed
Mar 8, 2019
tejasbubane
approved these changes
Mar 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #626