rational-numbers Add additional test cases
#1914
Conversation
| "r": [-3, 5], | ||
| "n": -2 | ||
| }, | ||
| "expected": [-25, 9] |
There was a problem hiding this comment.
as I understand it, the result should be positive here, because a negative times a negative (we square the number) will be positive.
However, if we had taken the power -3, it would remain negative.
There was a problem hiding this comment.
| "expected": [-25, 9] | |
| "expected": [25, 9] |
We could have cases for both n = -2 and n = -3 too.
There was a problem hiding this comment.
D'oh 🤦 you are right! Fixed the test and added a new one with an odd negative power.
| "r": [-3, 5], | ||
| "n": -2 | ||
| }, | ||
| "expected": [-25, 9] |
There was a problem hiding this comment.
| "expected": [-25, 9] | |
| "expected": [25, 9] |
We could have cases for both n = -2 and n = -3 too.
…gative to odd power
There was a problem hiding this comment.
OK. But, you would do better to use a word in https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue so that it automatically closes the issue
Fixes #1909 . Any feedback welcome!
Note I have not ran the schema check. Relying on CI.