Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable ETag for res.sendFile() #2294

Closed
ritch opened this issue Aug 12, 2014 · 2 comments · Fixed by #6073
Closed

Disable ETag for res.sendFile() #2294

ritch opened this issue Aug 12, 2014 · 2 comments · Fixed by #6073
Assignees
@UlisesGascon
Labels
5.x enhancement
Milestone
5.0

Comments

@ritch
Copy link
Member

ritch commented Aug 12, 2014

res.sendFile() accepts an option to disable ETags. It would make sense that app.disable('etag') sets sendFile()s options.etag to false for you. This is a breaking change so it would have to wait for 5.x.
@ritch ritch added the Ideas label Aug 12, 2014
@ritch ritch mentioned this issue Aug 12, 2014
Closed
@dougwilson dougwilson added 5.x and removed Ideas labels Aug 21, 2014
@dougwilson dougwilson mentioned this issue Aug 22, 2014
Merged
39 tasks
@dougwilson dougwilson added this to the 5.x milestone Aug 22, 2014
@ilanbiala
Copy link

@ritch did this make it into 5.x already?

@dougwilson
Copy link
Contributor

Hi @ilanbiala you can look at #2237 to see what has been checked off. The answer for this is no, especially since there is not hard date for 5.0 yet.

@hrvolapeter hrvolapeter mentioned this issue Mar 13, 2016
Closed
@expressjs expressjs deleted a comment from martinies Jun 3, 2020
@kokushkin kokushkin mentioned this issue Nov 9, 2021
Open
juanarbol added a commit to juanarbol/express that referenced this issue Oct 18, 2024
@juanarbol
response: add support for ETag option in res.sendFile
f7b47d0 
This patch introduces the ability to control the ETag generation
through the `res.sendFile` function. Specifically, the ETag option
is wired to the application's configuration, allowing it to be
enabled or disabled based on the app's settings.

Fixes: expressjs#2294
Signed-off-by: Juan José Arboleda <[email protected]>
@juanarbol juanarbol mentioned this issue Oct 18, 2024
Merged
@UlisesGascon UlisesGascon self-assigned this Oct 18, 2024
wesleytodd pushed a commit to juanarbol/express that referenced this issue Feb 13, 2025
@juanarbol @wesleytodd
feat: add support for ETag option in res.sendFile
85cc7f5 
This patch introduces the ability to control the ETag generation
through the `res.sendFile` function. Specifically, the ETag option
is wired to the application's configuration, allowing it to be
enabled or disabled based on the app's settings.

Fixes: expressjs#2294
Signed-off-by: Juan José Arboleda <[email protected]>
wesleytodd pushed a commit that referenced this issue Feb 13, 2025
@juanarbol
feat: add support for ETag option in res.sendFile (#6073)
327af12 
This patch introduces the ability to control the ETag generation
through the `res.sendFile` function. Specifically, the ETag option
is wired to the application's configuration, allowing it to be
enabled or disabled based on the app's settings.

Fixes: #2294

Signed-off-by: Juan José Arboleda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@UlisesGascon UlisesGascon

Labels
5.x enhancement
Projects
None yet
Milestone
5.0
Development

Successfully merging a pull request may close this issue.

response: add support for ETag option in res.sendFile juanarbol/express
4 participants
@dougwilson @ritch @ilanbiala @UlisesGascon