Skip to content

Change wildcard to catch routes #1583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

IamLizu
Copy link
Member

@IamLizu IamLizu commented Aug 23, 2024

As #1408 points out, the wildcard defined no longer works. So, replaced * with (.*) in 5.x specific files. I have also installed the 5.x from npm and verified the wildcard change for root level and api level routes present in the docs.

Notes

Copy link

netlify bot commented Aug 23, 2024

Deploy Preview for expressjscom-preview ready!

Name Link
🔨 Latest commit 5928cce
🔍 Latest deploy log https://app.netlify.com/sites/expressjscom-preview/deploys/66c8430efdf9980008f7d70e
😎 Deploy Preview https://deploy-preview-1583--expressjscom-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bjohansebas
Copy link
Member

bjohansebas commented Aug 27, 2024

@IamLizu It seems that this PR has the same changes as #1369, Which one should we keep?

@IamLizu
Copy link
Member Author

IamLizu commented Sep 1, 2024

@IamLizu It seems that this PR has the same changes as #1369, Which one should we keep?

We should definitely land the existing one. My bad I didn't check for this. I am closing this in reference of #1369

@IamLizu IamLizu closed this Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

express 5 router wildcard does not work as documented
2 participants