Problem setting up fork to provide contributions

[draperd]

I'm trying to set up a fork of this project so that I can contribute back to it (this is my first attempt at contributing back so this might be considered a general problem, rather than a specific "create-react-app" problem - but since I want to contribute to this project I thought I'd raise it here).

I've looked at the contributing guide and have forked (rather than cloned as suggested although I don't think that should make a difference) the repository.

I've built the project using npm install (which is successful).

However, when running npm run create-react-app my-app as suggested I get the following error output:

dave@dave-Precision-5510 ~/Git/Personal/create-react-app $ npm run create-react-app my-app

> @ create-react-app /mnt/DATA/Git/Personal/create-react-app
> tasks/cra.sh "my-app"

+ cd ..
+ root_path=/home/dave/Git/Personal/create-react-app
+ /home/dave/Git/Personal/create-react-app/node_modules/.bin/lerna bootstrap
Lerna v2.0.0-beta.38
Independent Versioning Mode
Bootstrapping 5 packages
Preinstalling packages
Symlinking packages and binaries
Postinstalling packages
Prepublishing packages
Successfully bootstrapped 5 packages.
+ cd packages/react-scripts
+ cp package.json package.json.orig
+ node /home/dave/Git/Personal/create-react-app/tasks/replace-own-deps.js
Replaced local dependencies.
++ npm pack
+ scripts_path=/home/dave/Git/Personal/create-react-app/packages/react-scripts/react-scripts-0.9.4.tgz
+ rm package.json
+ mv package.json.orig package.json
+ yarn cache clean
yarn cache v0.23.4
success Cleared cache.
Done in 0.03s.
+ cd /home/dave/Git/Personal/create-react-app
+ node packages/create-react-app/index.js --scripts-version=/home/dave/Git/Personal/create-react-app/packages/react-scripts/react-scripts-0.9.4.tgz my-app
Creating a new React app in /mnt/DATA/Git/Personal/create-react-app/my-app.

Installing packages. This might take a couple minutes.
Installing react, react-dom, and react-scripts...

yarn add v0.23.4
info No lockfile found.
[1/4] Resolving packages...
error An unexpected error occurred: "https://registry.npmjs.org/home/dave/Git/Personal/create-react-app/packages/react-scripts/react-scripts-0.9.4.tgz: Request failed \"404 Not Found\"".
info If you think this is a bug, please open a bug report with the information provided in "/mnt/DATA/Git/Personal/create-react-app/my-app/yarn-error.log".
info Visit https://yarnpkg.com/en/docs/cli/add for documentation about this command.

Aborting installation.
  yarnpkg add --exact react react-dom /home/dave/Git/Personal/create-react-app/packages/react-scripts/react-scripts-0.9.4.tgz has failed.

Deleting generated file... package.json
Deleting generated file... yarn-error.log
Deleting my-app / from /mnt/DATA/Git/Personal/create-react-app
Done.
++ set +x
cra.sh: ERROR! An error was encountered executing line 83.
Cleaning up.
Exiting with error.

The error appears to be caused by the 404 that occurs when attempting to access https://registry.npmjs.org/home/dave/Git/Personal/create-react-app/packages/react-scripts/react-scripts-0.9.4.tgz.

Am I doing something wrong here or is there an issue with the contribution instructions?

[gaearon]

I think this is a Yarn bug that was fixed yesterday.
Can you please update Yarn to the latest version?

[draperd]

Do you know what version of Yarn is needed? ... I seem to be on the latest version from the Debian package:

dave@dave-Precision-5510 ~/Git/Personal/create-react-app $ sudo apt-get install yarn
Reading package lists... Done
Building dependency tree       
Reading state information... Done
yarn is already the newest version (0.23.4-1).

[gaearon]

Yea, CI is not fixed either 😞
We thought it got fixed but seems like something else is causing this.

cc @bestander

[draperd]

OK, thanks for clarifying the situation. Just bad timing on my part that I tried to do this today by the looks of things!

Thanks for the fast response as always!

[gaearon]

Seems like it should work with Yarn 0.22 (which was before the bug was intro'd).

[bestander]

Yeah, I suggest to rollback to 0.22, we should fix it in 0.24 this week

…

On 3 May 2017 at 17:04, Dan Abramov ***@***.***> wrote: Seems like it should work with Yarn 0.22 (which was before the bug was intro'd). — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2072 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACBdWAK3pkFaz6mlbcuuynxPZBU5RT3Vks5r2KWHgaJpZM4NPZln> .

[draperd]

Great, thanks for the advice - I'll give that a go.

[draperd]

Awesome that worked a treat - thanks :-)