-
-
Notifications
You must be signed in to change notification settings - Fork 27k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Converting mocha tests to jest #2316
Converting mocha tests to jest #2316
Conversation
I don’t think this worked, judging by CI logs:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to fix it to run the tests.
@gaearon This is weird. I can see tests passing in travis. In Appveyor it is showing that there are no tests. am I missing something? |
Maybe Maybe we could either change the pattern to be cross platform, or just |
@gaearon Small insights will be very helpful. I tried both going to the directory and executing |
On the CI, I see this command:
As I mentioned earlier it might not work on Windows because of Can you try instead |
@gaearon OK. Let me try that. Thank you very much! |
Seems like we need to configure Jest to handle it? Why does it work with Mocha? |
@gaearon it was most likely due to mocha handling I suspect the issue here is that we are setting |
So what do we need to do? This almost works. |
We probably just need to switch the |
This is fairly close, but it now fails due to CSS/image imports. Can we point them to our mocks to fix this? |
Completed via #4550. |
Converting mocha tests to jest
Fix for #2294